* [v2] irqchip: ls-extirq: add flag IRQCHIP_SKIP_SET_WAKE to remove call trace
@ 2021-01-27 8:58 Biwen Li
2021-01-27 11:38 ` Marc Zyngier
0 siblings, 1 reply; 7+ messages in thread
From: Biwen Li @ 2021-01-27 8:58 UTC (permalink / raw)
To: mark.rutland, leoyang.li, tglx, jason, maz
Cc: Biwen Li, jiafei.pan, ran.wang_1, linux-kernel, linux-arm-kernel
From: Biwen Li <biwen.li@nxp.com>
Add flag IRQCHIP_SKIP_SET_WAKE to remove call trace as follow,
...
[ 45.605239] Unbalanced IRQ 120 wake disable
[ 45.609445] WARNING: CPU: 0 PID: 1124 at kernel/irq/manage.c:800 irq_set_irq_wake+0x154/0x1a0
...
[ 45.645141] pstate: 60000085 (nZCv daIf -PAN -UAO -TCO BTYPE=--)
[ 45.651144] pc : irq_set_irq_wake+0x154/0x1a0
[ 45.655497] lr : irq_set_irq_wake+0x154/0x1a0
...
[ 45.742825] Call trace:
[ 45.745268] irq_set_irq_wake+0x154/0x1a0
[ 45.749278] ds3232_resume+0x38/0x50
On ls2088ardb:
In suspend progress(# echo mem > /sys/power/state),
pm_suspend()->suspend_devices_and_enter()->dpm_suspend()->device_suspend()
->ds3232_suspend()->enable_irq_wake()->irq_set_irq_wake()
->set_irq_wake_real(), return -ENXIO, there get
"Cannot set wakeup source" in ds3232_suspend().
In resume progress(wakeup by flextimer)
dpm_resume_end()->dpm_resume()
->device_resume()->ds3232_resume()
->disable_irq_wake()->irq_set_irq_wake()
->set_irq_wake_real(), there get
kernel call trace(Unbalanced IRQ 120 wake
disable)
Signed-off-by: Biwen Li <biwen.li@nxp.com>
---
Change in v2:
- update description
drivers/irqchip/irq-ls-extirq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-ls-extirq.c b/drivers/irqchip/irq-ls-extirq.c
index 564e6de0bd8e..3c6ed7b4744d 100644
--- a/drivers/irqchip/irq-ls-extirq.c
+++ b/drivers/irqchip/irq-ls-extirq.c
@@ -65,7 +65,7 @@ static struct irq_chip ls_extirq_chip = {
.irq_set_type = ls_extirq_set_type,
.irq_retrigger = irq_chip_retrigger_hierarchy,
.irq_set_affinity = irq_chip_set_affinity_parent,
- .flags = IRQCHIP_SET_TYPE_MASKED,
+ .flags = IRQCHIP_SET_TYPE_MASKED | IRQCHIP_SKIP_SET_WAKE,
};
static int
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [v2] irqchip: ls-extirq: add flag IRQCHIP_SKIP_SET_WAKE to remove call trace
2021-01-27 8:58 [v2] irqchip: ls-extirq: add flag IRQCHIP_SKIP_SET_WAKE to remove call trace Biwen Li
@ 2021-01-27 11:38 ` Marc Zyngier
2021-01-28 2:37 ` Biwen Li (OSS)
0 siblings, 1 reply; 7+ messages in thread
From: Marc Zyngier @ 2021-01-27 11:38 UTC (permalink / raw)
To: Biwen Li
Cc: mark.rutland, Biwen Li, jason, linux-kernel, leoyang.li, tglx,
ran.wang_1, jiafei.pan, linux-arm-kernel
On 2021-01-27 08:58, Biwen Li wrote:
> From: Biwen Li <biwen.li@nxp.com>
>
> Add flag IRQCHIP_SKIP_SET_WAKE to remove call trace as follow,
> ...
> [ 45.605239] Unbalanced IRQ 120 wake disable
> [ 45.609445] WARNING: CPU: 0 PID: 1124 at kernel/irq/manage.c:800
> irq_set_irq_wake+0x154/0x1a0
> ...
> [ 45.645141] pstate: 60000085 (nZCv daIf -PAN -UAO -TCO BTYPE=--)
> [ 45.651144] pc : irq_set_irq_wake+0x154/0x1a0
> [ 45.655497] lr : irq_set_irq_wake+0x154/0x1a0
> ...
> [ 45.742825] Call trace:
> [ 45.745268] irq_set_irq_wake+0x154/0x1a0
> [ 45.749278] ds3232_resume+0x38/0x50
>
> On ls2088ardb:
> In suspend progress(# echo mem > /sys/power/state),
> pm_suspend()->suspend_devices_and_enter()->dpm_suspend()->device_suspend()
> ->ds3232_suspend()->enable_irq_wake()->irq_set_irq_wake()
> ->set_irq_wake_real(), return -ENXIO, there get
> "Cannot set wakeup source" in ds3232_suspend().
>
> In resume progress(wakeup by flextimer)
> dpm_resume_end()->dpm_resume()
> ->device_resume()->ds3232_resume()
> ->disable_irq_wake()->irq_set_irq_wake()
> ->set_irq_wake_real(), there get
> kernel call trace(Unbalanced IRQ 120 wake
> disable)
This is again paraphrasing the stack trace instead of explaining
the problem it fixes. How about:
"The ls-extirq driver doesn't implement the irq_set_wake()
callback, while being wake-up capable. This results in
ugly behaviours across suspend/resume cycles.
Advertise this by adding IRQCHIP_SKIP_SET_WAKE to the irqchip
flags"
The subject line should be fixed along the same lines, and
a Fixes: tag added.
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread* RE: [v2] irqchip: ls-extirq: add flag IRQCHIP_SKIP_SET_WAKE to remove call trace
2021-01-27 11:38 ` Marc Zyngier
@ 2021-01-28 2:37 ` Biwen Li (OSS)
2021-01-28 9:02 ` Marc Zyngier
0 siblings, 1 reply; 7+ messages in thread
From: Biwen Li (OSS) @ 2021-01-28 2:37 UTC (permalink / raw)
To: Marc Zyngier, Biwen Li (OSS)
Cc: mark.rutland, jason, linux-kernel, Leo Li, tglx, Ran Wang,
Jiafei Pan, linux-arm-kernel
> -----Original Message-----
> From: Marc Zyngier <maz@kernel.org>
> Sent: 2021年1月27日 19:38
> To: Biwen Li (OSS) <biwen.li@oss.nxp.com>
> Cc: mark.rutland@arm.com; Leo Li <leoyang.li@nxp.com>; tglx@linutronix.de;
> jason@lakedaemon.net; linux-kernel@vger.kernel.org; Jiafei Pan
> <jiafei.pan@nxp.com>; linux-arm-kernel@lists.infradead.org; Ran Wang
> <ran.wang_1@nxp.com>; Biwen Li <biwen.li@nxp.com>
> Subject: Re: [v2] irqchip: ls-extirq: add flag IRQCHIP_SKIP_SET_WAKE to
> remove call trace
>
> On 2021-01-27 08:58, Biwen Li wrote:
> > From: Biwen Li <biwen.li@nxp.com>
> >
> > Add flag IRQCHIP_SKIP_SET_WAKE to remove call trace as follow, ...
> > [ 45.605239] Unbalanced IRQ 120 wake disable
> > [ 45.609445] WARNING: CPU: 0 PID: 1124 at kernel/irq/manage.c:800
> > irq_set_irq_wake+0x154/0x1a0
> > ...
> > [ 45.645141] pstate: 60000085 (nZCv daIf -PAN -UAO -TCO BTYPE=--)
> > [ 45.651144] pc : irq_set_irq_wake+0x154/0x1a0
> > [ 45.655497] lr : irq_set_irq_wake+0x154/0x1a0
> > ...
> > [ 45.742825] Call trace:
> > [ 45.745268] irq_set_irq_wake+0x154/0x1a0
> > [ 45.749278] ds3232_resume+0x38/0x50
> >
> > On ls2088ardb:
> > In suspend progress(# echo mem > /sys/power/state),
> >
> pm_suspend()->suspend_devices_and_enter()->dpm_suspend()->device_suspe
> > nd()
> > ->ds3232_suspend()->enable_irq_wake()->irq_set_irq_wake()
> > ->set_irq_wake_real(), return -ENXIO, there get
> > "Cannot set wakeup source" in ds3232_suspend().
> >
> > In resume progress(wakeup by flextimer)
> > dpm_resume_end()->dpm_resume()
> > ->device_resume()->ds3232_resume()
> > ->disable_irq_wake()->irq_set_irq_wake()
> > ->set_irq_wake_real(), there get
> > kernel call trace(Unbalanced IRQ 120 wake
> > disable)
>
> This is again paraphrasing the stack trace instead of explaining the problem it
> fixes. How about:
>
> "The ls-extirq driver doesn't implement the irq_set_wake()
> callback, while being wake-up capable. This results in
> ugly behaviours across suspend/resume cycles.
>
> Advertise this by adding IRQCHIP_SKIP_SET_WAKE to the irqchip
> flags"
>
> The subject line should be fixed along the same lines, and a Fixes: tag added.
Okay, got it. Thanks. Will update in v3.
>
> M.
> --
> Jazz is not dead. It just smells funny...
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [v2] irqchip: ls-extirq: add flag IRQCHIP_SKIP_SET_WAKE to remove call trace
2021-01-28 2:37 ` Biwen Li (OSS)
@ 2021-01-28 9:02 ` Marc Zyngier
2021-01-29 2:55 ` Biwen Li (OSS)
0 siblings, 1 reply; 7+ messages in thread
From: Marc Zyngier @ 2021-01-28 9:02 UTC (permalink / raw)
To: Biwen Li (OSS)
Cc: mark.rutland, linux-kernel, Leo Li, Jiafei Pan, Ran Wang, tglx,
linux-arm-kernel
On 2021-01-28 02:37, Biwen Li (OSS) wrote:
>> -----Original Message-----
>> From: Marc Zyngier <maz@kernel.org>
>> Sent: 2021年1月27日 19:38
>> To: Biwen Li (OSS) <biwen.li@oss.nxp.com>
>> Cc: mark.rutland@arm.com; Leo Li <leoyang.li@nxp.com>;
>> tglx@linutronix.de;
>> jason@lakedaemon.net; linux-kernel@vger.kernel.org; Jiafei Pan
>> <jiafei.pan@nxp.com>; linux-arm-kernel@lists.infradead.org; Ran Wang
>> <ran.wang_1@nxp.com>; Biwen Li <biwen.li@nxp.com>
>> Subject: Re: [v2] irqchip: ls-extirq: add flag IRQCHIP_SKIP_SET_WAKE
>> to
>> remove call trace
>>
>> On 2021-01-27 08:58, Biwen Li wrote:
>> > From: Biwen Li <biwen.li@nxp.com>
>> >
>> > Add flag IRQCHIP_SKIP_SET_WAKE to remove call trace as follow, ...
>> > [ 45.605239] Unbalanced IRQ 120 wake disable
>> > [ 45.609445] WARNING: CPU: 0 PID: 1124 at kernel/irq/manage.c:800
>> > irq_set_irq_wake+0x154/0x1a0
>> > ...
>> > [ 45.645141] pstate: 60000085 (nZCv daIf -PAN -UAO -TCO BTYPE=--)
>> > [ 45.651144] pc : irq_set_irq_wake+0x154/0x1a0
>> > [ 45.655497] lr : irq_set_irq_wake+0x154/0x1a0
>> > ...
>> > [ 45.742825] Call trace:
>> > [ 45.745268] irq_set_irq_wake+0x154/0x1a0
>> > [ 45.749278] ds3232_resume+0x38/0x50
>> >
>> > On ls2088ardb:
>> > In suspend progress(# echo mem > /sys/power/state),
>> >
>> pm_suspend()->suspend_devices_and_enter()->dpm_suspend()->device_suspe
>> > nd()
>> > ->ds3232_suspend()->enable_irq_wake()->irq_set_irq_wake()
>> > ->set_irq_wake_real(), return -ENXIO, there get
>> > "Cannot set wakeup source" in ds3232_suspend().
>> >
>> > In resume progress(wakeup by flextimer)
>> > dpm_resume_end()->dpm_resume()
>> > ->device_resume()->ds3232_resume()
>> > ->disable_irq_wake()->irq_set_irq_wake()
>> > ->set_irq_wake_real(), there get
>> > kernel call trace(Unbalanced IRQ 120 wake
>> > disable)
>>
>> This is again paraphrasing the stack trace instead of explaining the
>> problem it
>> fixes. How about:
>>
>> "The ls-extirq driver doesn't implement the irq_set_wake()
>> callback, while being wake-up capable. This results in
>> ugly behaviours across suspend/resume cycles.
>>
>> Advertise this by adding IRQCHIP_SKIP_SET_WAKE to the irqchip
>> flags"
>>
>> The subject line should be fixed along the same lines, and a Fixes:
>> tag added.
> Okay, got it. Thanks. Will update in v3.
... and v3 still doesn't have a Fixes: tag.
Frankly, if you can't be bothered to do this, why should I worry
about your platform being broken?
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread* RE: [v2] irqchip: ls-extirq: add flag IRQCHIP_SKIP_SET_WAKE to remove call trace
2021-01-28 9:02 ` Marc Zyngier
@ 2021-01-29 2:55 ` Biwen Li (OSS)
2021-01-29 8:54 ` Marc Zyngier
0 siblings, 1 reply; 7+ messages in thread
From: Biwen Li (OSS) @ 2021-01-29 2:55 UTC (permalink / raw)
To: Marc Zyngier, Biwen Li (OSS)
Cc: mark.rutland, linux-kernel, Leo Li, Jiafei Pan, Ran Wang, tglx,
linux-arm-kernel
> -----Original Message-----
> From: Marc Zyngier <maz@kernel.org>
> Sent: 2021年1月28日 17:02
> To: Biwen Li (OSS) <biwen.li@oss.nxp.com>
> Cc: mark.rutland@arm.com; Leo Li <leoyang.li@nxp.com>; tglx@linutronix.de;
> linux-kernel@vger.kernel.org; Jiafei Pan <jiafei.pan@nxp.com>;
> linux-arm-kernel@lists.infradead.org; Ran Wang <ran.wang_1@nxp.com>
> Subject: Re: [v2] irqchip: ls-extirq: add flag IRQCHIP_SKIP_SET_WAKE to
> remove call trace
>
> On 2021-01-28 02:37, Biwen Li (OSS) wrote:
> >> -----Original Message-----
> >> From: Marc Zyngier <maz@kernel.org>
> >> Sent: 2021年1月27日 19:38
> >> To: Biwen Li (OSS) <biwen.li@oss.nxp.com>
> >> Cc: mark.rutland@arm.com; Leo Li <leoyang.li@nxp.com>;
> >> tglx@linutronix.de; jason@lakedaemon.net;
> >> linux-kernel@vger.kernel.org; Jiafei Pan <jiafei.pan@nxp.com>;
> >> linux-arm-kernel@lists.infradead.org; Ran Wang <ran.wang_1@nxp.com>;
> >> Biwen Li <biwen.li@nxp.com>
> >> Subject: Re: [v2] irqchip: ls-extirq: add flag IRQCHIP_SKIP_SET_WAKE
> >> to remove call trace
> >>
> >> On 2021-01-27 08:58, Biwen Li wrote:
> >> > From: Biwen Li <biwen.li@nxp.com>
> >> >
> >> > Add flag IRQCHIP_SKIP_SET_WAKE to remove call trace as follow, ...
> >> > [ 45.605239] Unbalanced IRQ 120 wake disable
> >> > [ 45.609445] WARNING: CPU: 0 PID: 1124 at kernel/irq/manage.c:800
> >> > irq_set_irq_wake+0x154/0x1a0
> >> > ...
> >> > [ 45.645141] pstate: 60000085 (nZCv daIf -PAN -UAO -TCO BTYPE=--)
> >> > [ 45.651144] pc : irq_set_irq_wake+0x154/0x1a0
> >> > [ 45.655497] lr : irq_set_irq_wake+0x154/0x1a0
> >> > ...
> >> > [ 45.742825] Call trace:
> >> > [ 45.745268] irq_set_irq_wake+0x154/0x1a0
> >> > [ 45.749278] ds3232_resume+0x38/0x50
> >> >
> >> > On ls2088ardb:
> >> > In suspend progress(# echo mem > /sys/power/state),
> >> >
> >>
> pm_suspend()->suspend_devices_and_enter()->dpm_suspend()->device_susp
> >> e
> >> > nd()
> >> > ->ds3232_suspend()->enable_irq_wake()->irq_set_irq_wake()
> >> > ->set_irq_wake_real(), return -ENXIO, there get
> >> > "Cannot set wakeup source" in ds3232_suspend().
> >> >
> >> > In resume progress(wakeup by flextimer)
> >> > dpm_resume_end()->dpm_resume()
> >> > ->device_resume()->ds3232_resume()
> >> > ->disable_irq_wake()->irq_set_irq_wake()
> >> > ->set_irq_wake_real(), there get
> >> > kernel call trace(Unbalanced IRQ 120 wake
> >> > disable)
> >>
> >> This is again paraphrasing the stack trace instead of explaining the
> >> problem it fixes. How about:
> >>
> >> "The ls-extirq driver doesn't implement the irq_set_wake()
> >> callback, while being wake-up capable. This results in
> >> ugly behaviours across suspend/resume cycles.
> >>
> >> Advertise this by adding IRQCHIP_SKIP_SET_WAKE to the irqchip
> >> flags"
> >>
> >> The subject line should be fixed along the same lines, and a Fixes:
> >> tag added.
> > Okay, got it. Thanks. Will update in v3.
>
> ... and v3 still doesn't have a Fixes: tag.
>
> Frankly, if you can't be bothered to do this, why should I worry about your
> platform being broken?
Oh, sorry. Don't know how to add a fixes? Any suggestions? Thanks.
>
> M.
> --
> Jazz is not dead. It just smells funny...
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [v2] irqchip: ls-extirq: add flag IRQCHIP_SKIP_SET_WAKE to remove call trace
2021-01-29 2:55 ` Biwen Li (OSS)
@ 2021-01-29 8:54 ` Marc Zyngier
2021-01-29 9:44 ` Biwen Li (OSS)
0 siblings, 1 reply; 7+ messages in thread
From: Marc Zyngier @ 2021-01-29 8:54 UTC (permalink / raw)
To: Biwen Li (OSS)
Cc: mark.rutland, linux-kernel, Leo Li, Jiafei Pan, Ran Wang, tglx,
linux-arm-kernel
On 2021-01-29 02:55, Biwen Li (OSS) wrote:
>> -----Original Message-----
>> From: Marc Zyngier <maz@kernel.org>
>> Sent: 2021年1月28日 17:02
>> To: Biwen Li (OSS) <biwen.li@oss.nxp.com>
>> Cc: mark.rutland@arm.com; Leo Li <leoyang.li@nxp.com>;
>> tglx@linutronix.de;
>> linux-kernel@vger.kernel.org; Jiafei Pan <jiafei.pan@nxp.com>;
>> linux-arm-kernel@lists.infradead.org; Ran Wang <ran.wang_1@nxp.com>
>> Subject: Re: [v2] irqchip: ls-extirq: add flag IRQCHIP_SKIP_SET_WAKE
>> to
>> remove call trace
>>
>> On 2021-01-28 02:37, Biwen Li (OSS) wrote:
>> >> -----Original Message-----
>> >> From: Marc Zyngier <maz@kernel.org>
>> >> Sent: 2021年1月27日 19:38
>> >> To: Biwen Li (OSS) <biwen.li@oss.nxp.com>
>> >> Cc: mark.rutland@arm.com; Leo Li <leoyang.li@nxp.com>;
>> >> tglx@linutronix.de; jason@lakedaemon.net;
>> >> linux-kernel@vger.kernel.org; Jiafei Pan <jiafei.pan@nxp.com>;
>> >> linux-arm-kernel@lists.infradead.org; Ran Wang <ran.wang_1@nxp.com>;
>> >> Biwen Li <biwen.li@nxp.com>
>> >> Subject: Re: [v2] irqchip: ls-extirq: add flag IRQCHIP_SKIP_SET_WAKE
>> >> to remove call trace
>> >>
>> >> On 2021-01-27 08:58, Biwen Li wrote:
>> >> > From: Biwen Li <biwen.li@nxp.com>
>> >> >
>> >> > Add flag IRQCHIP_SKIP_SET_WAKE to remove call trace as follow, ...
>> >> > [ 45.605239] Unbalanced IRQ 120 wake disable
>> >> > [ 45.609445] WARNING: CPU: 0 PID: 1124 at kernel/irq/manage.c:800
>> >> > irq_set_irq_wake+0x154/0x1a0
>> >> > ...
>> >> > [ 45.645141] pstate: 60000085 (nZCv daIf -PAN -UAO -TCO BTYPE=--)
>> >> > [ 45.651144] pc : irq_set_irq_wake+0x154/0x1a0
>> >> > [ 45.655497] lr : irq_set_irq_wake+0x154/0x1a0
>> >> > ...
>> >> > [ 45.742825] Call trace:
>> >> > [ 45.745268] irq_set_irq_wake+0x154/0x1a0
>> >> > [ 45.749278] ds3232_resume+0x38/0x50
>> >> >
>> >> > On ls2088ardb:
>> >> > In suspend progress(# echo mem > /sys/power/state),
>> >> >
>> >>
>> pm_suspend()->suspend_devices_and_enter()->dpm_suspend()->device_susp
>> >> e
>> >> > nd()
>> >> > ->ds3232_suspend()->enable_irq_wake()->irq_set_irq_wake()
>> >> > ->set_irq_wake_real(), return -ENXIO, there get
>> >> > "Cannot set wakeup source" in ds3232_suspend().
>> >> >
>> >> > In resume progress(wakeup by flextimer)
>> >> > dpm_resume_end()->dpm_resume()
>> >> > ->device_resume()->ds3232_resume()
>> >> > ->disable_irq_wake()->irq_set_irq_wake()
>> >> > ->set_irq_wake_real(), there get
>> >> > kernel call trace(Unbalanced IRQ 120 wake
>> >> > disable)
>> >>
>> >> This is again paraphrasing the stack trace instead of explaining the
>> >> problem it fixes. How about:
>> >>
>> >> "The ls-extirq driver doesn't implement the irq_set_wake()
>> >> callback, while being wake-up capable. This results in
>> >> ugly behaviours across suspend/resume cycles.
>> >>
>> >> Advertise this by adding IRQCHIP_SKIP_SET_WAKE to the irqchip
>> >> flags"
>> >>
>> >> The subject line should be fixed along the same lines, and a Fixes:
>> >> tag added.
>> > Okay, got it. Thanks. Will update in v3.
>>
>> ... and v3 still doesn't have a Fixes: tag.
>>
>> Frankly, if you can't be bothered to do this, why should I worry about
>> your
>> platform being broken?
> Oh, sorry. Don't know how to add a fixes? Any suggestions? Thanks.
Please read Documentation/process/submitting-patches.rst, and specially
the section titled "Describe your changes".
In your cases, there are only two commits for this driver, so picking
the one that had a bug shouldn't be too hard.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread* RE: [v2] irqchip: ls-extirq: add flag IRQCHIP_SKIP_SET_WAKE to remove call trace
2021-01-29 8:54 ` Marc Zyngier
@ 2021-01-29 9:44 ` Biwen Li (OSS)
0 siblings, 0 replies; 7+ messages in thread
From: Biwen Li (OSS) @ 2021-01-29 9:44 UTC (permalink / raw)
To: Marc Zyngier, Biwen Li (OSS)
Cc: mark.rutland, linux-kernel, Leo Li, Jiafei Pan, Ran Wang, tglx,
linux-arm-kernel
> -----Original Message-----
> From: Marc Zyngier <maz@kernel.org>
> Sent: 2021年1月29日 16:55
> To: Biwen Li (OSS) <biwen.li@oss.nxp.com>
> Cc: mark.rutland@arm.com; Leo Li <leoyang.li@nxp.com>; tglx@linutronix.de;
> linux-kernel@vger.kernel.org; Jiafei Pan <jiafei.pan@nxp.com>;
> linux-arm-kernel@lists.infradead.org; Ran Wang <ran.wang_1@nxp.com>
> Subject: Re: [v2] irqchip: ls-extirq: add flag IRQCHIP_SKIP_SET_WAKE to
> remove call trace
>
> On 2021-01-29 02:55, Biwen Li (OSS) wrote:
> >> -----Original Message-----
> >> From: Marc Zyngier <maz@kernel.org>
> >> Sent: 2021年1月28日 17:02
> >> To: Biwen Li (OSS) <biwen.li@oss.nxp.com>
> >> Cc: mark.rutland@arm.com; Leo Li <leoyang.li@nxp.com>;
> >> tglx@linutronix.de; linux-kernel@vger.kernel.org; Jiafei Pan
> >> <jiafei.pan@nxp.com>; linux-arm-kernel@lists.infradead.org; Ran Wang
> >> <ran.wang_1@nxp.com>
> >> Subject: Re: [v2] irqchip: ls-extirq: add flag IRQCHIP_SKIP_SET_WAKE
> >> to remove call trace
> >>
> >> On 2021-01-28 02:37, Biwen Li (OSS) wrote:
> >> >> -----Original Message-----
> >> >> From: Marc Zyngier <maz@kernel.org>
> >> >> Sent: 2021年1月27日 19:38
> >> >> To: Biwen Li (OSS) <biwen.li@oss.nxp.com>
> >> >> Cc: mark.rutland@arm.com; Leo Li <leoyang.li@nxp.com>;
> >> >> tglx@linutronix.de; jason@lakedaemon.net;
> >> >> linux-kernel@vger.kernel.org; Jiafei Pan <jiafei.pan@nxp.com>;
> >> >> linux-arm-kernel@lists.infradead.org; Ran Wang
> >> >> <ran.wang_1@nxp.com>; Biwen Li <biwen.li@nxp.com>
> >> >> Subject: Re: [v2] irqchip: ls-extirq: add flag
> >> >> IRQCHIP_SKIP_SET_WAKE to remove call trace
> >> >>
> >> >> On 2021-01-27 08:58, Biwen Li wrote:
> >> >> > From: Biwen Li <biwen.li@nxp.com>
> >> >> >
> >> >> > Add flag IRQCHIP_SKIP_SET_WAKE to remove call trace as follow, ...
> >> >> > [ 45.605239] Unbalanced IRQ 120 wake disable
> >> >> > [ 45.609445] WARNING: CPU: 0 PID: 1124 at
> kernel/irq/manage.c:800
> >> >> > irq_set_irq_wake+0x154/0x1a0
> >> >> > ...
> >> >> > [ 45.645141] pstate: 60000085 (nZCv daIf -PAN -UAO -TCO BTYPE=--)
> >> >> > [ 45.651144] pc : irq_set_irq_wake+0x154/0x1a0
> >> >> > [ 45.655497] lr : irq_set_irq_wake+0x154/0x1a0
> >> >> > ...
> >> >> > [ 45.742825] Call trace:
> >> >> > [ 45.745268] irq_set_irq_wake+0x154/0x1a0
> >> >> > [ 45.749278] ds3232_resume+0x38/0x50
> >> >> >
> >> >> > On ls2088ardb:
> >> >> > In suspend progress(# echo mem > /sys/power/state),
> >> >> >
> >> >>
> >>
> pm_suspend()->suspend_devices_and_enter()->dpm_suspend()->device_susp
> >> >> e
> >> >> > nd()
> >> >> > ->ds3232_suspend()->enable_irq_wake()->irq_set_irq_wake()
> >> >> > ->set_irq_wake_real(), return -ENXIO, there get
> >> >> > "Cannot set wakeup source" in ds3232_suspend().
> >> >> >
> >> >> > In resume progress(wakeup by flextimer)
> >> >> > dpm_resume_end()->dpm_resume()
> >> >> > ->device_resume()->ds3232_resume()
> >> >> > ->disable_irq_wake()->irq_set_irq_wake()
> >> >> > ->set_irq_wake_real(), there get
> >> >> > kernel call trace(Unbalanced IRQ 120 wake
> >> >> > disable)
> >> >>
> >> >> This is again paraphrasing the stack trace instead of explaining
> >> >> the problem it fixes. How about:
> >> >>
> >> >> "The ls-extirq driver doesn't implement the irq_set_wake()
> >> >> callback, while being wake-up capable. This results in
> >> >> ugly behaviours across suspend/resume cycles.
> >> >>
> >> >> Advertise this by adding IRQCHIP_SKIP_SET_WAKE to the irqchip
> >> >> flags"
> >> >>
> >> >> The subject line should be fixed along the same lines, and a Fixes:
> >> >> tag added.
> >> > Okay, got it. Thanks. Will update in v3.
> >>
> >> ... and v3 still doesn't have a Fixes: tag.
> >>
> >> Frankly, if you can't be bothered to do this, why should I worry
> >> about your platform being broken?
> > Oh, sorry. Don't know how to add a fixes? Any suggestions? Thanks.
>
> Please read Documentation/process/submitting-patches.rst, and specially the
> section titled "Describe your changes".
>
> In your cases, there are only two commits for this driver, so picking the one
> that had a bug shouldn't be too hard.
Okay, got it. Thanks.
>
> Thanks,
>
> M.
> --
> Jazz is not dead. It just smells funny...
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-01-29 9:45 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-27 8:58 [v2] irqchip: ls-extirq: add flag IRQCHIP_SKIP_SET_WAKE to remove call trace Biwen Li
2021-01-27 11:38 ` Marc Zyngier
2021-01-28 2:37 ` Biwen Li (OSS)
2021-01-28 9:02 ` Marc Zyngier
2021-01-29 2:55 ` Biwen Li (OSS)
2021-01-29 8:54 ` Marc Zyngier
2021-01-29 9:44 ` Biwen Li (OSS)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).