Re: [PATCH 03/14] drm/atmel-hlcdc: Convert to Linux IRQ interfaces

From: Thomas Zimmermann <tzimmermann@suse.de>
To: Sam Ravnborg <sam@ravnborg.org>, Dan.Sneddon@microchip.com
Cc: airlied@linux.ie, liviu.dudau@arm.com, stefan@agner.ch,
	amd-gfx@lists.freedesktop.org, anitha.chrisanthus@intel.com,
	patrik.r.jakobsson@gmail.com, linux-arm-msm@vger.kernel.org,
	freedreno@lists.freedesktop.org, daniel@ffwll.ch,
	edmund.j.dea@intel.com, s.hauer@pengutronix.de,
	alison.wang@nxp.com, maarten.lankhorst@linux.intel.com,
	mripard@kernel.org, dri-devel@lists.freedesktop.org,
	sean@poorly.run, linux-arm-kernel@lists.infradead.org,
	tomba@kernel.org, bbrezillon@kernel.org, jyri.sarha@iki.fi,
	christian.koenig@amd.com, robdclark@gmail.com,
	kernel@pengutronix.de, alexander.deucher@amd.com,
	shawnguo@kernel.org, brian.starkey@arm.com
Subject: Re: [PATCH 03/14] drm/atmel-hlcdc: Convert to Linux IRQ interfaces
Date: Thu, 29 Jul 2021 21:21:14 +0200	[thread overview]
Message-ID: <7067cca1-c8a4-347c-829a-accdce8c6aef@suse.de> (raw)
In-Reply-To: <1df22406-2e91-c15a-49dc-1cf33522a142@suse.de>

[-- Attachment #1.1.1: Type: text/plain, Size: 2298 bytes --]

Hi

Am 29.07.21 um 21:18 schrieb Thomas Zimmermann:
> Hi
> 
> Am 28.07.21 um 22:11 schrieb Sam Ravnborg:
>> Hi Dan,
>>
>>>>
>>>> I think I got it - we need to set irq_enabled to true.
>>>> The documentation says so:
>>>> "
>>>>            * @irq_enabled:
>>>>            *
>>>>            * Indicates that interrupt handling is enabled, 
>>>> specifically vblank
>>>>            * handling. Drivers which don't use drm_irq_install() 
>>>> need to set this
>>>>            * to true manually.
>>>> "
>>>>
>>>> Can you try to add the following line:
>>>>
>>>>
>>>> +static int atmel_hlcdc_dc_irq_install(struct drm_device *dev, 
>>>> unsigned int irq)
>>>> +{
>>>> +       int ret;
>>>> +
>>>> +       if (irq == IRQ_NOTCONNECTED)
>>>> +               return -ENOTCONN;
>>>> +
>>>>
>>>>           dev->irq_enabled = true;                <= THIS LINE
>>>>
>>>>
>>>> +       atmel_hlcdc_dc_irq_disable(dev);
>>>> +
>>>> +       ret = request_irq(irq, atmel_hlcdc_dc_irq_handler, 0, 
>>>> dev->driver->name, dev);
>>>> +       if (ret)
>>>> +               return ret;
>>>>
>>>> I hope this fixes it.
>>>
>>> It does!  With the irq_enabled line added everything is looking good.
> 
> Are you sure, you're testing with the latest drm-misc-next or drm-tip? 
> Because using irq_enabled is deprecated and the flag was recently 
> replaced by commit 1e4cd78ed493 ("drm: Don't test for IRQ support in 
> VBLANK ioctls").

For reference, the cover letter lists

base-commit: 2bda1ca4d4acb4892556fec3a7ea1f02afcd40bb

which is a recent drm-tip created on July 25.

Best regards
Thomas

> 
> Best regards
> Thomas
> 
>>
>> Great, thanks for testing.
>>
>> Thomas - I assume you will do a re-spin and there is likely some fixes
>> for the applied IRQ conversions too.
>>
>> Note - irq_enabled must be cleared if request_irq fails. I did not
>> include this in the testing here.
>>
>>     Sam
>>
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel