* [PATCH] arm64: dts: imx8mm: Fix boot hang at clk init
@ 2019-07-25 9:50 Leonard Crestez
2019-07-26 8:44 ` Abel Vesa
2019-08-03 10:29 ` Shawn Guo
0 siblings, 2 replies; 5+ messages in thread
From: Leonard Crestez @ 2019-07-25 9:50 UTC (permalink / raw)
To: Shawn Guo, Daniel Baluta, Abel Vesa
Cc: Dong Aisheng, Jacky Bai, Stephen Boyd, Michael Turquette,
linux-imx, kernel, Fabio Estevam, linux-clk, linux-arm-kernel,
Li Jun
The assigned-clock-rates property is incorrect (4 elements while
assigned-clocks has length 5) and boot hangs while assigning some
unexpected rates.
Fix by inserting another <400000000>, the intention is to assign both
IMX8MM_CLK_AUDIO_AHB and IMX8MM_CLK_IPG_AUDIO_ROOT 400mhz.
Fixes: df1703896a17 ("arm64: dts: imx8mm: Init rates and parents configs for clocks")
Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
---
Changes since v1:
* Insert and 400mhz instead of <0>
Link to v1: https://patchwork.kernel.org/patch/11057515/
Should probably be squashed into df1703896a17
arch/arm64/boot/dts/freescale/imx8mm.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
index c9a7c0054c5c..7bbdcebc6b57 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
@@ -461,10 +461,11 @@
<&clk IMX8MM_SYS_PLL3>,
<&clk IMX8MM_VIDEO_PLL1>;
assigned-clock-parents = <&clk IMX8MM_SYS_PLL3_OUT>,
<&clk IMX8MM_SYS_PLL1_800M>;
assigned-clock-rates = <0>,
+ <400000000>,
<400000000>,
<750000000>,
<594000000>;
};
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: imx8mm: Fix boot hang at clk init
2019-07-25 9:50 [PATCH] arm64: dts: imx8mm: Fix boot hang at clk init Leonard Crestez
@ 2019-07-26 8:44 ` Abel Vesa
2019-08-03 10:29 ` Shawn Guo
1 sibling, 0 replies; 5+ messages in thread
From: Abel Vesa @ 2019-07-26 8:44 UTC (permalink / raw)
To: Leonard Crestez
Cc: Dong Aisheng, Jacky Bai, Stephen Boyd, Shawn Guo,
Michael Turquette, linux-imx, kernel, Fabio Estevam,
Daniel Baluta, linux-clk, linux-arm-kernel, Li Jun
On 19-07-25 12:50:53, Leonard Crestez wrote:
> The assigned-clock-rates property is incorrect (4 elements while
> assigned-clocks has length 5) and boot hangs while assigning some
> unexpected rates.
>
> Fix by inserting another <400000000>, the intention is to assign both
> IMX8MM_CLK_AUDIO_AHB and IMX8MM_CLK_IPG_AUDIO_ROOT 400mhz.
>
> Fixes: df1703896a17 ("arm64: dts: imx8mm: Init rates and parents configs for clocks")
>
> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
>
Reviewed-by: Abel Vesa <abel.vesa@nxp.com>
> ---
> Changes since v1:
> * Insert and 400mhz instead of <0>
> Link to v1: https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fpatch%2F11057515%2F&data=02%7C01%7Cabel.vesa%40nxp.com%7C3ff24093579746ec316608d710e59733%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636996450584921930&sdata=qEBAnihmelL3S5OK%2BcrNDo5cvno5oIuDWFTlingXFco%3D&reserved=0
>
> Should probably be squashed into df1703896a17
>
> arch/arm64/boot/dts/freescale/imx8mm.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> index c9a7c0054c5c..7bbdcebc6b57 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> @@ -461,10 +461,11 @@
> <&clk IMX8MM_SYS_PLL3>,
> <&clk IMX8MM_VIDEO_PLL1>;
> assigned-clock-parents = <&clk IMX8MM_SYS_PLL3_OUT>,
> <&clk IMX8MM_SYS_PLL1_800M>;
> assigned-clock-rates = <0>,
> + <400000000>,
> <400000000>,
> <750000000>,
> <594000000>;
> };
>
> --
> 2.17.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: imx8mm: Fix boot hang at clk init
2019-07-25 9:50 [PATCH] arm64: dts: imx8mm: Fix boot hang at clk init Leonard Crestez
2019-07-26 8:44 ` Abel Vesa
@ 2019-08-03 10:29 ` Shawn Guo
1 sibling, 0 replies; 5+ messages in thread
From: Shawn Guo @ 2019-08-03 10:29 UTC (permalink / raw)
To: Leonard Crestez
Cc: Dong Aisheng, Abel Vesa, Stephen Boyd, Michael Turquette,
Jacky Bai, linux-imx, kernel, Fabio Estevam, Daniel Baluta,
linux-clk, linux-arm-kernel, Li Jun
On Thu, Jul 25, 2019 at 12:50:53PM +0300, Leonard Crestez wrote:
> The assigned-clock-rates property is incorrect (4 elements while
> assigned-clocks has length 5) and boot hangs while assigning some
> unexpected rates.
>
> Fix by inserting another <400000000>, the intention is to assign both
> IMX8MM_CLK_AUDIO_AHB and IMX8MM_CLK_IPG_AUDIO_ROOT 400mhz.
>
> Fixes: df1703896a17 ("arm64: dts: imx8mm: Init rates and parents configs for clocks")
>
> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
>
> ---
> Changes since v1:
> * Insert and 400mhz instead of <0>
> Link to v1: https://patchwork.kernel.org/patch/11057515/
>
> Should probably be squashed into df1703896a17
Done, thanks.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] arm64: dts: imx8mm: Fix boot hang at clk init
@ 2019-07-24 19:17 Leonard Crestez
2019-07-24 20:28 ` Abel Vesa
0 siblings, 1 reply; 5+ messages in thread
From: Leonard Crestez @ 2019-07-24 19:17 UTC (permalink / raw)
To: Shawn Guo, Daniel Baluta, Abel Vesa
Cc: Dong Aisheng, Jacky Bai, Stephen Boyd, Michael Turquette,
linux-imx, kernel, Fabio Estevam, linux-clk, linux-arm-kernel
The assigned-clock-rates property is incorrect (shorter than
assigned-clocks) and boot hangs becuause incorrect rates are assigned.
Fix by inserting another <0>
Fixes: df1703896a17 ("arm64: dts: imx8mm: Init rates and parents configs for clocks")
Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
---
Found in next-20190724 because that's when df1703896a17 was included.
Perhaps this should be squashed?
diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
index c9a7c0054c5c..8737f833cf9c 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
@@ -461,10 +461,11 @@
<&clk IMX8MM_SYS_PLL3>,
<&clk IMX8MM_VIDEO_PLL1>;
assigned-clock-parents = <&clk IMX8MM_SYS_PLL3_OUT>,
<&clk IMX8MM_SYS_PLL1_800M>;
assigned-clock-rates = <0>,
+ <0>,
<400000000>,
<750000000>,
<594000000>;
};
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: imx8mm: Fix boot hang at clk init
2019-07-24 19:17 Leonard Crestez
@ 2019-07-24 20:28 ` Abel Vesa
0 siblings, 0 replies; 5+ messages in thread
From: Abel Vesa @ 2019-07-24 20:28 UTC (permalink / raw)
To: Leonard Crestez
Cc: Dong Aisheng, Jacky Bai, Stephen Boyd, Shawn Guo,
Michael Turquette, linux-imx, kernel, Fabio Estevam,
Daniel Baluta, linux-clk, linux-arm-kernel
On 19-07-24 22:17:15, Leonard Crestez wrote:
> The assigned-clock-rates property is incorrect (shorter than
> assigned-clocks) and boot hangs becuause incorrect rates are assigned.
>
> Fix by inserting another <0>
>
> Fixes: df1703896a17 ("arm64: dts: imx8mm: Init rates and parents configs for clocks")
>
> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
> ---
> Found in next-20190724 because that's when df1703896a17 was included.
> Perhaps this should be squashed?
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> index c9a7c0054c5c..8737f833cf9c 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> @@ -461,10 +461,11 @@
> <&clk IMX8MM_SYS_PLL3>,
> <&clk IMX8MM_VIDEO_PLL1>;
> assigned-clock-parents = <&clk IMX8MM_SYS_PLL3_OUT>,
> <&clk IMX8MM_SYS_PLL1_800M>;
> assigned-clock-rates = <0>,
> + <0>,
In our tree we have this in the clock provider:
clk_set_rate(clks[IMX8MM_CLK_AUDIO_AHB], 400000000);
clk_set_rate(clks[IMX8MM_CLK_IPG_AUDIO_ROOT], 400000000);
So I guess instead of the newly added <0> you'll have to put <400000000>
which would be the rate for IMX8MM_CLK_IPG_AUDIO_ROOT.
> <400000000>,
> <750000000>,
> <594000000>;
> };
>
> --
> 2.17.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-08-03 10:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-25 9:50 [PATCH] arm64: dts: imx8mm: Fix boot hang at clk init Leonard Crestez
2019-07-26 8:44 ` Abel Vesa
2019-08-03 10:29 ` Shawn Guo
-- strict thread matches above, loose matches on Subject: below --
2019-07-24 19:17 Leonard Crestez
2019-07-24 20:28 ` Abel Vesa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).