* [RESEND PATCH] ARM: multi_v7_defconfig: Build Atmel maXTouch driver as a module
@ 2016-08-16 15:08 Javier Martinez Canillas
2016-09-02 15:38 ` Arnd Bergmann
0 siblings, 1 reply; 3+ messages in thread
From: Javier Martinez Canillas @ 2016-08-16 15:08 UTC (permalink / raw)
To: linux-arm-kernel
The driver is for a trackpad device so is not needed for booting and
makes more sense to have it as module to reduce the kernel image size.
It was probably enabled as built-in because module autoload was not
working when the I2C device was registered by OF but this got fixed
in commit b7d21058b40b ("Input: atmel_mxt_ts - add maxtouch to I2C
table for module autoload") so it's safe to enable as a module now.
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
arch/arm/configs/multi_v7_defconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index 2c8665cd9dc5..5d4fb28fb34f 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -277,7 +277,7 @@ CONFIG_MOUSE_PS2_ELANTECH=y
CONFIG_MOUSE_CYAPA=m
CONFIG_MOUSE_ELAN_I2C=y
CONFIG_INPUT_TOUCHSCREEN=y
-CONFIG_TOUCHSCREEN_ATMEL_MXT=y
+CONFIG_TOUCHSCREEN_ATMEL_MXT=m
CONFIG_TOUCHSCREEN_MMS114=m
CONFIG_TOUCHSCREEN_ST1232=m
CONFIG_TOUCHSCREEN_STMPE=y
--
2.5.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [RESEND PATCH] ARM: multi_v7_defconfig: Build Atmel maXTouch driver as a module
2016-08-16 15:08 [RESEND PATCH] ARM: multi_v7_defconfig: Build Atmel maXTouch driver as a module Javier Martinez Canillas
@ 2016-09-02 15:38 ` Arnd Bergmann
2016-09-04 23:31 ` Javier Martinez Canillas
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2016-09-02 15:38 UTC (permalink / raw)
To: linux-arm-kernel
On Tuesday, August 16, 2016 11:08:14 AM CEST Javier Martinez Canillas wrote:
> The driver is for a trackpad device so is not needed for booting and
> makes more sense to have it as module to reduce the kernel image size.
>
> It was probably enabled as built-in because module autoload was not
> working when the I2C device was registered by OF but this got fixed
> in commit b7d21058b40b ("Input: atmel_mxt_ts - add maxtouch to I2C
> table for module autoload") so it's safe to enable as a module now.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
Applied to next/defconfig.
My preferred way is to get defconfig updates forwarded by the platform
maintainers that are interested, but this seems to apply to multiple
platforms, so I'm not asking you to pick one to resend it to.
Arnd
^ permalink raw reply [flat|nested] 3+ messages in thread
* [RESEND PATCH] ARM: multi_v7_defconfig: Build Atmel maXTouch driver as a module
2016-09-02 15:38 ` Arnd Bergmann
@ 2016-09-04 23:31 ` Javier Martinez Canillas
0 siblings, 0 replies; 3+ messages in thread
From: Javier Martinez Canillas @ 2016-09-04 23:31 UTC (permalink / raw)
To: linux-arm-kernel
Hello Arnd,
On 09/02/2016 05:38 PM, Arnd Bergmann wrote:
> On Tuesday, August 16, 2016 11:08:14 AM CEST Javier Martinez Canillas wrote:
>> The driver is for a trackpad device so is not needed for booting and
>> makes more sense to have it as module to reduce the kernel image size.
>>
>> It was probably enabled as built-in because module autoload was not
>> working when the I2C device was registered by OF but this got fixed
>> in commit b7d21058b40b ("Input: atmel_mxt_ts - add maxtouch to I2C
>> table for module autoload") so it's safe to enable as a module now.
>>
>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>>
>> ---
>
> Applied to next/defconfig.
>
Thanks.
> My preferred way is to get defconfig updates forwarded by the platform
> maintainers that are interested, but this seems to apply to multiple
> platforms, so I'm not asking you to pick one to resend it to.
>
Yes. I usually route defconfig patches through a platform maintainer, but as
you said, this driver is used by different platforms so I decided to send it
to you directly since I didn't know which platform to choose.
Sorry if that caused inconveniences.
> Arnd
>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-04 23:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-16 15:08 [RESEND PATCH] ARM: multi_v7_defconfig: Build Atmel maXTouch driver as a module Javier Martinez Canillas
2016-09-02 15:38 ` Arnd Bergmann
2016-09-04 23:31 ` Javier Martinez Canillas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).