From: Dhananjay Phadke <dphadke@linux.microsoft.com>
To: Neal Liu <neal_liu@aspeedtech.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Corentin Labbe <clabbe.montjoie@gmail.com>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Randy Dunlap <rdunlap@infradead.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S . Miller" <davem@davemloft.net>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
Johnny Huang <johnny_huang@aspeedtech.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
BMC-SW <BMC-SW@aspeedtech.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v5 2/5] dt-bindings: clock: Add AST2500/AST2600 HACE reset definition
Date: Wed, 29 Jun 2022 04:39:00 -0700 [thread overview]
Message-ID: <74981148-70ab-059b-6e77-b88ea908e703@linux.microsoft.com> (raw)
In-Reply-To: <HK0PR06MB32021F63833C4C482CC616D580BB9@HK0PR06MB3202.apcprd06.prod.outlook.com>
On 6/29/2022 1:49 AM, Neal Liu wrote:
[...]
>>>>> diff --git a/include/dt-bindings/clock/aspeed-clock.h
>>>>> b/include/dt-bindings/clock/aspeed-clock.h
>>>>> index 9ff4f6e4558c..6e040f7c3426 100644
>>>>> --- a/include/dt-bindings/clock/aspeed-clock.h
>>>>> +++ b/include/dt-bindings/clock/aspeed-clock.h
>>>>> @@ -46,11 +46,12 @@
>>>>> #define ASPEED_RESET_MCTP 1
>>>>> #define ASPEED_RESET_ADC 2
>>>>> #define ASPEED_RESET_JTAG_MASTER 3
>>>>> -#define ASPEED_RESET_MIC 4
>>>>> +#define ASPEED_RESET_HACE 4
>>>>
>>>> I did not ack such change. This is a significant change from previous
>>>> version, invalidating my previous ack.
>>>>
>>>> This breaks the ABI, so NAK without proper explanation why ABI break
>>>> is accepted.
>>>
>>> I changed the original define (MIC) into different value (see below diff), and
>> add a new define for HACE.
>>> How does that break the ABI? I'll be appreciated if you can explain it more
>> details.
>>> And sorry for not remove ack with new change.
>>
>> Yes, this breaks ABI. Previously the ASPEED_RESET_MIC define had value of 4,
>> now it has value of something else.
>
> Got your point. I'll re-define HACE without modifying ABI.
> Thanks for your suggestion.
>
As per HW manuals, new def is correct for AST2500, but not for AST2400.
AST2500:
SCU04[4] = HACE
SCU04[18] = MIC
AST2400:
SCU04[4] = MIC
SCU04[18] = HACE
The header file is shared between AST2400 and AST2500 (aspeed-g4.dtsi
and aspeed-g5.dtsi), which needs to be split into separate header files
given the collision.
Also, It will be better to split AST2500 and AST2600 changes in separate
patches.
Regards,
Dhananjay
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-29 11:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 3:20 [PATCH v5 0/5] Add Aspeed crypto driver for hardware acceleration Neal Liu
2022-06-29 3:20 ` [PATCH v5 1/5] crypto: aspeed: Add HACE hash driver Neal Liu
2022-06-29 3:20 ` [PATCH v5 2/5] dt-bindings: clock: Add AST2500/AST2600 HACE reset definition Neal Liu
2022-06-29 5:57 ` Krzysztof Kozlowski
2022-06-29 7:59 ` Neal Liu
2022-06-29 8:03 ` Krzysztof Kozlowski
2022-06-29 8:49 ` Neal Liu
2022-06-29 11:39 ` Dhananjay Phadke [this message]
2022-06-29 3:20 ` [PATCH v5 3/5] ARM: dts: aspeed: Add HACE device controller node Neal Liu
2022-06-29 3:20 ` [PATCH v5 4/5] dt-bindings: crypto: add documentation for aspeed hace Neal Liu
2022-06-29 3:20 ` [PATCH v5 5/5] crypto: aspeed: add HACE crypto driver Neal Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74981148-70ab-059b-6e77-b88ea908e703@linux.microsoft.com \
--to=dphadke@linux.microsoft.com \
--cc=BMC-SW@aspeedtech.com \
--cc=andrew@aj.id.au \
--cc=christophe.jaillet@wanadoo.fr \
--cc=clabbe.montjoie@gmail.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=joel@jms.id.au \
--cc=johnny_huang@aspeedtech.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neal_liu@aspeedtech.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).