From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Neal Liu <neal_liu@aspeedtech.com>,
Corentin Labbe <clabbe.montjoie@gmail.com>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Randy Dunlap <rdunlap@infradead.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S . Miller" <davem@davemloft.net>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
Dhananjay Phadke <dhphadke@microsoft.com>,
Johnny Huang <johnny_huang@aspeedtech.com>
Cc: linux-aspeed@lists.ozlabs.org, linux-crypto@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, BMC-SW@aspeedtech.com
Subject: Re: [PATCH v5 2/5] dt-bindings: clock: Add AST2500/AST2600 HACE reset definition
Date: Wed, 29 Jun 2022 07:57:40 +0200 [thread overview]
Message-ID: <b70e06e7-81fc-dfc1-f9c5-f83cb4a18293@linaro.org> (raw)
In-Reply-To: <20220629032008.1579899-3-neal_liu@aspeedtech.com>
On 29/06/2022 05:20, Neal Liu wrote:
> Add HACE reset bit definition for AST2500/AST2600.
>
> Signed-off-by: Neal Liu <neal_liu@aspeedtech.com>
> Signed-off-by: Johnny Huang <johnny_huang@aspeedtech.com>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> include/dt-bindings/clock/aspeed-clock.h | 3 ++-
> include/dt-bindings/clock/ast2600-clock.h | 1 +
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/include/dt-bindings/clock/aspeed-clock.h b/include/dt-bindings/clock/aspeed-clock.h
> index 9ff4f6e4558c..6e040f7c3426 100644
> --- a/include/dt-bindings/clock/aspeed-clock.h
> +++ b/include/dt-bindings/clock/aspeed-clock.h
> @@ -46,11 +46,12 @@
> #define ASPEED_RESET_MCTP 1
> #define ASPEED_RESET_ADC 2
> #define ASPEED_RESET_JTAG_MASTER 3
> -#define ASPEED_RESET_MIC 4
> +#define ASPEED_RESET_HACE 4
I did not ack such change. This is a significant change from previous
version, invalidating my previous ack.
This breaks the ABI, so NAK without proper explanation why ABI break is
accepted.
> #define ASPEED_RESET_PWM 5
> #define ASPEED_RESET_PECI 6
> #define ASPEED_RESET_I2C 7
> #define ASPEED_RESET_AHB 8
> #define ASPEED_RESET_CRT1 9
> +#define ASPEED_RESET_MIC 18
>
> #endif
> diff --git a/include/dt-bindings/clock/ast2600-clock.h b/include/dt-bindings/clock/ast2600-clock.h
> index 62b9520a00fd..d8b0db2f7a7d 100644
> --- a/include/dt-bindings/clock/ast2600-clock.h
> +++ b/include/dt-bindings/clock/ast2600-clock.h
> @@ -111,6 +111,7 @@
> #define ASPEED_RESET_PCIE_RC_O 19
> #define ASPEED_RESET_PCIE_RC_OEN 18
> #define ASPEED_RESET_PCI_DP 5
> +#define ASPEED_RESET_HACE 4
> #define ASPEED_RESET_AHB 1
> #define ASPEED_RESET_SDRAM 0
>
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-29 5:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 3:20 [PATCH v5 0/5] Add Aspeed crypto driver for hardware acceleration Neal Liu
2022-06-29 3:20 ` [PATCH v5 1/5] crypto: aspeed: Add HACE hash driver Neal Liu
2022-06-29 3:20 ` [PATCH v5 2/5] dt-bindings: clock: Add AST2500/AST2600 HACE reset definition Neal Liu
2022-06-29 5:57 ` Krzysztof Kozlowski [this message]
2022-06-29 7:59 ` Neal Liu
2022-06-29 8:03 ` Krzysztof Kozlowski
2022-06-29 8:49 ` Neal Liu
2022-06-29 11:39 ` Dhananjay Phadke
2022-06-29 3:20 ` [PATCH v5 3/5] ARM: dts: aspeed: Add HACE device controller node Neal Liu
2022-06-29 3:20 ` [PATCH v5 4/5] dt-bindings: crypto: add documentation for aspeed hace Neal Liu
2022-06-29 3:20 ` [PATCH v5 5/5] crypto: aspeed: add HACE crypto driver Neal Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b70e06e7-81fc-dfc1-f9c5-f83cb4a18293@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=BMC-SW@aspeedtech.com \
--cc=andrew@aj.id.au \
--cc=christophe.jaillet@wanadoo.fr \
--cc=clabbe.montjoie@gmail.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dhphadke@microsoft.com \
--cc=herbert@gondor.apana.org.au \
--cc=joel@jms.id.au \
--cc=johnny_huang@aspeedtech.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neal_liu@aspeedtech.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).