From: Heiner Kallweit <hkallweit1@gmail.com>
To: "Jernej Škrabec" <jernej.skrabec@siol.net>,
robh+dt@kernel.org, andrew@lunn.ch, f.fainelli@gmail.com
Cc: devicetree@vger.kernel.org, netdev@vger.kernel.org,
linux@armlinux.org.uk, mripard@kernel.org,
linux-kernel@vger.kernel.org, wens@csie.org,
lee.jones@linaro.org, davem@davemloft.net,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH 2/4] net: phy: Add support for AC200 EPHY
Date: Fri, 17 Apr 2020 18:16:20 +0200 [thread overview]
Message-ID: <74ab97a9-adbc-6a50-d710-eb50017aa47b@gmail.com> (raw)
In-Reply-To: <6176364.4vTCxPXJkl@jernej-laptop>
On 17.04.2020 18:15, Jernej Škrabec wrote:
> Dne četrtek, 16. april 2020 ob 22:18:52 CEST je Heiner Kallweit napisal(a):
>> On 16.04.2020 20:57, Jernej Skrabec wrote:
>>> AC200 MFD IC supports Fast Ethernet PHY. Add a driver for it.
>>>
>>> Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
>>> ---
>>>
>>> drivers/net/phy/Kconfig | 7 ++
>>> drivers/net/phy/Makefile | 1 +
>>> drivers/net/phy/ac200.c | 206 +++++++++++++++++++++++++++++++++++++++
>>> 3 files changed, 214 insertions(+)
>>> create mode 100644 drivers/net/phy/ac200.c
>>>
>>> diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
>>> index 3fa33d27eeba..16af69f69eaf 100644
>>> --- a/drivers/net/phy/Kconfig
>>> +++ b/drivers/net/phy/Kconfig
>>> @@ -288,6 +288,13 @@ config ADIN_PHY
>>>
>>> - ADIN1300 - Robust,Industrial, Low Latency 10/100/1000 Gigabit
>>>
>>> Ethernet PHY
>>>
>>> +config AC200_PHY
>>> + tristate "AC200 EPHY"
>>> + depends on NVMEM
>>> + depends on OF
>>> + help
>>> + Fast ethernet PHY as found in X-Powers AC200 multi-function
> device.
>>> +
>>>
>>> config AMD_PHY
>>>
>>> tristate "AMD PHYs"
>>> ---help---
>>>
>>> diff --git a/drivers/net/phy/Makefile b/drivers/net/phy/Makefile
>>> index 2f5c7093a65b..b0c5b91900fa 100644
>>> --- a/drivers/net/phy/Makefile
>>> +++ b/drivers/net/phy/Makefile
>>> @@ -53,6 +53,7 @@ obj-$(CONFIG_SFP) += sfp.o
>>>
>>> sfp-obj-$(CONFIG_SFP) += sfp-bus.o
>>> obj-y += $(sfp-obj-y) $(sfp-obj-m)
>>>
>>> +obj-$(CONFIG_AC200_PHY) += ac200.o
>>>
>>> obj-$(CONFIG_ADIN_PHY) += adin.o
>>> obj-$(CONFIG_AMD_PHY) += amd.o
>>> aquantia-objs += aquantia_main.o
>>>
>>> diff --git a/drivers/net/phy/ac200.c b/drivers/net/phy/ac200.c
>>> new file mode 100644
>>> index 000000000000..3d7856ff8f91
>>> --- /dev/null
>>> +++ b/drivers/net/phy/ac200.c
>>> @@ -0,0 +1,206 @@
>>> +// SPDX-License-Identifier: GPL-2.0+
>>> +/**
>>> + * Driver for AC200 Ethernet PHY
>>> + *
>>> + * Copyright (c) 2020 Jernej Skrabec <jernej.skrabec@siol.net>
>>> + */
>>> +
>>> +#include <linux/kernel.h>
>>> +#include <linux/module.h>
>>> +#include <linux/mfd/ac200.h>
>>> +#include <linux/nvmem-consumer.h>
>>> +#include <linux/of.h>
>>> +#include <linux/phy.h>
>>> +#include <linux/platform_device.h>
>>> +
>>> +#define AC200_EPHY_ID 0x00441400
>>> +#define AC200_EPHY_ID_MASK 0x0ffffff0
>>> +
>>
>> You could use PHY_ID_MATCH_MODEL() here.
>
> Hm... This doesn't work with dynamically allocated memory, right?
>
Right ..
> Best regards,
> Jernej
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-04-17 16:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-16 18:57 [RFC PATCH 0/4] net: mfd: AC200 Ethernet PHY Jernej Skrabec
2020-04-16 18:57 ` [RFC PATCH 1/4] mfd: Add support for AC200 Jernej Skrabec
2020-04-24 8:05 ` Lee Jones
2020-04-16 18:57 ` [RFC PATCH 2/4] net: phy: Add support for AC200 EPHY Jernej Skrabec
2020-04-16 19:18 ` Florian Fainelli
2020-04-17 15:01 ` Jernej Škrabec
2020-04-16 20:18 ` Heiner Kallweit
2020-04-17 16:03 ` Jernej Škrabec
2020-04-17 16:29 ` Heiner Kallweit
2020-04-17 17:15 ` Jernej Škrabec
2020-04-17 16:15 ` Jernej Škrabec
2020-04-17 16:16 ` Heiner Kallweit [this message]
2020-04-17 17:01 ` Andrew Lunn
2020-04-16 18:57 ` [RFC PATCH 3/4] arm64: dts: allwinner: h6: Add AC200 EPHY related nodes Jernej Skrabec
2020-04-16 18:57 ` [RFC PATCH 4/4] arm64: dts: allwinner: h6: tanix-tx6: Enable ethernet Jernej Skrabec
2020-04-16 21:54 ` [RFC PATCH 0/4] net: mfd: AC200 Ethernet PHY Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74ab97a9-adbc-6a50-d710-eb50017aa47b@gmail.com \
--to=hkallweit1@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=jernej.skrabec@siol.net \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mripard@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).