* [PATCH] arm64: dts: mt8183: Add missing power-domain for pwm0 node
@ 2021-01-13 21:57 Enric Balletbo i Serra
2021-01-14 7:32 ` Hsin-Yi Wang
2021-01-28 17:09 ` Matthias Brugger
0 siblings, 2 replies; 3+ messages in thread
From: Enric Balletbo i Serra @ 2021-01-13 21:57 UTC (permalink / raw)
To: linux-kernel
Cc: devicetree, drinkcat, Rob Herring, linux-mediatek, hsinyi,
matthias.bgg, Collabora Kernel ML, linux-arm-kernel
The MT8183 display PWM device will not work until the associated
power-domain is enabled. Add the power-domain reference to the node
allows the display PWM driver to operate and the backlight turn on.
Fixes: f15722c0fef0 ("arm64: dts: mt8183: Add pwm and backlight node")
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
---
arch/arm64/boot/dts/mediatek/mt8183.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
index bda283fa9245..8471c973dfd5 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
@@ -661,6 +661,7 @@ pwm0: pwm@1100e000 {
compatible = "mediatek,mt8183-disp-pwm";
reg = <0 0x1100e000 0 0x1000>;
interrupts = <GIC_SPI 128 IRQ_TYPE_LEVEL_LOW>;
+ power-domains = <&spm MT8183_POWER_DOMAIN_DISP>;
#pwm-cells = <2>;
clocks = <&topckgen CLK_TOP_MUX_DISP_PWM>,
<&infracfg CLK_INFRA_DISP_PWM>;
--
2.29.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: mt8183: Add missing power-domain for pwm0 node
2021-01-13 21:57 [PATCH] arm64: dts: mt8183: Add missing power-domain for pwm0 node Enric Balletbo i Serra
@ 2021-01-14 7:32 ` Hsin-Yi Wang
2021-01-28 17:09 ` Matthias Brugger
1 sibling, 0 replies; 3+ messages in thread
From: Hsin-Yi Wang @ 2021-01-14 7:32 UTC (permalink / raw)
To: Enric Balletbo i Serra
Cc: Devicetree List, Nicolas Boichat, lkml, Rob Herring,
moderated list:ARM/Mediatek SoC support, Matthias Brugger,
Collabora Kernel ML,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
On Thu, Jan 14, 2021 at 5:57 AM Enric Balletbo i Serra
<enric.balletbo@collabora.com> wrote:
>
> The MT8183 display PWM device will not work until the associated
> power-domain is enabled. Add the power-domain reference to the node
> allows the display PWM driver to operate and the backlight turn on.
>
> Fixes: f15722c0fef0 ("arm64: dts: mt8183: Add pwm and backlight node")
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Reviewed-by: Hsin-Yi Wang <hsinyi@chromium.org>
> ---
>
> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> index bda283fa9245..8471c973dfd5 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> @@ -661,6 +661,7 @@ pwm0: pwm@1100e000 {
> compatible = "mediatek,mt8183-disp-pwm";
> reg = <0 0x1100e000 0 0x1000>;
> interrupts = <GIC_SPI 128 IRQ_TYPE_LEVEL_LOW>;
> + power-domains = <&spm MT8183_POWER_DOMAIN_DISP>;
> #pwm-cells = <2>;
> clocks = <&topckgen CLK_TOP_MUX_DISP_PWM>,
> <&infracfg CLK_INFRA_DISP_PWM>;
> --
> 2.29.2
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: mt8183: Add missing power-domain for pwm0 node
2021-01-13 21:57 [PATCH] arm64: dts: mt8183: Add missing power-domain for pwm0 node Enric Balletbo i Serra
2021-01-14 7:32 ` Hsin-Yi Wang
@ 2021-01-28 17:09 ` Matthias Brugger
1 sibling, 0 replies; 3+ messages in thread
From: Matthias Brugger @ 2021-01-28 17:09 UTC (permalink / raw)
To: Enric Balletbo i Serra, linux-kernel
Cc: devicetree, drinkcat, Rob Herring, linux-mediatek, hsinyi,
Collabora Kernel ML, linux-arm-kernel
On 13/01/2021 22:57, Enric Balletbo i Serra wrote:
> The MT8183 display PWM device will not work until the associated
> power-domain is enabled. Add the power-domain reference to the node
> allows the display PWM driver to operate and the backlight turn on.
>
> Fixes: f15722c0fef0 ("arm64: dts: mt8183: Add pwm and backlight node")
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
applied to v5.11-next/dts64
Thanks!
>
> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> index bda283fa9245..8471c973dfd5 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> @@ -661,6 +661,7 @@ pwm0: pwm@1100e000 {
> compatible = "mediatek,mt8183-disp-pwm";
> reg = <0 0x1100e000 0 0x1000>;
> interrupts = <GIC_SPI 128 IRQ_TYPE_LEVEL_LOW>;
> + power-domains = <&spm MT8183_POWER_DOMAIN_DISP>;
> #pwm-cells = <2>;
> clocks = <&topckgen CLK_TOP_MUX_DISP_PWM>,
> <&infracfg CLK_INFRA_DISP_PWM>;
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-28 17:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-13 21:57 [PATCH] arm64: dts: mt8183: Add missing power-domain for pwm0 node Enric Balletbo i Serra
2021-01-14 7:32 ` Hsin-Yi Wang
2021-01-28 17:09 ` Matthias Brugger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).