Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / Atom feed
From: Lukasz Luba <lukasz.luba@arm.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH] memory: samsung: exynos5422-dmc: Correct function names in kerneldoc
Date: Mon, 8 Feb 2021 09:22:59 +0000
Message-ID: <7bb5b6af-a075-3b84-2864-1c7d75c188f0@arm.com> (raw)
In-Reply-To: <20210206111715.20774-1-krzk@kernel.org>



On 2/6/21 11:17 AM, Krzysztof Kozlowski wrote:
> Correct kerneldoc to fix W=1 warnings:
> 
>      drivers/memory/samsung/exynos5422-dmc.c:290: warning:
>          expecting prototype for find_target_freq_id(). Prototype was for find_target_freq_idx() instead
>      drivers/memory/samsung/exynos5422-dmc.c:1015: warning:
>          expecting prototype for exynos5_dmc_align_initial_frequency(). Prototype was for exynos5_dmc_align_init_freq() instead
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

Thank you Krzysztof for looking at this.
LGTM

Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>

Regards,
Lukasz



> ---
>   drivers/memory/samsung/exynos5422-dmc.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/memory/samsung/exynos5422-dmc.c b/drivers/memory/samsung/exynos5422-dmc.c
> index c5ee4121a4d2..1dabb509dec3 100644
> --- a/drivers/memory/samsung/exynos5422-dmc.c
> +++ b/drivers/memory/samsung/exynos5422-dmc.c
> @@ -278,7 +278,7 @@ static int exynos5_counters_disable_edev(struct exynos5_dmc *dmc)
>   }
>   
>   /**
> - * find_target_freq_id() - Finds requested frequency in local DMC configuration
> + * find_target_freq_idx() - Finds requested frequency in local DMC configuration
>    * @dmc:	device for which the information is checked
>    * @target_rate:	requested frequency in KHz
>    *
> @@ -998,7 +998,7 @@ static struct devfreq_dev_profile exynos5_dmc_df_profile = {
>   };
>   
>   /**
> - * exynos5_dmc_align_initial_frequency() - Align initial frequency value
> + * exynos5_dmc_align_init_freq() - Align initial frequency value
>    * @dmc:	device for which the frequency is going to be set
>    * @bootloader_init_freq:	initial frequency set by the bootloader in KHz
>    *
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-06 11:17 Krzysztof Kozlowski
2021-02-08  9:22 ` Lukasz Luba [this message]
2021-02-08 17:16 ` (subset) " Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7bb5b6af-a075-3b84-2864-1c7d75c188f0@arm.com \
    --to=lukasz.luba@arm.com \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-ARM-Kernel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/0 linux-arm-kernel/git/0.git
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/1 linux-arm-kernel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-kernel linux-arm-kernel/ https://lore.kernel.org/linux-arm-kernel \
		linux-arm-kernel@lists.infradead.org
	public-inbox-index linux-arm-kernel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-arm-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git