* [PATCH] memory: samsung: exynos5422-dmc: Correct function names in kerneldoc
@ 2021-02-06 11:17 Krzysztof Kozlowski
2021-02-08 9:22 ` Lukasz Luba
2021-02-08 17:16 ` (subset) " Krzysztof Kozlowski
0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2021-02-06 11:17 UTC (permalink / raw)
To: Lukasz Luba, Krzysztof Kozlowski, linux-pm, linux-samsung-soc,
linux-kernel, linux-arm-kernel
Correct kerneldoc to fix W=1 warnings:
drivers/memory/samsung/exynos5422-dmc.c:290: warning:
expecting prototype for find_target_freq_id(). Prototype was for find_target_freq_idx() instead
drivers/memory/samsung/exynos5422-dmc.c:1015: warning:
expecting prototype for exynos5_dmc_align_initial_frequency(). Prototype was for exynos5_dmc_align_init_freq() instead
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/memory/samsung/exynos5422-dmc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/memory/samsung/exynos5422-dmc.c b/drivers/memory/samsung/exynos5422-dmc.c
index c5ee4121a4d2..1dabb509dec3 100644
--- a/drivers/memory/samsung/exynos5422-dmc.c
+++ b/drivers/memory/samsung/exynos5422-dmc.c
@@ -278,7 +278,7 @@ static int exynos5_counters_disable_edev(struct exynos5_dmc *dmc)
}
/**
- * find_target_freq_id() - Finds requested frequency in local DMC configuration
+ * find_target_freq_idx() - Finds requested frequency in local DMC configuration
* @dmc: device for which the information is checked
* @target_rate: requested frequency in KHz
*
@@ -998,7 +998,7 @@ static struct devfreq_dev_profile exynos5_dmc_df_profile = {
};
/**
- * exynos5_dmc_align_initial_frequency() - Align initial frequency value
+ * exynos5_dmc_align_init_freq() - Align initial frequency value
* @dmc: device for which the frequency is going to be set
* @bootloader_init_freq: initial frequency set by the bootloader in KHz
*
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] memory: samsung: exynos5422-dmc: Correct function names in kerneldoc
2021-02-06 11:17 [PATCH] memory: samsung: exynos5422-dmc: Correct function names in kerneldoc Krzysztof Kozlowski
@ 2021-02-08 9:22 ` Lukasz Luba
2021-02-08 17:16 ` (subset) " Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Lukasz Luba @ 2021-02-08 9:22 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: linux-samsung-soc, linux-kernel, linux-arm-kernel, linux-pm
On 2/6/21 11:17 AM, Krzysztof Kozlowski wrote:
> Correct kerneldoc to fix W=1 warnings:
>
> drivers/memory/samsung/exynos5422-dmc.c:290: warning:
> expecting prototype for find_target_freq_id(). Prototype was for find_target_freq_idx() instead
> drivers/memory/samsung/exynos5422-dmc.c:1015: warning:
> expecting prototype for exynos5_dmc_align_initial_frequency(). Prototype was for exynos5_dmc_align_init_freq() instead
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Thank you Krzysztof for looking at this.
LGTM
Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
Regards,
Lukasz
> ---
> drivers/memory/samsung/exynos5422-dmc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/memory/samsung/exynos5422-dmc.c b/drivers/memory/samsung/exynos5422-dmc.c
> index c5ee4121a4d2..1dabb509dec3 100644
> --- a/drivers/memory/samsung/exynos5422-dmc.c
> +++ b/drivers/memory/samsung/exynos5422-dmc.c
> @@ -278,7 +278,7 @@ static int exynos5_counters_disable_edev(struct exynos5_dmc *dmc)
> }
>
> /**
> - * find_target_freq_id() - Finds requested frequency in local DMC configuration
> + * find_target_freq_idx() - Finds requested frequency in local DMC configuration
> * @dmc: device for which the information is checked
> * @target_rate: requested frequency in KHz
> *
> @@ -998,7 +998,7 @@ static struct devfreq_dev_profile exynos5_dmc_df_profile = {
> };
>
> /**
> - * exynos5_dmc_align_initial_frequency() - Align initial frequency value
> + * exynos5_dmc_align_init_freq() - Align initial frequency value
> * @dmc: device for which the frequency is going to be set
> * @bootloader_init_freq: initial frequency set by the bootloader in KHz
> *
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: (subset) [PATCH] memory: samsung: exynos5422-dmc: Correct function names in kerneldoc
2021-02-06 11:17 [PATCH] memory: samsung: exynos5422-dmc: Correct function names in kerneldoc Krzysztof Kozlowski
2021-02-08 9:22 ` Lukasz Luba
@ 2021-02-08 17:16 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2021-02-08 17:16 UTC (permalink / raw)
To: linux-kernel, linux-pm, Krzysztof Kozlowski, linux-samsung-soc,
Lukasz Luba, linux-arm-kernel
On Sat, 6 Feb 2021 12:17:15 +0100, Krzysztof Kozlowski wrote:
> Correct kerneldoc to fix W=1 warnings:
>
> drivers/memory/samsung/exynos5422-dmc.c:290: warning:
> expecting prototype for find_target_freq_id(). Prototype was for find_target_freq_idx() instead
> drivers/memory/samsung/exynos5422-dmc.c:1015: warning:
> expecting prototype for exynos5_dmc_align_initial_frequency(). Prototype was for exynos5_dmc_align_init_freq() instead
Applied, thanks!
[1/1] memory: samsung: exynos5422-dmc: Correct function names in kerneldoc
commit: 0e9bc42089a7374d056745419c7a8f28016b4191
Best regards,
--
Krzysztof Kozlowski <krzk@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-08 17:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-06 11:17 [PATCH] memory: samsung: exynos5422-dmc: Correct function names in kerneldoc Krzysztof Kozlowski
2021-02-08 9:22 ` Lukasz Luba
2021-02-08 17:16 ` (subset) " Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).