From: Neil Armstrong <narmstrong@baylibre.com>
To: Andrzej Pietrasiewicz <andrzej.p@collabora.com>,
dri-devel@lists.freedesktop.org
Cc: "David Airlie" <airlied@linux.ie>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Shawn Guo" <shawnguo@kernel.org>,
kernel@collabora.com, "Anthony Koo" <Anthony.Koo@amd.com>,
linux-samsung-soc@vger.kernel.org,
"Tomi Valkeinen" <tomi.valkeinen@ti.com>,
"David Francis" <David.Francis@amd.com>,
"Mamta Shukla" <mamtashukla555@gmail.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
linux-rockchip@lists.infradead.org,
"Kukjin Kim" <kgene@kernel.org>,
"Allison Randal" <allison@lohutok.net>,
"Leo Li" <sunpeng.li@amd.com>,
linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org,
"Jyri Sarha" <jsarha@ti.com>,
linux-mediatek@lists.infradead.org,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
linux-tegra@vger.kernel.org,
"Thomas Gleixner" <tglx@linutronix.de>,
"Bhawanpreet Lakha" <Bhawanpreet.Lakha@amd.com>,
linux-arm-kernel@lists.infradead.org,
"Sean Paul" <sean@poorly.run>,
amd-gfx@lists.freedesktop.org,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Seung-Woo Kim" <sw0312.kim@samsung.com>,
linux-kernel@vger.kernel.org,
"Christian König" <christian.koenig@amd.com>,
"Todor Tomov" <todor.tomov@linaro.org>,
"Kyungmin Park" <kyungmin.park@samsung.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
freedreno@lists.freedesktop.org,
"Nicholas Kazlauskas" <nicholas.kazlauskas@amd.com>
Subject: Re: [PATCH 02/13] drm/radeon: Eliminate possible use of an uninitialized variable
Date: Thu, 1 Aug 2019 14:15:15 +0200 [thread overview]
Message-ID: <7cacac43-737e-1ddb-2951-394fcf9ad0b2@baylibre.com> (raw)
In-Reply-To: <cfff357a07bfa572baad058947f281b7095e1794.1564591626.git.andrzej.p@collabora.com>
Hi Andrzej,
I had to revert the previous patch, so you should re-spin it entirely :
================================
After merging the drm-misc tree, today's linux-next build (x86_64
allmodconfig) failed like this:
drivers/gpu/drm/radeon/radeon_connectors.c: In function 'radeon_add_legacy_connector':
drivers/gpu/drm/radeon/radeon_connectors.c:2433:5: error: 'ddc' undeclared (first use in this function)
ddc = &radeon_connector->ddc_bus->adapter;
^~~
drivers/gpu/drm/radeon/radeon_connectors.c:2433:5: note: each undeclared identifier is reported only once for each function it appears in
Caused by commit
bed7a2182de6 ("drm/radeon: Provide ddc symlink in connector sysfs directory")
I have used the drm-misc tree from next-20190731 for today.
==================================
Neil
On 31/07/2019 18:58, Andrzej Pietrasiewicz wrote:
> ddc local variable is passed to drm_connector_init_with_ddc() and should
> be NULL if no ddc is available.
>
> Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
> ---
> drivers/gpu/drm/radeon/radeon_connectors.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c b/drivers/gpu/drm/radeon/radeon_connectors.c
> index b3ad8d890801..d11131d03ed6 100644
> --- a/drivers/gpu/drm/radeon/radeon_connectors.c
> +++ b/drivers/gpu/drm/radeon/radeon_connectors.c
> @@ -1870,7 +1870,7 @@ radeon_add_atom_connector(struct drm_device *dev,
> struct radeon_connector_atom_dig *radeon_dig_connector;
> struct drm_encoder *encoder;
> struct radeon_encoder *radeon_encoder;
> - struct i2c_adapter *ddc;
> + struct i2c_adapter *ddc = NULL;
> uint32_t subpixel_order = SubPixelNone;
> bool shared_ddc = false;
> bool is_dp_bridge = false;
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-08-01 12:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1564161140.git.andrzej.p@collabora.com>
[not found] ` <7fee0fa0d0f77af6595d283d5f3ae5d551475821.1564161140.git.andrzej.p@collabora.com>
[not found] ` <CADnq5_O1B59Q+68fJgtf_bn_=WQ9yrVPq-V5tL1VQ3+vzgf1Zw@mail.gmail.com>
2019-07-26 19:42 ` [PATCH v6 22/24] drm/amdgpu: Provide ddc symlink in connector sysfs directory Andrzej Pietrasiewicz
2019-07-26 20:00 ` Alex Deucher
[not found] ` <20190726183520.GA22572@ravnborg.org>
[not found] ` <20190726185538.GD14981@ravnborg.org>
2019-07-31 8:00 ` Review required [Was: Associate ddc adapters with connectors] Neil Armstrong
2019-07-31 10:40 ` Sam Ravnborg
2019-07-31 13:10 ` Andrzej Pietrasiewicz
2019-07-31 14:22 ` Neil Armstrong
2019-07-31 15:32 ` Neil Armstrong
[not found] ` <cover.1564591626.git.andrzej.p@collabora.com>
[not found] ` <cfff357a07bfa572baad058947f281b7095e1794.1564591626.git.andrzej.p@collabora.com>
2019-08-01 12:15 ` Neil Armstrong [this message]
[not found] ` <52272b8ebf403361ff96e04bf14f5a7389116f73.1564591626.git.andrzej.p@collabora.com>
2019-08-06 8:36 ` [PATCH 05/13] drm: rockchip: Provide ddc symlink in inno_hdmi sysfs directory Heiko Stuebner
[not found] ` <e3058e1973c9c7649a0818450188b5c3db442b3e.1564591626.git.andrzej.p@collabora.com>
2019-08-06 8:36 ` [PATCH 04/13] drm: rockchip: Provide ddc symlink in rk3066_hdmi " Heiko Stuebner
[not found] ` <ebb75e71b8b7c8d65d54a947a03fd21b8969fb3a.1564161140.git.andrzej.p@collabora.com>
2019-08-08 3:42 ` [PATCH v6 19/24] drm/bridge: dumb-vga-dac: Provide ddc symlink in connector " Guenter Roeck
2019-08-13 9:33 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7cacac43-737e-1ddb-2951-394fcf9ad0b2@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=Anthony.Koo@amd.com \
--cc=Bhawanpreet.Lakha@amd.com \
--cc=David.Francis@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=allison@lohutok.net \
--cc=amd-gfx@lists.freedesktop.org \
--cc=andrzej.p@collabora.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jonathanh@nvidia.com \
--cc=jsarha@ti.com \
--cc=kernel@collabora.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mamtashukla555@gmail.com \
--cc=matthias.bgg@gmail.com \
--cc=nicholas.kazlauskas@amd.com \
--cc=rodrigo.vivi@intel.com \
--cc=sean@poorly.run \
--cc=shawnguo@kernel.org \
--cc=sunpeng.li@amd.com \
--cc=sw0312.kim@samsung.com \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
--cc=todor.tomov@linaro.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).