Re: [PATCH v6 22/24] drm/amdgpu: Provide ddc symlink in connector sysfs directory

From: Alex Deucher <alexdeucher@gmail.com>
To: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
Cc: "Neil Armstrong" <narmstrong@baylibre.com>,
	"David Airlie" <airlied@linux.ie>,
	"Maling list - DRI developers" <dri-devel@lists.freedesktop.org>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-tegra@vger.kernel.org,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
	kernel@collabora.com, "Sam Ravnborg" <sam@ravnborg.org>,
	linux-samsung-soc@vger.kernel.org, "Sean Paul" <sean@poorly.run>,
	"Allison Randal" <allison@lohutok.net>,
	"Krzysztof Kozlowski" <krzk@kernel.org>,
	"Jonathan Hunter" <jonathanh@nvidia.com>,
	linux-rockchip@lists.infradead.org,
	"Chen-Yu Tsai" <wens@csie.org>, "Kukjin Kim" <kgene@kernel.org>,
	"NXP Linux Team" <linux-imx@nxp.com>,
	"Dave Airlie" <airlied@redhat.com>,
	"Wentland, Harry" <Harry.Wentland@amd.com>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"Jonas Karlman" <jonas@kwiboo.se>,
	linux-arm-msm <linux-arm-msm@vger.kernel.org>,
	"Intel Graphics Development" <intel-gfx@lists.freedesktop.org>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Mamta Shukla" <mamtashukla555@gmail.com>,
	linux-mediatek@lists.infradead.org, "Jyri Sarha" <jsarha@ti.com>,
	"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Vincent Abriou" <vincent.abriou@st.com>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	"Jernej Skrabec" <jernej.skrabec@siol.net>,
	"amd-gfx list" <amd-gfx@lists.freedesktop.org>,
	"Tomi Valkeinen" <tomi.valkeinen@ti.com>,
	freedreno <freedreno@lists.freedesktop.org>,
	"Seung-Woo Kim" <sw0312.kim@samsung.com>,
	"Douglas Anderson" <dianders@chromium.org>,
	"Kazlauskas, Nicholas" <nicholas.kazlauskas@amd.com>,
	"Todor Tomov" <todor.tomov@linaro.org>,
	"Kyungmin Park" <kyungmin.park@samsung.com>,
	"Huang Rui" <ray.huang@amd.com>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"Christian König" <christian.koenig@amd.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>
Subject: Re: [PATCH v6 22/24] drm/amdgpu: Provide ddc symlink in connector sysfs directory
Date: Fri, 26 Jul 2019 16:00:59 -0400	[thread overview]
Message-ID: <CADnq5_PJj8_dtq0aJWECcRJ0_uC-XpG6Z6p9Gj3fV_fTLGwZBA@mail.gmail.com> (raw)
In-Reply-To: <038809c7-e664-e365-a778-03bc11299193@collabora.com>

On Fri, Jul 26, 2019 at 3:42 PM Andrzej Pietrasiewicz
<andrzej.p@collabora.com> wrote:
>
> Hi Alex,
>
>
> W dniu 26.07.2019 o 21:28, Alex Deucher pisze:
> > On Fri, Jul 26, 2019 at 1:28 PM Andrzej Pietrasiewicz
> > <andrzej.p@collabora.com> wrote:
> >>
> >> Use the ddc pointer provided by the generic connector.
> >>
> >> Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
> >
> > Note that this only covers the legacy display code.  The new DC
> > display code also needs to be converted.  See:
> > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
>
> In amdgpu_dm_connector_init() the ddc is &i2c->base, is it?

Yes.

>
> But it is not clear to me how can I find ddc pointer in
> dm_dp_add_mst_connector()?

+ Harry and Nick.

hmmm, not sure about MST.  Maybe just skip them for now.

Alex

>
> Andrzej
>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel