* [PATCH] ARM: dts: ux500: Fix up the CPU thermal zone
@ 2019-10-01 7:46 Linus Walleij
2019-10-01 9:00 ` Daniel Lezcano
0 siblings, 1 reply; 2+ messages in thread
From: Linus Walleij @ 2019-10-01 7:46 UTC (permalink / raw)
To: arm, soc; +Cc: Linus Walleij, Daniel Lezcano, linux-arm-kernel
This fixes up the default ux500 CPU thermal zone:
- Set polling delay to 0 and explain why
- Set passive polling delay to 250
- Remove restrictions from the CPU cooling device,
we should use all cpufreq steps to cool down if
needed.
Fixes: b786a05f6ce4 ("ARM: dts: ux500: Update thermal zone")
Suggested-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
ARM SoC folks: please apply this directly for fixes.
It addresses some review comments I missed in the patches
that went in to the merge window.
---
arch/arm/boot/dts/ste-dbx5x0.dtsi | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/ste-dbx5x0.dtsi b/arch/arm/boot/dts/ste-dbx5x0.dtsi
index a53657b83288..bda454d12150 100644
--- a/arch/arm/boot/dts/ste-dbx5x0.dtsi
+++ b/arch/arm/boot/dts/ste-dbx5x0.dtsi
@@ -8,6 +8,7 @@
#include <dt-bindings/mfd/dbx500-prcmu.h>
#include <dt-bindings/arm/ux500_pm_domains.h>
#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/thermal/thermal.h>
/ {
#address-cells = <1>;
@@ -59,8 +60,12 @@
* cooling.
*/
cpu_thermal: cpu-thermal {
- polling-delay-passive = <0>;
- polling-delay = <1000>;
+ polling-delay-passive = <250>;
+ /*
+ * This sensor fires interrupts to update the thermal
+ * zone, so no polling is needed.
+ */
+ polling-delay = <0>;
thermal-sensors = <&thermal>;
@@ -79,7 +84,7 @@
cooling-maps {
trip = <&cpu_alert>;
- cooling-device = <&CPU0 0 2>;
+ cooling-device = <&CPU0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
contribution = <100>;
};
};
--
2.21.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ARM: dts: ux500: Fix up the CPU thermal zone
2019-10-01 7:46 [PATCH] ARM: dts: ux500: Fix up the CPU thermal zone Linus Walleij
@ 2019-10-01 9:00 ` Daniel Lezcano
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Lezcano @ 2019-10-01 9:00 UTC (permalink / raw)
To: Linus Walleij, arm, soc; +Cc: linux-arm-kernel
On 01/10/2019 09:46, Linus Walleij wrote:
> This fixes up the default ux500 CPU thermal zone:
>
> - Set polling delay to 0 and explain why
> - Set passive polling delay to 250
> - Remove restrictions from the CPU cooling device,
> we should use all cpufreq steps to cool down if
> needed.
>
> Fixes: b786a05f6ce4 ("ARM: dts: ux500: Update thermal zone")
> Suggested-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
> ARM SoC folks: please apply this directly for fixes.
> It addresses some review comments I missed in the patches
> that went in to the merge window.
> ---
> arch/arm/boot/dts/ste-dbx5x0.dtsi | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/ste-dbx5x0.dtsi b/arch/arm/boot/dts/ste-dbx5x0.dtsi
> index a53657b83288..bda454d12150 100644
> --- a/arch/arm/boot/dts/ste-dbx5x0.dtsi
> +++ b/arch/arm/boot/dts/ste-dbx5x0.dtsi
> @@ -8,6 +8,7 @@
> #include <dt-bindings/mfd/dbx500-prcmu.h>
> #include <dt-bindings/arm/ux500_pm_domains.h>
> #include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/thermal/thermal.h>
>
> / {
> #address-cells = <1>;
> @@ -59,8 +60,12 @@
> * cooling.
> */
> cpu_thermal: cpu-thermal {
> - polling-delay-passive = <0>;
> - polling-delay = <1000>;
> + polling-delay-passive = <250>;
> + /*
> + * This sensor fires interrupts to update the thermal
> + * zone, so no polling is needed.
> + */
> + polling-delay = <0>;
>
> thermal-sensors = <&thermal>;
>
> @@ -79,7 +84,7 @@
>
> cooling-maps {
> trip = <&cpu_alert>;
> - cooling-device = <&CPU0 0 2>;
> + cooling-device = <&CPU0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> contribution = <100>;
> };
> };
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-01 9:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-01 7:46 [PATCH] ARM: dts: ux500: Fix up the CPU thermal zone Linus Walleij
2019-10-01 9:00 ` Daniel Lezcano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).