* [PATCH v4] dt-bindings: gpu: add bindings for the ARM Mali Bifrost GPU
@ 2019-04-01 8:09 Neil Armstrong
2019-04-01 10:00 ` Steven Price
0 siblings, 1 reply; 6+ messages in thread
From: Neil Armstrong @ 2019-04-01 8:09 UTC (permalink / raw)
To: daniel, robh
Cc: devicetree, Neil Armstrong, linux-kernel, dri-devel,
linux-amlogic, linux-arm-kernel
Add the bindings for the Bifrost family of ARM Mali GPUs.
The Bifrost GPU architecture is similar to the Midgard family,
but with a different Shader Core & Execution Engine structures.
Bindings are based on the Midgard family bindings, but the inner
architectural changes makes it a separate family needing separate
bindings.
The Bifrost GPUs are present in a number of recent SoCs, like the
Amlogic G12A Family, and many other vendors.
The Amlogic vendor specific compatible is added to handle the
specific IP integration differences and dependencies.
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
.../bindings/gpu/arm,mali-bifrost.txt | 92 +++++++++++++++++++
1 file changed, 92 insertions(+)
create mode 100644 Documentation/devicetree/bindings/gpu/arm,mali-bifrost.txt
Changes since v3:
- Added note about discoverable model/revision
- Enforced fixed defined irq order
- Fixed typo in accommodate
Changes since v2:
- moved to a single compatible since HW is fully discoverable
diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.txt b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.txt
new file mode 100644
index 000000000000..711c9ead17a2
--- /dev/null
+++ b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.txt
@@ -0,0 +1,92 @@
+ARM Mali Bifrost GPU
+====================
+
+Required properties:
+
+- compatible :
+ * Since Mali Bifrost GPU model/revision if fully discoverable by reading
+ some determined registers, must contain the following:
+ + "arm,mali-bifrost"
+ * which must be preceded by one of the following vendor specifics:
+ + "amlogic,meson-g12a-mali"
+
+- reg : Physical base address of the device and length of the register area.
+
+- interrupts : Contains the three IRQ lines required by Mali Bifrost devices,
+ in the following defined order.
+
+- interrupt-names : Contains the names of IRQ resources in this exact defined
+ order: "job", "mmu", "gpu".
+
+Optional properties:
+
+- clocks : Phandle to clock for the Mali Bifrost device.
+
+- mali-supply : Phandle to regulator for the Mali device. Refer to
+ Documentation/devicetree/bindings/regulator/regulator.txt for details.
+
+- operating-points-v2 : Refer to Documentation/devicetree/bindings/opp/opp.txt
+ for details.
+
+- resets : Phandle of the GPU reset line.
+
+Vendor-specific bindings
+------------------------
+
+The Mali GPU is integrated very differently from one SoC to
+another. In order to accommodate those differences, you have the option
+to specify one more vendor-specific compatible, among:
+
+- "amlogic,meson-g12a-mali"
+ Required properties:
+ - resets : Should contain phandles of :
+ + GPU reset line
+ + GPU APB glue reset line
+
+Example for a Mali-G31:
+
+gpu@ffa30000 {
+ compatible = "amlogic,meson-g12a-mali", "arm,mali-bifrost";
+ reg = <0xffe40000 0x10000>;
+ interrupts = <GIC_SPI 160 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 161 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 162 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "job", "mmu", "gpu";
+ clocks = <&clk CLKID_MALI>;
+ mali-supply = <&vdd_gpu>;
+ operating-points-v2 = <&gpu_opp_table>;
+ resets = <&reset RESET_DVALIN_CAPB3>, <&reset RESET_DVALIN>;
+};
+
+gpu_opp_table: opp_table0 {
+ compatible = "operating-points-v2";
+
+ opp@533000000 {
+ opp-hz = /bits/ 64 <533000000>;
+ opp-microvolt = <1250000>;
+ };
+ opp@450000000 {
+ opp-hz = /bits/ 64 <450000000>;
+ opp-microvolt = <1150000>;
+ };
+ opp@400000000 {
+ opp-hz = /bits/ 64 <400000000>;
+ opp-microvolt = <1125000>;
+ };
+ opp@350000000 {
+ opp-hz = /bits/ 64 <350000000>;
+ opp-microvolt = <1075000>;
+ };
+ opp@266000000 {
+ opp-hz = /bits/ 64 <266000000>;
+ opp-microvolt = <1025000>;
+ };
+ opp@160000000 {
+ opp-hz = /bits/ 64 <160000000>;
+ opp-microvolt = <925000>;
+ };
+ opp@100000000 {
+ opp-hz = /bits/ 64 <100000000>;
+ opp-microvolt = <912500>;
+ };
+};
--
2.21.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v4] dt-bindings: gpu: add bindings for the ARM Mali Bifrost GPU
2019-04-01 8:09 [PATCH v4] dt-bindings: gpu: add bindings for the ARM Mali Bifrost GPU Neil Armstrong
@ 2019-04-01 10:00 ` Steven Price
2019-04-01 11:24 ` Neil Armstrong
0 siblings, 1 reply; 6+ messages in thread
From: Steven Price @ 2019-04-01 10:00 UTC (permalink / raw)
To: Neil Armstrong, daniel, robh
Cc: linux-arm-kernel, devicetree, linux-kernel, dri-devel, linux-amlogic
On 01/04/2019 09:09, Neil Armstrong wrote:
> Add the bindings for the Bifrost family of ARM Mali GPUs.
>
> The Bifrost GPU architecture is similar to the Midgard family,
> but with a different Shader Core & Execution Engine structures.
>
> Bindings are based on the Midgard family bindings, but the inner
> architectural changes makes it a separate family needing separate
> bindings.
>
> The Bifrost GPUs are present in a number of recent SoCs, like the
> Amlogic G12A Family, and many other vendors.
> The Amlogic vendor specific compatible is added to handle the
> specific IP integration differences and dependencies.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
> .../bindings/gpu/arm,mali-bifrost.txt | 92 +++++++++++++++++++
> 1 file changed, 92 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/gpu/arm,mali-bifrost.txt
>
> Changes since v3:
> - Added note about discoverable model/revision
> - Enforced fixed defined irq order
> - Fixed typo in accommodate
>
> Changes since v2:
> - moved to a single compatible since HW is fully discoverable
>
> diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.txt b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.txt
> new file mode 100644
> index 000000000000..711c9ead17a2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.txt
> @@ -0,0 +1,92 @@
> +ARM Mali Bifrost GPU
> +====================
> +
> +Required properties:
> +
> +- compatible :
> + * Since Mali Bifrost GPU model/revision if fully discoverable by reading
^^
s/if/is/
> + some determined registers, must contain the following:
> + + "arm,mali-bifrost"
> + * which must be preceded by one of the following vendor specifics:
> + + "amlogic,meson-g12a-mali"
> +
> +- reg : Physical base address of the device and length of the register area.
> +
> +- interrupts : Contains the three IRQ lines required by Mali Bifrost devices,
> + in the following defined order.
> +
> +- interrupt-names : Contains the names of IRQ resources in this exact defined
> + order: "job", "mmu", "gpu".
Is there any point in having "interrupt-names" if we're fixing the
order? Although I guess it helps match the Midgard bindings.
Steve
> +
> +Optional properties:
> +
> +- clocks : Phandle to clock for the Mali Bifrost device.
> +
> +- mali-supply : Phandle to regulator for the Mali device. Refer to
> + Documentation/devicetree/bindings/regulator/regulator.txt for details.
> +
> +- operating-points-v2 : Refer to Documentation/devicetree/bindings/opp/opp.txt
> + for details.
> +
> +- resets : Phandle of the GPU reset line.
> +
> +Vendor-specific bindings
> +------------------------
> +
> +The Mali GPU is integrated very differently from one SoC to
> +another. In order to accommodate those differences, you have the option
> +to specify one more vendor-specific compatible, among:
> +
> +- "amlogic,meson-g12a-mali"
> + Required properties:
> + - resets : Should contain phandles of :
> + + GPU reset line
> + + GPU APB glue reset line
> +
> +Example for a Mali-G31:
> +
> +gpu@ffa30000 {
> + compatible = "amlogic,meson-g12a-mali", "arm,mali-bifrost";
> + reg = <0xffe40000 0x10000>;
> + interrupts = <GIC_SPI 160 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 161 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 162 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "job", "mmu", "gpu";
> + clocks = <&clk CLKID_MALI>;
> + mali-supply = <&vdd_gpu>;
> + operating-points-v2 = <&gpu_opp_table>;
> + resets = <&reset RESET_DVALIN_CAPB3>, <&reset RESET_DVALIN>;
> +};
> +
> +gpu_opp_table: opp_table0 {
> + compatible = "operating-points-v2";
> +
> + opp@533000000 {
> + opp-hz = /bits/ 64 <533000000>;
> + opp-microvolt = <1250000>;
> + };
> + opp@450000000 {
> + opp-hz = /bits/ 64 <450000000>;
> + opp-microvolt = <1150000>;
> + };
> + opp@400000000 {
> + opp-hz = /bits/ 64 <400000000>;
> + opp-microvolt = <1125000>;
> + };
> + opp@350000000 {
> + opp-hz = /bits/ 64 <350000000>;
> + opp-microvolt = <1075000>;
> + };
> + opp@266000000 {
> + opp-hz = /bits/ 64 <266000000>;
> + opp-microvolt = <1025000>;
> + };
> + opp@160000000 {
> + opp-hz = /bits/ 64 <160000000>;
> + opp-microvolt = <925000>;
> + };
> + opp@100000000 {
> + opp-hz = /bits/ 64 <100000000>;
> + opp-microvolt = <912500>;
> + };
> +};
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v4] dt-bindings: gpu: add bindings for the ARM Mali Bifrost GPU
2019-04-01 10:00 ` Steven Price
@ 2019-04-01 11:24 ` Neil Armstrong
2019-04-07 10:16 ` Neil Armstrong
0 siblings, 1 reply; 6+ messages in thread
From: Neil Armstrong @ 2019-04-01 11:24 UTC (permalink / raw)
To: Steven Price, daniel, robh
Cc: linux-arm-kernel, devicetree, linux-kernel, dri-devel, linux-amlogic
On 01/04/2019 12:00, Steven Price wrote:
> On 01/04/2019 09:09, Neil Armstrong wrote:
>> Add the bindings for the Bifrost family of ARM Mali GPUs.
>>
>> The Bifrost GPU architecture is similar to the Midgard family,
>> but with a different Shader Core & Execution Engine structures.
>>
>> Bindings are based on the Midgard family bindings, but the inner
>> architectural changes makes it a separate family needing separate
>> bindings.
>>
>> The Bifrost GPUs are present in a number of recent SoCs, like the
>> Amlogic G12A Family, and many other vendors.
>> The Amlogic vendor specific compatible is added to handle the
>> specific IP integration differences and dependencies.
>>
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>> ---
>> .../bindings/gpu/arm,mali-bifrost.txt | 92 +++++++++++++++++++
>> 1 file changed, 92 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/gpu/arm,mali-bifrost.txt
>>
>> Changes since v3:
>> - Added note about discoverable model/revision
>> - Enforced fixed defined irq order
>> - Fixed typo in accommodate
>>
>> Changes since v2:
>> - moved to a single compatible since HW is fully discoverable
>>
>> diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.txt b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.txt
>> new file mode 100644
>> index 000000000000..711c9ead17a2
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.txt
>> @@ -0,0 +1,92 @@
>> +ARM Mali Bifrost GPU
>> +====================
>> +
>> +Required properties:
>> +
>> +- compatible :
>> + * Since Mali Bifrost GPU model/revision if fully discoverable by reading
> ^^
> s/if/is/
Thanks for pointing this.
>
>> + some determined registers, must contain the following:
>> + + "arm,mali-bifrost"
>> + * which must be preceded by one of the following vendor specifics:
>> + + "amlogic,meson-g12a-mali"
>> +
>> +- reg : Physical base address of the device and length of the register area.
>> +
>> +- interrupts : Contains the three IRQ lines required by Mali Bifrost devices,
>> + in the following defined order.
>> +
>> +- interrupt-names : Contains the names of IRQ resources in this exact defined
>> + order: "job", "mmu", "gpu".
>
> Is there any point in having "interrupt-names" if we're fixing the
> order? Although I guess it helps match the Midgard bindings.
Exact.
Neil
>
> Steve
>
>> +
>> +Optional properties:
>> +
>> +- clocks : Phandle to clock for the Mali Bifrost device.
>> +
>> +- mali-supply : Phandle to regulator for the Mali device. Refer to
>> + Documentation/devicetree/bindings/regulator/regulator.txt for details.
>> +
>> +- operating-points-v2 : Refer to Documentation/devicetree/bindings/opp/opp.txt
>> + for details.
>> +
>> +- resets : Phandle of the GPU reset line.
>> +
>> +Vendor-specific bindings
>> +------------------------
>> +
>> +The Mali GPU is integrated very differently from one SoC to
>> +another. In order to accommodate those differences, you have the option
>> +to specify one more vendor-specific compatible, among:
>> +
>> +- "amlogic,meson-g12a-mali"
>> + Required properties:
>> + - resets : Should contain phandles of :
>> + + GPU reset line
>> + + GPU APB glue reset line
>> +
>> +Example for a Mali-G31:
>> +
>> +gpu@ffa30000 {
>> + compatible = "amlogic,meson-g12a-mali", "arm,mali-bifrost";
>> + reg = <0xffe40000 0x10000>;
>> + interrupts = <GIC_SPI 160 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 161 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 162 IRQ_TYPE_LEVEL_HIGH>;
>> + interrupt-names = "job", "mmu", "gpu";
>> + clocks = <&clk CLKID_MALI>;
>> + mali-supply = <&vdd_gpu>;
>> + operating-points-v2 = <&gpu_opp_table>;
>> + resets = <&reset RESET_DVALIN_CAPB3>, <&reset RESET_DVALIN>;
>> +};
>> +
>> +gpu_opp_table: opp_table0 {
>> + compatible = "operating-points-v2";
>> +
>> + opp@533000000 {
>> + opp-hz = /bits/ 64 <533000000>;
>> + opp-microvolt = <1250000>;
>> + };
>> + opp@450000000 {
>> + opp-hz = /bits/ 64 <450000000>;
>> + opp-microvolt = <1150000>;
>> + };
>> + opp@400000000 {
>> + opp-hz = /bits/ 64 <400000000>;
>> + opp-microvolt = <1125000>;
>> + };
>> + opp@350000000 {
>> + opp-hz = /bits/ 64 <350000000>;
>> + opp-microvolt = <1075000>;
>> + };
>> + opp@266000000 {
>> + opp-hz = /bits/ 64 <266000000>;
>> + opp-microvolt = <1025000>;
>> + };
>> + opp@160000000 {
>> + opp-hz = /bits/ 64 <160000000>;
>> + opp-microvolt = <925000>;
>> + };
>> + opp@100000000 {
>> + opp-hz = /bits/ 64 <100000000>;
>> + opp-microvolt = <912500>;
>> + };
>> +};
>>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v4] dt-bindings: gpu: add bindings for the ARM Mali Bifrost GPU
2019-04-01 11:24 ` Neil Armstrong
@ 2019-04-07 10:16 ` Neil Armstrong
2019-04-08 19:07 ` Rob Herring
0 siblings, 1 reply; 6+ messages in thread
From: Neil Armstrong @ 2019-04-07 10:16 UTC (permalink / raw)
To: robh
Cc: devicetree, linux-kernel, dri-devel, Steven Price, daniel,
linux-amlogic, linux-arm-kernel
Hi Rob,
Le 01/04/2019 13:24, Neil Armstrong a écrit :
> On 01/04/2019 12:00, Steven Price wrote:
>> On 01/04/2019 09:09, Neil Armstrong wrote:
>>> Add the bindings for the Bifrost family of ARM Mali GPUs.
>>>
>>> The Bifrost GPU architecture is similar to the Midgard family,
>>> but with a different Shader Core & Execution Engine structures.
>>>
>>> Bindings are based on the Midgard family bindings, but the inner
>>> architectural changes makes it a separate family needing separate
>>> bindings.
>>>
>>> The Bifrost GPUs are present in a number of recent SoCs, like the
>>> Amlogic G12A Family, and many other vendors.
>>> The Amlogic vendor specific compatible is added to handle the
>>> specific IP integration differences and dependencies.
>>>
>>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>>> ---
>>> .../bindings/gpu/arm,mali-bifrost.txt | 92 +++++++++++++++++++
>>> 1 file changed, 92 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/gpu/arm,mali-bifrost.txt
>>>
>>> Changes since v3:
>>> - Added note about discoverable model/revision
>>> - Enforced fixed defined irq order
>>> - Fixed typo in accommodate
>>>
>>> Changes since v2:
>>> - moved to a single compatible since HW is fully discoverable
>>>
>>> diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.txt b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.txt
>>> new file mode 100644
>>> index 000000000000..711c9ead17a2
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.txt
>>> @@ -0,0 +1,92 @@
>>> +ARM Mali Bifrost GPU
>>> +====================
>>> +
>>> +Required properties:
>>> +
>>> +- compatible :
>>> + * Since Mali Bifrost GPU model/revision if fully discoverable by reading
>> ^^
>> s/if/is/
Should I still send a v5 to fixing this typo ? I can fix it while applying it.
Neil
>
> Thanks for pointing this.
>
>>
>>> + some determined registers, must contain the following:
>>> + + "arm,mali-bifrost"
>>> + * which must be preceded by one of the following vendor specifics:
>>> + + "amlogic,meson-g12a-mali"
>>> +
>>> +- reg : Physical base address of the device and length of the register area.
>>> +
>>> +- interrupts : Contains the three IRQ lines required by Mali Bifrost devices,
>>> + in the following defined order.
>>> +
>>> +- interrupt-names : Contains the names of IRQ resources in this exact defined
>>> + order: "job", "mmu", "gpu".
>>
>> Is there any point in having "interrupt-names" if we're fixing the
>> order? Although I guess it helps match the Midgard bindings.
>
> Exact.
>
> Neil
>
>>
>> Steve
>>
>>> +
>>> +Optional properties:
>>> +
>>> +- clocks : Phandle to clock for the Mali Bifrost device.
>>> +
>>> +- mali-supply : Phandle to regulator for the Mali device. Refer to
>>> + Documentation/devicetree/bindings/regulator/regulator.txt for details.
>>> +
>>> +- operating-points-v2 : Refer to Documentation/devicetree/bindings/opp/opp.txt
>>> + for details.
>>> +
>>> +- resets : Phandle of the GPU reset line.
>>> +
>>> +Vendor-specific bindings
>>> +------------------------
>>> +
>>> +The Mali GPU is integrated very differently from one SoC to
>>> +another. In order to accommodate those differences, you have the option
>>> +to specify one more vendor-specific compatible, among:
>>> +
>>> +- "amlogic,meson-g12a-mali"
>>> + Required properties:
>>> + - resets : Should contain phandles of :
>>> + + GPU reset line
>>> + + GPU APB glue reset line
>>> +
>>> +Example for a Mali-G31:
>>> +
>>> +gpu@ffa30000 {
>>> + compatible = "amlogic,meson-g12a-mali", "arm,mali-bifrost";
>>> + reg = <0xffe40000 0x10000>;
>>> + interrupts = <GIC_SPI 160 IRQ_TYPE_LEVEL_HIGH>,
>>> + <GIC_SPI 161 IRQ_TYPE_LEVEL_HIGH>,
>>> + <GIC_SPI 162 IRQ_TYPE_LEVEL_HIGH>;
>>> + interrupt-names = "job", "mmu", "gpu";
>>> + clocks = <&clk CLKID_MALI>;
>>> + mali-supply = <&vdd_gpu>;
>>> + operating-points-v2 = <&gpu_opp_table>;
>>> + resets = <&reset RESET_DVALIN_CAPB3>, <&reset RESET_DVALIN>;
>>> +};
>>> +
>>> +gpu_opp_table: opp_table0 {
>>> + compatible = "operating-points-v2";
>>> +
>>> + opp@533000000 {
>>> + opp-hz = /bits/ 64 <533000000>;
>>> + opp-microvolt = <1250000>;
>>> + };
>>> + opp@450000000 {
>>> + opp-hz = /bits/ 64 <450000000>;
>>> + opp-microvolt = <1150000>;
>>> + };
>>> + opp@400000000 {
>>> + opp-hz = /bits/ 64 <400000000>;
>>> + opp-microvolt = <1125000>;
>>> + };
>>> + opp@350000000 {
>>> + opp-hz = /bits/ 64 <350000000>;
>>> + opp-microvolt = <1075000>;
>>> + };
>>> + opp@266000000 {
>>> + opp-hz = /bits/ 64 <266000000>;
>>> + opp-microvolt = <1025000>;
>>> + };
>>> + opp@160000000 {
>>> + opp-hz = /bits/ 64 <160000000>;
>>> + opp-microvolt = <925000>;
>>> + };
>>> + opp@100000000 {
>>> + opp-hz = /bits/ 64 <100000000>;
>>> + opp-microvolt = <912500>;
>>> + };
>>> +};
>>>
>>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v4] dt-bindings: gpu: add bindings for the ARM Mali Bifrost GPU
2019-04-07 10:16 ` Neil Armstrong
@ 2019-04-08 19:07 ` Rob Herring
2019-04-09 8:20 ` Neil Armstrong
0 siblings, 1 reply; 6+ messages in thread
From: Rob Herring @ 2019-04-08 19:07 UTC (permalink / raw)
To: Neil Armstrong
Cc: devicetree, linux-kernel, dri-devel, Steven Price, Daniel Vetter,
linux-amlogic,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
On Sun, Apr 7, 2019 at 5:17 AM Neil Armstrong <narmstrong@baylibre.com> wrote:
>
> Hi Rob,
>
> Le 01/04/2019 13:24, Neil Armstrong a écrit :
> > On 01/04/2019 12:00, Steven Price wrote:
> >> On 01/04/2019 09:09, Neil Armstrong wrote:
> >>> Add the bindings for the Bifrost family of ARM Mali GPUs.
> >>>
> >>> The Bifrost GPU architecture is similar to the Midgard family,
> >>> but with a different Shader Core & Execution Engine structures.
> >>>
> >>> Bindings are based on the Midgard family bindings, but the inner
> >>> architectural changes makes it a separate family needing separate
> >>> bindings.
> >>>
> >>> The Bifrost GPUs are present in a number of recent SoCs, like the
> >>> Amlogic G12A Family, and many other vendors.
> >>> The Amlogic vendor specific compatible is added to handle the
> >>> specific IP integration differences and dependencies.
> >>>
> >>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> >>> ---
> >>> .../bindings/gpu/arm,mali-bifrost.txt | 92 +++++++++++++++++++
> >>> 1 file changed, 92 insertions(+)
> >>> create mode 100644 Documentation/devicetree/bindings/gpu/arm,mali-bifrost.txt
> >>>
> >>> Changes since v3:
> >>> - Added note about discoverable model/revision
> >>> - Enforced fixed defined irq order
> >>> - Fixed typo in accommodate
> >>>
> >>> Changes since v2:
> >>> - moved to a single compatible since HW is fully discoverable
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.txt b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.txt
> >>> new file mode 100644
> >>> index 000000000000..711c9ead17a2
> >>> --- /dev/null
> >>> +++ b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.txt
> >>> @@ -0,0 +1,92 @@
> >>> +ARM Mali Bifrost GPU
> >>> +====================
> >>> +
> >>> +Required properties:
> >>> +
> >>> +- compatible :
> >>> + * Since Mali Bifrost GPU model/revision if fully discoverable by reading
> >> ^^
> >> s/if/is/
>
> Should I still send a v5 to fixing this typo ? I can fix it while applying it.
No need to resend. I planned to apply it, but if you are going to:
Reviewed-by: Rob Herring <robh@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v4] dt-bindings: gpu: add bindings for the ARM Mali Bifrost GPU
2019-04-08 19:07 ` Rob Herring
@ 2019-04-09 8:20 ` Neil Armstrong
0 siblings, 0 replies; 6+ messages in thread
From: Neil Armstrong @ 2019-04-09 8:20 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, linux-kernel, dri-devel, Steven Price, Daniel Vetter,
linux-amlogic,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
On 08/04/2019 21:07, Rob Herring wrote:
> On Sun, Apr 7, 2019 at 5:17 AM Neil Armstrong <narmstrong@baylibre.com> wrote:
>>
>> Hi Rob,
>>
>> Le 01/04/2019 13:24, Neil Armstrong a écrit :
>>> On 01/04/2019 12:00, Steven Price wrote:
>>>> On 01/04/2019 09:09, Neil Armstrong wrote:
>>>>> Add the bindings for the Bifrost family of ARM Mali GPUs.
>>>>>
>>>>> The Bifrost GPU architecture is similar to the Midgard family,
>>>>> but with a different Shader Core & Execution Engine structures.
>>>>>
>>>>> Bindings are based on the Midgard family bindings, but the inner
>>>>> architectural changes makes it a separate family needing separate
>>>>> bindings.
>>>>>
>>>>> The Bifrost GPUs are present in a number of recent SoCs, like the
>>>>> Amlogic G12A Family, and many other vendors.
>>>>> The Amlogic vendor specific compatible is added to handle the
>>>>> specific IP integration differences and dependencies.
>>>>>
>>>>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>>>>> ---
>>>>> .../bindings/gpu/arm,mali-bifrost.txt | 92 +++++++++++++++++++
>>>>> 1 file changed, 92 insertions(+)
>>>>> create mode 100644 Documentation/devicetree/bindings/gpu/arm,mali-bifrost.txt
>>>>>
>>>>> Changes since v3:
>>>>> - Added note about discoverable model/revision
>>>>> - Enforced fixed defined irq order
>>>>> - Fixed typo in accommodate
>>>>>
>>>>> Changes since v2:
>>>>> - moved to a single compatible since HW is fully discoverable
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.txt b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.txt
>>>>> new file mode 100644
>>>>> index 000000000000..711c9ead17a2
>>>>> --- /dev/null
>>>>> +++ b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.txt
>>>>> @@ -0,0 +1,92 @@
>>>>> +ARM Mali Bifrost GPU
>>>>> +====================
>>>>> +
>>>>> +Required properties:
>>>>> +
>>>>> +- compatible :
>>>>> + * Since Mali Bifrost GPU model/revision if fully discoverable by reading
>>>> ^^
>>>> s/if/is/
>>
>> Should I still send a v5 to fixing this typo ? I can fix it while applying it.
>
> No need to resend. I planned to apply it, but if you are going to:
>
> Reviewed-by: Rob Herring <robh@kernel.org>
>
Thanks,
Fixed and applied on drm-misc-next
Neil
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-04-09 8:20 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-01 8:09 [PATCH v4] dt-bindings: gpu: add bindings for the ARM Mali Bifrost GPU Neil Armstrong
2019-04-01 10:00 ` Steven Price
2019-04-01 11:24 ` Neil Armstrong
2019-04-07 10:16 ` Neil Armstrong
2019-04-08 19:07 ` Rob Herring
2019-04-09 8:20 ` Neil Armstrong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).