From: Adrian Ratiu <adrian.ratiu@collabora.com>
To: Ezequiel Garcia <ezequiel@collabora.com>
Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Martyn Welch <martyn.welch@collabora.com>,
Sjoerd Simons <sjoerd.simons@collabora.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
DRI mailing list <dri-devel@lists.freedesktop.org>,
Andrzej Hajda <a.hajda@samsung.com>,
NXP Linux Team <linux-imx@nxp.com>,
linux-rockchip@lists.infradead.org, kernel@collabora.com,
Fabio Estevam <festevam@gmail.com>,
linux-stm32@st-md-mailman.stormreply.com,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
Emil Velikov <emil.velikov@collabora.com>
Subject: Re: [PATCH v5 4/5] drm: imx: Add i.MX 6 MIPI DSI host platform driver
Date: Tue, 31 Mar 2020 00:31:56 +0300 [thread overview]
Message-ID: <877dz134xf.fsf@collabora.com> (raw)
In-Reply-To: <4a9d2d6e5cecbe296c14119d27a8793a7dbed7b2.camel@collabora.com>
On Mon, 30 Mar 2020, Ezequiel Garcia <ezequiel@collabora.com>
wrote:
> Hello Fabio, Adrian:
>
> On Mon, 2020-03-30 at 08:49 -0300, Fabio Estevam wrote:
>> Hi Adrian, On Mon, Mar 30, 2020 at 8:34 AM Adrian Ratiu
>> <adrian.ratiu@collabora.com> wrote:
>> > This adds support for the Synopsis DesignWare MIPI DSI v1.01
>> > host controller which is embedded in i.MX 6 SoCs. Based on
>> > following patches, but updated/extended to work with existing
>> > support found in the kernel: - drm: imx: Support Synopsys
>> > DesignWare MIPI DSI host controller
>> > Signed-off-by: Liu Ying <Ying.Liu@freescale.com>
>> > - ARM: dtsi: imx6qdl: Add support for MIPI DSI host
>> > controller
>> > Signed-off-by: Liu Ying <Ying.Liu@freescale.com>
>> This one looks like a devicetree patch, but this patch does
>> not touch devicetree.
>> > + ret = clk_prepare_enable(dsi->pllref_clk); + if
>> > (ret) { + dev_err(dev, "%s: Failed to enable
>> > pllref_clk\n", __func__); + return ret; +
>> > } + + dsi->mux_sel =
>> > syscon_regmap_lookup_by_phandle(dev->of_node, "fsl,gpr"); +
>> > if (IS_ERR(dsi->mux_sel)) { + ret =
>> > PTR_ERR(dsi->mux_sel); + dev_err(dev, "%s:
>> > Failed to get GPR regmap: %d\n", +
>> > __func__, ret); + return ret;
>> You should disable the dsi->pllref_clk clock prior to
>> returning the error.
>
> Another approach could be moving the clock on and off to to
> component_ops.{bind,unbind} (as rockhip driver does).
>
> What exactly is the PLL clock needed for? Would it make sense to
> move it some of the PHY power on/off? (Maybe not, but it's
> worthing checking).
>
> Also, it seems the other IP blocks have this PLL clock, so maybe
> it could be moved to the dw_mipi_dsi core? This could be
> something for a follow-up, to avoid creeping this series.
Hi Ezequiel,
pll is the video reference clock which drives the data lanes and
yes all drivers have it as it's a basic requirement, so moving it
to the common bridge is indeed a good idea, however this kind of
driver refactoring is out of scope for this specific patch series,
because, for now, I'd like to get the regmap and the imx6 driver
in, once that is done we can think how to further abstract away
common logic and slim down the existing drivers further.
Basically I just want to avoid feature creep as I expect v6 to be
~ 8 patches big and the series is already over 1200 lines.
Thank you,
Adrian
>
> Thanks,
> Ezequiel
>
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-03-30 21:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200330113455eucas1p1441dc79d44de5081e9d90079e2020ca0@eucas1p1.samsung.com>
2020-03-30 11:35 ` [PATCH v5 0/5] Genericize DW MIPI DSI bridge and add i.MX 6 driver Adrian Ratiu
2020-03-30 11:35 ` [PATCH v5 1/5] drm: bridge: dw_mipi_dsi: add initial regmap infrastructure Adrian Ratiu
2020-03-30 15:58 ` adrian61
2020-03-30 16:13 ` adrian61
2020-03-30 21:16 ` Adrian Ratiu
2020-03-30 11:35 ` [PATCH v5 2/5] drm: bridge: dw_mipi_dsi: abstract register access using reg_fields Adrian Ratiu
2020-04-06 15:39 ` Andrzej Hajda
2020-04-10 10:22 ` Adrian Ratiu
2020-03-30 11:35 ` [PATCH v5 3/5] drm: bridge: synopsis: add dsi v1.01 support Adrian Ratiu
2020-03-30 16:08 ` adrian61
2020-03-30 21:18 ` Adrian Ratiu
2020-03-30 11:35 ` [PATCH v5 4/5] drm: imx: Add i.MX 6 MIPI DSI host platform driver Adrian Ratiu
2020-03-30 11:49 ` Fabio Estevam
2020-03-30 13:51 ` Ezequiel Garcia
2020-03-30 21:31 ` Adrian Ratiu [this message]
2020-03-31 4:05 ` Ezequiel Garcia
2020-03-31 7:19 ` Adrian Ratiu
2020-03-30 21:20 ` Adrian Ratiu
2020-03-30 11:35 ` [PATCH v5 5/5] dt-bindings: display: add i.MX6 MIPI DSI host controller doc Adrian Ratiu
2020-03-30 11:52 ` Fabio Estevam
2020-03-30 15:44 ` Rob Herring
2020-04-06 14:23 ` [PATCH v5 0/5] Genericize DW MIPI DSI bridge and add i.MX 6 driver Andrzej Hajda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dz134xf.fsf@collabora.com \
--to=adrian.ratiu@collabora.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.velikov@collabora.com \
--cc=ezequiel@collabora.com \
--cc=festevam@gmail.com \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=martyn.welch@collabora.com \
--cc=sjoerd.simons@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).