* [PATCH] arm64: dts: renesas: salvator: add dummy 2nd port to rcar_sound
@ 2019-02-25 9:36 Simon Horman
2019-02-25 9:49 ` Geert Uytterhoeven
2019-02-26 0:28 ` Kuninori Morimoto
0 siblings, 2 replies; 6+ messages in thread
From: Simon Horman @ 2019-02-25 9:36 UTC (permalink / raw)
To: linux-renesas-soc
Cc: Simon Horman, Magnus Damm, Kuninori Morimoto, linux-arm-kernel
Add dummy 2nd port node to rcar_sound ports node to satisfy dtc
recommendation that #address-cells / #size-cells is only needed.
This addresses the following warning:
arch/arm64/boot/dts/renesas/salvator-common.dtsi:703.8-719.4: Warning (graph_child_address): /soc/sound@ec500000/ports: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary
arch/arm64/boot/dts/renesas/salvator-common.dtsi:703.8-719.4: Warning (graph_child_address): /soc/sound@ec500000/ports: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary
This change should not have any run-time effect.
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
Build tested against renesas-devel-20190214-v5.0-rc6
---
arch/arm64/boot/dts/renesas/salvator-common.dtsi | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
index a225c2457274..20b35991bc17 100644
--- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
+++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
@@ -716,6 +716,15 @@
capture = <&ssi1 &src1 &dvc1>;
};
};
+
+ /* Dummy node to be overriden by board DT
+ * Satisfies dtc recommendation that
+ * #address-cells / #size-cells is only needed
+ * for graph nodes with multiple child nodes.
+ */
+ rsnd_port1: port@1 {
+ reg = <1>;
+ };
};
};
--
2.11.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: renesas: salvator: add dummy 2nd port to rcar_sound
2019-02-25 9:36 [PATCH] arm64: dts: renesas: salvator: add dummy 2nd port to rcar_sound Simon Horman
@ 2019-02-25 9:49 ` Geert Uytterhoeven
2019-02-25 9:51 ` Geert Uytterhoeven
2019-02-26 0:28 ` Kuninori Morimoto
1 sibling, 1 reply; 6+ messages in thread
From: Geert Uytterhoeven @ 2019-02-25 9:49 UTC (permalink / raw)
To: Simon Horman, rob+dt, Mark Rutland
Cc: Linux-Renesas,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Magnus Damm, Kuninori Morimoto, Linux ARM
CC DT
On Mon, Feb 25, 2019 at 10:37 AM Simon Horman
<horms+renesas@verge.net.au> wrote:
> Add dummy 2nd port node to rcar_sound ports node to satisfy dtc
> recommendation that #address-cells / #size-cells is only needed.
>
> This addresses the following warning:
>
> arch/arm64/boot/dts/renesas/salvator-common.dtsi:703.8-719.4: Warning (graph_child_address): /soc/sound@ec500000/ports: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary
> arch/arm64/boot/dts/renesas/salvator-common.dtsi:703.8-719.4: Warning (graph_child_address): /soc/sound@ec500000/ports: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary
>
> This change should not have any run-time effect.
>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
>
> ---
> Build tested against renesas-devel-20190214-v5.0-rc6
> ---
> arch/arm64/boot/dts/renesas/salvator-common.dtsi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> index a225c2457274..20b35991bc17 100644
> --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> @@ -716,6 +716,15 @@
> capture = <&ssi1 &src1 &dvc1>;
> };
> };
> +
> + /* Dummy node to be overriden by board DT
> + * Satisfies dtc recommendation that
> + * #address-cells / #size-cells is only needed
> + * for graph nodes with multiple child nodes.
> + */
> + rsnd_port1: port@1 {
> + reg = <1>;
> + };
> };
> };
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: renesas: salvator: add dummy 2nd port to rcar_sound
2019-02-25 9:49 ` Geert Uytterhoeven
@ 2019-02-25 9:51 ` Geert Uytterhoeven
0 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2019-02-25 9:51 UTC (permalink / raw)
To: Simon Horman, Mark Rutland, Rob Herring
Cc: Linux-Renesas,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Magnus Damm, Kuninori Morimoto, Linux ARM
Woops, this time using the Real Rob.
On Mon, Feb 25, 2019 at 10:49 AM Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> CC DT
>
> On Mon, Feb 25, 2019 at 10:37 AM Simon Horman
> <horms+renesas@verge.net.au> wrote:
> > Add dummy 2nd port node to rcar_sound ports node to satisfy dtc
> > recommendation that #address-cells / #size-cells is only needed.
> >
> > This addresses the following warning:
> >
> > arch/arm64/boot/dts/renesas/salvator-common.dtsi:703.8-719.4: Warning (graph_child_address): /soc/sound@ec500000/ports: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary
> > arch/arm64/boot/dts/renesas/salvator-common.dtsi:703.8-719.4: Warning (graph_child_address): /soc/sound@ec500000/ports: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary
> >
> > This change should not have any run-time effect.
> >
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> >
> > ---
> > Build tested against renesas-devel-20190214-v5.0-rc6
> > ---
> > arch/arm64/boot/dts/renesas/salvator-common.dtsi | 9 +++++++++
> > 1 file changed, 9 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> > index a225c2457274..20b35991bc17 100644
> > --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> > @@ -716,6 +716,15 @@
> > capture = <&ssi1 &src1 &dvc1>;
> > };
> > };
> > +
> > + /* Dummy node to be overriden by board DT
> > + * Satisfies dtc recommendation that
> > + * #address-cells / #size-cells is only needed
> > + * for graph nodes with multiple child nodes.
> > + */
> > + rsnd_port1: port@1 {
> > + reg = <1>;
> > + };
> > };
> > };
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: renesas: salvator: add dummy 2nd port to rcar_sound
2019-02-25 9:36 [PATCH] arm64: dts: renesas: salvator: add dummy 2nd port to rcar_sound Simon Horman
2019-02-25 9:49 ` Geert Uytterhoeven
@ 2019-02-26 0:28 ` Kuninori Morimoto
2019-02-26 10:08 ` Simon Horman
1 sibling, 1 reply; 6+ messages in thread
From: Kuninori Morimoto @ 2019-02-26 0:28 UTC (permalink / raw)
To: Simon Horman; +Cc: linux-renesas-soc, Magnus Damm, linux-arm-kernel
Hi Simon
Thank you for your patch
> Add dummy 2nd port node to rcar_sound ports node to satisfy dtc
> recommendation that #address-cells / #size-cells is only needed.
>
> This addresses the following warning:
>
> arch/arm64/boot/dts/renesas/salvator-common.dtsi:703.8-719.4: Warning (graph_child_address): /soc/sound@ec500000/ports: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary
> arch/arm64/boot/dts/renesas/salvator-common.dtsi:703.8-719.4: Warning (graph_child_address): /soc/sound@ec500000/ports: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary
>
> This change should not have any run-time effect.
>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
>
> ---
> Build tested against renesas-devel-20190214-v5.0-rc6
> ---
> arch/arm64/boot/dts/renesas/salvator-common.dtsi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> index a225c2457274..20b35991bc17 100644
> --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> @@ -716,6 +716,15 @@
> capture = <&ssi1 &src1 &dvc1>;
> };
> };
> +
> + /* Dummy node to be overriden by board DT
> + * Satisfies dtc recommendation that
> + * #address-cells / #size-cells is only needed
> + * for graph nodes with multiple child nodes.
> + */
> + rsnd_port1: port@1 {
> + reg = <1>;
> + };
> };
> };
This solution is strange for me.
I want to solve it, but I couldn't reproduce this.
Which branch, and how to reproduce it ?
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: renesas: salvator: add dummy 2nd port to rcar_sound
2019-02-26 0:28 ` Kuninori Morimoto
@ 2019-02-26 10:08 ` Simon Horman
2019-02-27 5:00 ` Kuninori Morimoto
0 siblings, 1 reply; 6+ messages in thread
From: Simon Horman @ 2019-02-26 10:08 UTC (permalink / raw)
To: Kuninori Morimoto; +Cc: linux-renesas-soc, Magnus Damm, linux-arm-kernel
On Tue, Feb 26, 2019 at 09:28:53AM +0900, Kuninori Morimoto wrote:
>
> Hi Simon
>
> Thank you for your patch
>
> > Add dummy 2nd port node to rcar_sound ports node to satisfy dtc
> > recommendation that #address-cells / #size-cells is only needed.
> >
> > This addresses the following warning:
> >
> > arch/arm64/boot/dts/renesas/salvator-common.dtsi:703.8-719.4: Warning (graph_child_address): /soc/sound@ec500000/ports: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary
> > arch/arm64/boot/dts/renesas/salvator-common.dtsi:703.8-719.4: Warning (graph_child_address): /soc/sound@ec500000/ports: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary
> >
> > This change should not have any run-time effect.
> >
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> >
> > ---
> > Build tested against renesas-devel-20190214-v5.0-rc6
> > ---
> > arch/arm64/boot/dts/renesas/salvator-common.dtsi | 9 +++++++++
> > 1 file changed, 9 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> > index a225c2457274..20b35991bc17 100644
> > --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> > @@ -716,6 +716,15 @@
> > capture = <&ssi1 &src1 &dvc1>;
> > };
> > };
> > +
> > + /* Dummy node to be overriden by board DT
> > + * Satisfies dtc recommendation that
> > + * #address-cells / #size-cells is only needed
> > + * for graph nodes with multiple child nodes.
> > + */
> > + rsnd_port1: port@1 {
> > + reg = <1>;
> > + };
> > };
> > };
>
> This solution is strange for me.
> I want to solve it, but I couldn't reproduce this.
> Which branch, and how to reproduce it ?
Thanks Morimoto-san,
I see this on renesas-devel-20190225-v5.0-rc8 using:
ARCH=arm64 make dtbs W=1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: renesas: salvator: add dummy 2nd port to rcar_sound
2019-02-26 10:08 ` Simon Horman
@ 2019-02-27 5:00 ` Kuninori Morimoto
0 siblings, 0 replies; 6+ messages in thread
From: Kuninori Morimoto @ 2019-02-27 5:00 UTC (permalink / raw)
To: Simon Horman; +Cc: linux-renesas-soc, Magnus Damm, linux-arm-kernel
Hi Simon
> > This solution is strange for me.
> > I want to solve it, but I couldn't reproduce this.
> > Which branch, and how to reproduce it ?
>
> Thanks Morimoto-san,
>
> I see this on renesas-devel-20190225-v5.0-rc8 using:
>
> ARCH=arm64 make dtbs W=1
Thanks !!
I think we can avoid this WARNING if we added HDMI sound support at 77965.
I will post such patches.
I didn't/can't test it, but basically no problem.
# DT is not-flexible, picky, difficult...
# to be honest, I don't like DT...
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-02-27 5:01 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-25 9:36 [PATCH] arm64: dts: renesas: salvator: add dummy 2nd port to rcar_sound Simon Horman
2019-02-25 9:49 ` Geert Uytterhoeven
2019-02-25 9:51 ` Geert Uytterhoeven
2019-02-26 0:28 ` Kuninori Morimoto
2019-02-26 10:08 ` Simon Horman
2019-02-27 5:00 ` Kuninori Morimoto
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).