From: Florian Weimer <fweimer@redhat.com>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: linux-s390@vger.kernel.org, Michal Simek <monstr@monstr.eu>,
linux-ia64@vger.kernel.org, linux-parisc@vger.kernel.org,
linux-sh@vger.kernel.org, linux-api@vger.kernel.org,
linux-xtensa@linux-xtensa.org,
lkml <linux-kernel@vger.kernel.org>,
linux-mips@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-m68k@lists.linux-m68k.org,
Andreas Schwab <schwab@linux-m68k.org>,
linux-alpha@vger.kernel.org, sparclinux@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] [RFC] Remove bdflush syscall stub
Date: Tue, 28 May 2019 13:03:20 +0200 [thread overview]
Message-ID: <87ftoyg7t3.fsf@oldenburg2.str.redhat.com> (raw)
In-Reply-To: <20190528104017.GA11969@rei> (Cyril Hrubis's message of "Tue, 28 May 2019 12:40:18 +0200")
* Cyril Hrubis:
> Hi!
>> > I've tested the patch on i386. Before the patch calling bdflush() with
>> > attempt to tune a variable returned 0 and after the patch the syscall
>> > fails with EINVAL.
>>
>> Should be ENOSYS, doesn't it?
>
> My bad, the LTP syscall wrapper handles ENOSYS and produces skipped
> results based on that.
>
> EINVAL is what you get for not yet implemented syscalls, i.e. new
> syscall on old kernel.
EINVAL? Is that a bdflush-specific thing, test-specific, or is itmore
general?
glibc has fallback paths that test for ENOSYS only. EINVAL will be
passed to the application, skipping fallback. For missing system calls,
this is not what we want.
Thanks,
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-05-28 11:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190528101012.11402-1-chrubis@suse.cz>
2019-05-28 10:25 ` [PATCH] [RFC] Remove bdflush syscall stub Andreas Schwab
[not found] ` <20190528104017.GA11969@rei>
2019-05-28 11:03 ` Florian Weimer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftoyg7t3.fsf@oldenburg2.str.redhat.com \
--to=fweimer@redhat.com \
--cc=chrubis@suse.cz \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=monstr@monstr.eu \
--cc=schwab@linux-m68k.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).