* Re: [PATCH] [RFC] Remove bdflush syscall stub
[not found] <20190528101012.11402-1-chrubis@suse.cz>
@ 2019-05-28 10:25 ` Andreas Schwab
[not found] ` <20190528104017.GA11969@rei>
0 siblings, 1 reply; 2+ messages in thread
From: Andreas Schwab @ 2019-05-28 10:25 UTC (permalink / raw)
To: Cyril Hrubis
Cc: linux-s390, Michal Simek, linux-ia64, linux-parisc, linux-sh,
linux-api, linux-xtensa, lkml, linux-mips, linux-fsdevel,
linux-m68k, linux-alpha, sparclinux, linuxppc-dev,
linux-arm-kernel
On Mai 28 2019, Cyril Hrubis <chrubis@suse.cz> wrote:
> I've tested the patch on i386. Before the patch calling bdflush() with
> attempt to tune a variable returned 0 and after the patch the syscall
> fails with EINVAL.
Should be ENOSYS, doesn't it?
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] [RFC] Remove bdflush syscall stub
[not found] ` <20190528104017.GA11969@rei>
@ 2019-05-28 11:03 ` Florian Weimer
0 siblings, 0 replies; 2+ messages in thread
From: Florian Weimer @ 2019-05-28 11:03 UTC (permalink / raw)
To: Cyril Hrubis
Cc: linux-s390, Michal Simek, linux-ia64, linux-parisc, linux-sh,
linux-api, linux-xtensa, lkml, linux-mips, linux-fsdevel,
linux-m68k, Andreas Schwab, linux-alpha, sparclinux,
linuxppc-dev, linux-arm-kernel
* Cyril Hrubis:
> Hi!
>> > I've tested the patch on i386. Before the patch calling bdflush() with
>> > attempt to tune a variable returned 0 and after the patch the syscall
>> > fails with EINVAL.
>>
>> Should be ENOSYS, doesn't it?
>
> My bad, the LTP syscall wrapper handles ENOSYS and produces skipped
> results based on that.
>
> EINVAL is what you get for not yet implemented syscalls, i.e. new
> syscall on old kernel.
EINVAL? Is that a bdflush-specific thing, test-specific, or is itmore
general?
glibc has fallback paths that test for ENOSYS only. EINVAL will be
passed to the application, skipping fallback. For missing system calls,
this is not what we want.
Thanks,
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-05-28 11:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20190528101012.11402-1-chrubis@suse.cz>
2019-05-28 10:25 ` [PATCH] [RFC] Remove bdflush syscall stub Andreas Schwab
[not found] ` <20190528104017.GA11969@rei>
2019-05-28 11:03 ` Florian Weimer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).