From: bpringlemeir@nbsps.com (Bill Pringlemeir)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 3/8] ARM: dts: Enables SAI ALSA SoC DAI device for Vybrid VF610 TOWER board.
Date: Wed, 20 Nov 2013 11:04:02 -0500 [thread overview]
Message-ID: <87hab7hxfx.fsf@nbsps.com> (raw)
In-Reply-To: <1DD289F6464F0949A2FCA5AA6DC23F828AD451@039-SN2MPN1-012.039d.mgd.msft.net> (Li Xiubo's message of "Wed, 20 Nov 2013 03:14:09 +0000")
[sorry, I should have copied alsa-devel at alsa-project.org previously].
On 19 Nov 2013, Li.Xiubo at freescale.com wrote:
>>> This patch add and enable SAI device.
>>>
>>> arch/arm/boot/dts/vf610-twr.dts | 6 ++++++
>>> 1 file changed, 6 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/vf610-twr.dts
>>> b/arch/arm/boot/dts/vf610-twr.dts index 1a58678..e4106dd 100644
>>> --- a/arch/arm/boot/dts/vf610-twr.dts
>>> +++ b/arch/arm/boot/dts/vf610-twr.dts
>>>>> -57,6 +57,12 @@
>>> status = "okay";
>>> };
>>
>> Should we put a comment here that a TWR-AUDIO-SGTL board is needed? Or
>> is this better in a menuconfig? I guess TWR-AUDIO-SGTL is needed as this
>> codec is not on the VF610-TWR main board?
>>
>
> Yes, the SGTL5000 codec is not on the VF610-TWR main board, and needs an extra
> TWR-AUDIO-SGTL board.
>
> IMO, puting this comment in the menuconfig is much better.
I agree. I guess the patch set 6 makes more sense. Also, you might
consider adding a printk in the 'fsl_sgtl5000_probe()'. I guess that
devm_snd_soc_register_card() will fail if the board is not present? As
the board is not 'standard' people may come asking why the audio fails
on the 'VF610-TWR'.
+ ret = devm_snd_soc_register_card(&pdev->dev, &fsl_sgt1500_card);
+ if (ret) {
+ dev_err(&pdev->dev, "register soc sound card failed :%d\n"
+ "TWR-AUDIO-SGTL board required.\n",
+ ret);
+ return ret;
+ }
Especially, you can make one kernel that handles both cases w/wo
TWR-AUDIO-SGTL board attached.
Thanks for your work.
Bill Pringlemeir.
next prev parent reply other threads:[~2013-11-20 16:04 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-01 7:04 No subject Xiubo Li
2013-11-01 7:04 ` [PATCHv2 1/8] ALSA: Add SAI SoC Digital Audio Interface driver Xiubo Li
2013-11-01 8:59 ` Nicolin Chen
2013-11-04 3:45 ` Li Xiubo
2013-11-04 4:33 ` Nicolin Chen
2013-11-20 3:37 ` Li Xiubo
2013-11-20 3:37 ` Nicolin Chen
2013-11-20 4:16 ` Li Xiubo
2013-11-05 13:26 ` Timur Tabi
2013-11-06 3:27 ` Li Xiubo
2013-11-06 3:31 ` Timur Tabi
2013-11-06 3:53 ` Li Xiubo
2013-11-06 8:12 ` Shawn Guo
2013-11-06 9:38 ` Li Xiubo
2013-11-01 18:25 ` Mark Brown
2013-11-04 7:35 ` Li Xiubo
2013-11-04 16:15 ` Mark Brown
2013-11-05 3:21 ` Li Xiubo
2013-11-06 9:53 ` Mark Brown
2013-11-01 7:04 ` [PATCHv2 2/8] ARM: dts: Add Freescale SAI ALSA SoC Digital Audio Interface node for VF610 Xiubo Li
2013-11-01 7:04 ` [PATCHv2 3/8] ARM: dts: Enables SAI ALSA SoC DAI device for Vybrid VF610 TOWER board Xiubo Li
2013-11-18 18:07 ` Bill Pringlemeir
2013-11-20 3:14 ` Li Xiubo
2013-11-20 16:04 ` Bill Pringlemeir [this message]
2013-11-21 2:58 ` Li Xiubo
2013-11-21 14:55 ` Bill Pringlemeir
2013-11-22 6:46 ` Li Xiubo
2013-11-22 15:09 ` Bill Pringlemeir
2013-11-28 7:45 ` Li Xiubo
2013-11-01 7:04 ` [PATCHv2 4/8] Documentation: Add device tree bindings for Freescale SAI Xiubo Li
2013-11-01 7:04 ` [PATCHv2 5/8] ASoC: SGTL5000: Enhance the SGTL5000 codec driver about regulator Xiubo Li
2013-11-01 10:02 ` Nicolin Chen
2013-11-01 18:50 ` Mark Brown
2013-11-06 8:59 ` Li Xiubo
2013-11-06 10:03 ` Mark Brown
2013-11-07 3:01 ` Li Xiubo
2013-11-07 20:38 ` Mark Brown
2013-11-01 7:04 ` [PATCHv2 6/8] ASoC: fsl: add SGTL5000 based audio machine driver Xiubo Li
2013-11-01 10:17 ` Oskar Schirmer
2013-11-05 3:26 ` Li Xiubo
2013-11-01 10:28 ` Nicolin Chen
2013-11-01 12:07 ` Shawn Guo
2013-11-05 6:17 ` Li Xiubo
2013-11-05 3:50 ` Li Xiubo
2013-11-01 18:40 ` Mark Brown
2013-11-04 9:52 ` Li Xiubo
2013-11-20 7:49 ` Li Xiubo
2013-11-01 7:04 ` [PATCHv2 7/8] ARM: dts: Enable SGTL5000 codec based audio driver node for VF610 Xiubo Li
2013-11-01 7:04 ` [PATCHv2 8/8] Documentation: Add device tree bindings for Freescale VF610 sound Xiubo Li
2013-11-01 7:52 ` [PATCHv1 0/8] ALSA: Add SAI driver and enable SGT15000 codec Li Xiubo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87hab7hxfx.fsf@nbsps.com \
--to=bpringlemeir@nbsps.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).