* [PATCH -next] pinctrl: armada-37xx: remove unneeded semicolon
@ 2019-10-25 9:22 YueHaibing
2019-10-25 9:31 ` Gregory CLEMENT
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2019-10-25 9:22 UTC (permalink / raw)
To: jason, andrew, gregory.clement, sebastian.hesselbarth, linus.walleij
Cc: linux-gpio, YueHaibing, linux-kernel, linux-arm-kernel
Remove unneeded semicolon.
This is detected by coccinelle.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
index 9df4277..fd32989 100644
--- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
+++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
@@ -733,7 +733,7 @@ static int armada_37xx_irqchip_register(struct platform_device *pdev,
ret = 0;
break;
}
- };
+ }
if (ret) {
dev_err(dev, "no gpio-controller child node\n");
return ret;
@@ -800,7 +800,7 @@ static int armada_37xx_gpiochip_register(struct platform_device *pdev,
ret = 0;
break;
}
- };
+ }
if (ret)
return ret;
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] pinctrl: armada-37xx: remove unneeded semicolon
2019-10-25 9:22 [PATCH -next] pinctrl: armada-37xx: remove unneeded semicolon YueHaibing
@ 2019-10-25 9:31 ` Gregory CLEMENT
0 siblings, 0 replies; 2+ messages in thread
From: Gregory CLEMENT @ 2019-10-25 9:31 UTC (permalink / raw)
To: YueHaibing, jason, andrew, sebastian.hesselbarth, linus.walleij
Cc: linux-gpio, YueHaibing, linux-kernel, linux-arm-kernel
YueHaibing <yuehaibing@huawei.com> writes:
> Remove unneeded semicolon.
> This is detected by coccinelle.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
I am against this patch, I don't see any value of this change. It will
only make backporting future fix more difficult and will obscurate the
git blame.
I could see the interest of scripts/coccinelle/misc/semicolon.cocci
when submitting new code, but not for existing code.
Gregory
> ---
> drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
> index 9df4277..fd32989 100644
> --- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
> +++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
> @@ -733,7 +733,7 @@ static int armada_37xx_irqchip_register(struct platform_device *pdev,
> ret = 0;
> break;
> }
> - };
> + }
> if (ret) {
> dev_err(dev, "no gpio-controller child node\n");
> return ret;
> @@ -800,7 +800,7 @@ static int armada_37xx_gpiochip_register(struct platform_device *pdev,
> ret = 0;
> break;
> }
> - };
> + }
> if (ret)
> return ret;
>
> --
> 2.7.4
>
>
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-25 9:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-25 9:22 [PATCH -next] pinctrl: armada-37xx: remove unneeded semicolon YueHaibing
2019-10-25 9:31 ` Gregory CLEMENT
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).