From: hverkuil@xs4all.nl (Hans Verkuil)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 5/9] vcodec: mediatek: Add Mediatek V4L2 Video Decoder Driver
Date: Mon, 1 Aug 2016 12:39:44 +0200 [thread overview]
Message-ID: <8bd71dee-62ec-beba-c1d1-fc7e586d593b@xs4all.nl> (raw)
In-Reply-To: <1470044307.30651.18.camel@mtksdaap41>
Hi Tiffany,
On 08/01/2016 11:38 AM, Tiffany Lin wrote:
> Hi Hans,
<snip>
>>> +static int vidioc_vdec_g_selection(struct file *file, void *priv,
>>> + struct v4l2_selection *s)
>>> +{
>>> + struct mtk_vcodec_ctx *ctx = fh_to_ctx(priv);
>>> +
>>> + if (V4L2_TYPE_IS_OUTPUT(s->type))
>>> + return -EINVAL;
>>> +
>>> + if (s->target != V4L2_SEL_TGT_CROP)
>>> + return -EINVAL;
>>
>> How does the cropping rectangle relate to the format size? There is no s_selection,
>> so this doesn't make sense.
>>
> I want to return encoded crop information or real display region that
> display driver could know where is padding region.
Sorry, I don't understand this.
This is a decoder, so based on the bitstream it decodes to a certain width
and height. I assume that is what you refer to as coded_width and coded_height?
If so, then what is the 'real display region' and how does it relate to the
coded width/height?
This is probably a terminology issue but I need to understand this before I
can decide what should be done here.
Regards,
Hans
> User space use s_fmt/g_fmt to set/get coded_width and coded_height, and
> use g_crop to get real display region.
> That's why I do not add s_selection.
>
>> Alternatively, it could be that you are really returning V4L2_SEL_TGT_COMPOSE_PADDED.
>>
>
> V4L2_SEL_TGT_COMPOSE_PADDED means
> "The active area and all padding pixels that are inserted or modified by
> hardware."
> But I just want to return active area to user space.
>
>>> +
>>> + if (ctx->state < MTK_STATE_HEADER)
>>> + return -EINVAL;
>>> +
>>> + if ((ctx->q_data[MTK_Q_DATA_SRC].fmt->fourcc == V4L2_PIX_FMT_H264) ||
>>> + (ctx->q_data[MTK_Q_DATA_SRC].fmt->fourcc == V4L2_PIX_FMT_VP8) ||
>>> + (ctx->q_data[MTK_Q_DATA_SRC].fmt->fourcc == V4L2_PIX_FMT_VP9)) {
>>> +
>>> + if (vdec_if_get_param(ctx, GET_PARAM_CROP_INFO, &(s->r))) {
>>> + mtk_v4l2_debug(2,
>>> + "[%d]Error!! Cannot get param : GET_PARAM_CROP_INFO ERR",
>>> + ctx->id);
>>> + s->r.left = 0;
>>> + s->r.top = 0;
>>> + s->r.width = ctx->picinfo.buf_w;
>>> + s->r.height = ctx->picinfo.buf_h;
>>> + }
>>> + mtk_v4l2_debug(2, "Cropping info: l=%d t=%d w=%d h=%d",
>>> + s->r.left, s->r.top, s->r.width,
>>> + s->r.height);
>>> + } else {
>>> + s->r.left = 0;
>>> + s->r.top = 0;
>>> + s->r.width = ctx->picinfo.pic_w;
>>> + s->r.height = ctx->picinfo.pic_h;
>>> + mtk_v4l2_debug(2, "Cropping info: w=%d h=%d fw=%d fh=%d",
>>> + s->r.width, s->r.height, ctx->picinfo.buf_w,
>>> + ctx->picinfo.buf_h);
>>> + }
>>> + return 0;
>>> +}
next prev parent reply other threads:[~2016-08-01 10:39 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-30 12:29 [PATCH v3 0/9] Add MT8173 Video Decoder Driver Tiffany Lin
2016-05-30 12:29 ` [PATCH v3 1/9] VPU: mediatek: Add decode support Tiffany Lin
2016-05-30 12:29 ` [PATCH v3 2/9] v4l: add Mediatek compressed video block format Tiffany Lin
2016-05-30 12:29 ` [PATCH v3 3/9] DocBook/v4l: Add compressed video formats used on MT8173 codec driver Tiffany Lin
2016-05-30 12:29 ` [PATCH v3 4/9] dt-bindings: Add a binding for Mediatek Video Decoder Tiffany Lin
2016-05-30 12:29 ` [PATCH v3 5/9] vcodec: mediatek: Add Mediatek V4L2 Video Decoder Driver Tiffany Lin
2016-05-30 12:29 ` [PATCH v3 6/9] vcodec: mediatek: Add Mediatek H264 " Tiffany Lin
2016-05-30 12:29 ` [PATCH v3 7/9] vcodec: mediatek: Add Mediatek VP8 " Tiffany Lin
2016-05-30 12:29 ` [PATCH v3 8/9] vcodec: mediatek: Add Mediatek VP9 " Tiffany Lin
2016-05-30 12:29 ` [PATCH v3 9/9] arm64: dts: mediatek: Add Video Decoder for MT8173 Tiffany Lin
2016-07-08 11:06 ` [PATCH v3 5/9] vcodec: mediatek: Add Mediatek V4L2 Video Decoder Driver Hans Verkuil
2016-08-01 9:38 ` Tiffany Lin
2016-08-01 10:39 ` Hans Verkuil [this message]
2016-08-01 11:28 ` Tiffany Lin
2016-07-08 10:23 ` [PATCH v3 3/9] DocBook/v4l: Add compressed video formats used on MT8173 codec driver Hans Verkuil
2016-07-11 2:56 ` tiffany lin
2016-07-12 8:16 ` Wu-Cheng Li (李務誠)
2016-07-12 19:08 ` Nicolas Dufresne
2016-07-12 19:14 ` Nicolas Dufresne
2016-07-12 19:31 ` Ian Arkver
2016-07-13 2:00 ` tiffany lin
2016-07-13 13:55 ` Nicolas Dufresne
2016-07-14 7:30 ` tiffany lin
2016-07-13 2:22 ` Wu-Cheng Li (李務誠)
2016-07-13 1:50 ` tiffany lin
2016-07-13 2:03 ` tiffany lin
2016-06-07 14:22 ` [PATCH v3 0/9] Add MT8173 Video Decoder Driver Mauro Carvalho Chehab
2016-06-07 22:13 ` Hans Verkuil
2016-06-14 8:44 ` Wu-Cheng Li (李務誠)
2016-06-14 11:08 ` tiffany lin
2016-06-16 10:54 ` Mauro Carvalho Chehab
2016-07-01 10:11 ` Hans Verkuil
2016-07-01 10:47 ` Wu-Cheng Li (李務誠)
2016-07-01 11:53 ` andrew-ct chen
2016-07-01 12:00 ` Hans Verkuil
2016-07-04 11:09 ` andrew-ct chen
2016-07-06 13:19 ` Hans Verkuil
2016-07-07 10:16 ` tiffany lin
2016-07-07 11:13 ` Hans Verkuil
2016-07-08 11:44 ` Hans Verkuil
2016-07-11 3:58 ` tiffany lin
2016-07-21 9:12 ` tiffany lin
2016-08-15 8:30 ` Hans Verkuil
2016-08-15 9:03 ` Tiffany Lin
2016-08-15 9:07 ` Hans Verkuil
2016-08-15 9:10 ` Tiffany Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bd71dee-62ec-beba-c1d1-fc7e586d593b@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).