From: dirk.behme@de.bosch.com (Dirk Behme)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/3] arm64: dts: r8a7796: Add Renesas R8A7796 SoC support
Date: Thu, 26 May 2016 10:11:01 +0200 [thread overview]
Message-ID: <8c0ea32b-b722-62ac-6810-b1239d0de4eb@de.bosch.com> (raw)
In-Reply-To: <CAMuHMdW7FacxRFf9VCiYPwR5kUEfBteT3+LBCrzof1cmpLjGDg@mail.gmail.com>
Hi Geert,
On 26.05.2016 10:05, Geert Uytterhoeven wrote:
> Hi Dirk,
>
> On Thu, May 26, 2016 at 9:32 AM, Dirk Behme <dirk.behme@de.bosch.com> wrote:
>> On 26.05.2016 09:03, Geert Uytterhoeven wrote:
>>> On Wed, May 25, 2016 at 9:32 AM, Dirk Behme <dirk.behme@de.bosch.com>
>>> wrote:
>>>> P.S.: This also results in the question why we need similar
>>>> r8a7795-cpg-mssr.h and r8a7796-cpg-mssr.h with just different "numbers"
>>>> for
>>>> the same clocks. Can't we use the same numbers on all SoCs, with just
>>>> having
>>>> wholes in the list where the clocks don't exist on a SoC? I haven't
>>>> looked
>>>
>>> The CPG and MSSR block are the IP blocks that differ most among SoCs of
>>> the
>>> same family. Some clocks are present on H3 only, others on M3-W only.
>>
>> Yes, this is my understanding as well. Is the H3 a superset? And the M3-W
>> drops some clocks? Or are there really clocks which are on M3-W only and not
>> on H3?
>
> H3 is not a superset.
> M3-W e.g. has more S0Dx clocks (for x = 2, 3, 6, 8, 12).
Ok, thanks!
>> this
>>
>> &scif2 {
>> clocks = <&cpg CPG_MOD 310>,
>> <&cpg CPG_CORE R8A7795_CLK_S3D1>,
>> <&scif_clk>;
>> };
>>
>> &scif2 {
>> clocks = <&cpg CPG_MOD 310>,
>> <&cpg CPG_CORE R8A7796_CLK_S3D1>,
>> <&scif_clk>;
>> };
>>
>> should be done better.
>
> That's a bad example, as both SoCs use S3D1 ;-)
Then, I'd propose to find a clever way to put the common parts into a
rcar-gen3.dtsi and ...
> Now look at e.g. i2c:
> - On H3, the parent of the i2c module clock is S3D2,
> - On M3-W, the parent of the i2c module clock is S3D2 for i2c0/1/2,
> and S0D6 for i2c3/4/5/6.
... to keep the differences in the r8a7795.dtsi, r8a7796.dtsi etc.
Best regards
Dirk
next prev parent reply other threads:[~2016-05-26 8:11 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-24 1:54 [PATCH v3 0/3] arm64: Add Renesas R8A7796 SoC support Simon Horman
2016-05-24 1:54 ` [PATCH v3 1/3] arm64: dts: r8a7796: " Simon Horman
2016-05-24 5:30 ` Dirk Behme
2016-05-25 0:48 ` Simon Horman
2016-05-25 5:10 ` Dirk Behme
2016-05-25 7:32 ` Dirk Behme
2016-05-26 7:03 ` Geert Uytterhoeven
2016-05-26 7:32 ` Dirk Behme
2016-05-26 8:05 ` Geert Uytterhoeven
2016-05-26 8:11 ` Dirk Behme [this message]
2016-05-26 2:28 ` Simon Horman
2016-05-26 7:14 ` Dirk Behme
2016-05-27 0:42 ` Simon Horman
2016-05-27 6:39 ` Geert Uytterhoeven
2016-05-27 7:32 ` Dirk Behme
2016-06-29 8:15 ` Dirk Behme
2016-07-20 23:51 ` Simon Horman
2016-07-21 5:20 ` Dirk Behme
2016-07-22 1:47 ` Simon Horman
2016-05-25 7:38 ` Dirk Behme
2016-05-26 2:31 ` Simon Horman
2016-05-24 1:54 ` [PATCH v3 2/3] arm64: dts: salvator-x: add Salvator-X board on R8A7796 SoC Simon Horman
2016-05-24 1:54 ` [PATCH v3 3/3] arm64: defconfig: enable Renesas " Simon Horman
2016-06-06 1:33 ` [PATCH v3 0/3] arm64: Add Renesas R8A7796 SoC support Simon Horman
2016-06-06 1:52 ` Simon Horman
2016-06-24 3:05 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c0ea32b-b722-62ac-6810-b1239d0de4eb@de.bosch.com \
--to=dirk.behme@de.bosch.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).