From: Angus Ainslie <angus@akkea.ca>
To: Daniel Baluta <daniel.baluta@gmail.com>
Cc: "Mark Rutland" <mark.rutland@arm.com>,
"Devicetree List" <devicetree@vger.kernel.org>,
"Andra Danciu" <andradanciu1997@gmail.com>,
"Abel Vesa" <abel.vesa@nxp.com>,
"Anson Huang" <Anson.Huang@nxp.com>,
"Carlo Caione" <ccaione@baylibre.com>,
andrew.smirnov@gmail.com, "Fabio Estevam" <festevam@gmail.com>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
dl-linux-imx <linux-imx@nxp.com>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Shawn Guo" <shawnguo@kernel.org>,
"Guido Günther" <agx@sigxcpu.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
"Lucas Stach" <l.stach@pengutronix.de>
Subject: Re: [PATCH v3] arm64: dts: imx8mq: Add sai3 and sai6 nodes
Date: Wed, 03 Jul 2019 07:58:32 -0600 [thread overview]
Message-ID: <8ebfeaae8541132ad39e4109d135cd5f@www.akkea.ca> (raw)
In-Reply-To: <CAEnQRZCoOyyZVs0=BjXB5=wYe3XW9GOF9JvwjhSU9BsChh08uA@mail.gmail.com>
Hi Daniel,
On 2019-07-03 07:25, Daniel Baluta wrote:
> On Wed, Jul 3, 2019 at 4:12 PM Angus Ainslie <angus@akkea.ca> wrote:
>>
>> Hi Daniel,
>>
>> On 2019-07-03 07:10, Daniel Baluta wrote:
>> > On Wed, Jul 3, 2019 at 4:01 PM Angus Ainslie <angus@akkea.ca> wrote:
>> >>
>> >> Hi Andra,
>> >>
>> >> I tried this out on linux-next and I'm not able to record or play
>> >> sound.
>> >>
>> >> I also added the sai2 entry to test out our devkit and get a PCM
>> >> timeout
>> >> with that.
>> >
>> > Hi Angus,
>> >
>> > There are still lots of SAI patches that need to be upstream. Me and
>> > Andra
>> > will be working on that over this summer.
>> >
>> >>
>> >> On 2019-07-02 07:23, Andra Danciu wrote:
>> >> > SAI3 and SAI6 nodes are used to connect to an external codec.
>> >> > They have 1 Tx and 1 Rx dataline.
>> >> >
>> >> > Cc: Daniel Baluta <daniel.baluta@nxp.com>
>> >> > Signed-off-by: Andra Danciu <andradanciu1997@gmail.com>
>> >> > ---
>> >> > Changes since v2:
>> >> > - removed multiple new lines
>> >> >
>> >> > Changes since v1:
>> >> > - Added sai3 node because we need it to enable audio on pico-pi-8m
>> >> > - Added commit description
>> >> >
>> >> > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 29
>> >> > +++++++++++++++++++++++++++++
>> >> > 1 file changed, 29 insertions(+)
>> >> >
>> >> > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
>> >> > b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
>> >> > index d09b808eff87..736cf81b695e 100644
>> >> > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
>> >> > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
>> >> > @@ -278,6 +278,20 @@
>> >> > #size-cells = <1>;
>> >> > ranges = <0x30000000 0x30000000 0x400000>;
>> >> >
>> >> > + sai6: sai@30030000 {
>> >> > + compatible = "fsl,imx8mq-sai",
>> >>
>> >> I don't find this compatible string in sound/soc/fsl/fsl_sai.c. Aren't
>> >> the registers at a different offset from "fsl,imx6sx-sai".
>> >
>> > Yes, you are right on this. We are trying to slowly push all our
>> > internal-tree
>> > patches to mainline. Obviously, with started with low hanging fruits,
>> > DTS
>> > nodes and small SAI fixes.
>> >
>> > Soon, we will start to send patches for SAI IP ipgrade for imx8.
>> >
>> >>
>> >> How is this supposed to work ?
>> >>
>> >
>> > For the moment it won't work unless we will upstream all our SAI
>> > internal patches.
>> > But we will get there hopefully this summer.
>> >
>>
>> Shouldn't a working driver be upstream before enabling it in the
>> devicetree ?
>
> I see your point here and maybe your suggestion is the ideal
> way to do things.
>
> Anyhow, I don't see a problem with adding the node in dts
> because CONFIG_FSL_SAI is not set in the default config.
>
I think the assumption is that devices in the devicetree are tested and
working. That's not currently the case for sai on imx8mq.
> We try to speedup the upstreaming process giving the fact
> that SAI patches will go through audio maintainer's tree and
> the DTS patches will most likely go through Shawn's tree.
>
Ok I can see them being committed concurrently but I haven't even seen a
v1 of the sai patches.
Thanks
Angus
> thanks,
> Daniel.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-07-03 13:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-02 13:23 [PATCH v3] arm64: dts: imx8mq: Add sai3 and sai6 nodes Andra Danciu
2019-07-03 6:27 ` Daniel Baluta
2019-07-03 13:00 ` Angus Ainslie
2019-07-03 13:10 ` Daniel Baluta
2019-07-03 13:12 ` Angus Ainslie
2019-07-03 13:25 ` Daniel Baluta
2019-07-03 13:58 ` Angus Ainslie [this message]
2019-07-16 15:58 ` Lucas Stach
2019-07-17 14:04 ` Daniel Baluta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ebfeaae8541132ad39e4109d135cd5f@www.akkea.ca \
--to=angus@akkea.ca \
--cc=Anson.Huang@nxp.com \
--cc=abel.vesa@nxp.com \
--cc=agx@sigxcpu.org \
--cc=andradanciu1997@gmail.com \
--cc=andrew.smirnov@gmail.com \
--cc=ccaione@baylibre.com \
--cc=daniel.baluta@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).