From: Philippe Schenker <philippe.schenker@toradex.com>
To: "stefan@agner.ch" <stefan@agner.ch>
Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"michal.vokac@ysoft.com" <michal.vokac@ysoft.com>,
Max Krummenacher <max.krummenacher@toradex.com>,
Stefan Agner <stefan.agner@toradex.com>,
Marcel Ziswiler <marcel.ziswiler@toradex.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"linux-imx@nxp.com" <linux-imx@nxp.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 07/20] ARM: dts: imx7-colibri: fix 1.8V/UHS support
Date: Mon, 5 Aug 2019 07:18:59 +0000 [thread overview]
Message-ID: <90509acd1da1aa85699952e012fa1034255f1a06.camel@toradex.com> (raw)
In-Reply-To: <de6bec64012876c07267024cd4b2d2d5@agner.ch>
On Fri, 2019-08-02 at 10:51 +0200, Stefan Agner wrote:
> On 2019-07-31 16:52, Philippe Schenker wrote:
> > On Wed, 2019-07-31 at 09:56 -0300, Fabio Estevam wrote:
> > > On Wed, Jul 31, 2019 at 9:38 AM Philippe Schenker
> > > <philippe.schenker@toradex.com> wrote:
> > > > From: Stefan Agner <stefan.agner@toradex.com>
> > > >
> > > > Add pinmuxing and do not specify voltage restrictions in the
> > > > module level device tree.
> > >
> > > It would be nice to explain the reason for doing this.
> >
> > This commit is in preparation of another patch that didn't made into this
> > patchset (downstream stuff in there). But I will do another patch on top
> > that
> > will use this patch here. That should anyway be in mainline.
>
> I guess what Fabio meant here is explain this patch.
>
> The commit message really could be improved, e.g.:
>
> Add pinmuxing and do not specify voltage restrictions for the usdhc
> instance
> available on the modules edge connector. This allows to use SD-cards
> with
> higher transfer modes if supported by the carrier board.
>
> --
> Stefan
Ah, sorry Fabio. I indeed understood you wrong and thanks Stefan for clarifying.
I have the new message in for v3.
Philippe
>
> > Philippe
> >
> > > > Signed-off-by: Stefan Agner <stefan.agner@toradex.com>
> > > > Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com>
> > > > ---
> > > >
> > > > Changes in v2: None
> > > >
> > > > arch/arm/boot/dts/imx7-colibri.dtsi | 23 ++++++++++++++++++++++-
> > > > 1 file changed, 22 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/arch/arm/boot/dts/imx7-colibri.dtsi
> > > > b/arch/arm/boot/dts/imx7-
> > > > colibri.dtsi
> > > > index 16d1a1ed1aff..67f5e0c87fdc 100644
> > > > --- a/arch/arm/boot/dts/imx7-colibri.dtsi
> > > > +++ b/arch/arm/boot/dts/imx7-colibri.dtsi
> > > > @@ -326,7 +326,6 @@
> > > > &usdhc1 {
> > > > pinctrl-names = "default";
> > > > pinctrl-0 = <&pinctrl_usdhc1 &pinctrl_cd_usdhc1>;
> > > > - no-1-8-v;
> > > > cd-gpios = <&gpio1 0 GPIO_ACTIVE_LOW>;
> > > > disable-wp;
> > > > vqmmc-supply = <®_LDO2>;
> > > > @@ -671,6 +670,28 @@
> > > > >;
> > > > };
> > > >
> > > > + pinctrl_usdhc1_100mhz: usdhc1grp_100mhz {
> > > > + fsl,pins = <
> > > > + MX7D_PAD_SD1_CMD__SD1_CMD 0x5a
> > > > + MX7D_PAD_SD1_CLK__SD1_CLK 0x1a
> > > > + MX7D_PAD_SD1_DATA0__SD1_DATA0 0x5a
> > > > + MX7D_PAD_SD1_DATA1__SD1_DATA1 0x5a
> > > > + MX7D_PAD_SD1_DATA2__SD1_DATA2 0x5a
> > > > + MX7D_PAD_SD1_DATA3__SD1_DATA3 0x5a
> > > > + >;
> > > > + };
> > > > +
> > > > + pinctrl_usdhc1_200mhz: usdhc1grp_200mhz {
> > > > + fsl,pins = <
> > > > + MX7D_PAD_SD1_CMD__SD1_CMD 0x5b
> > > > + MX7D_PAD_SD1_CLK__SD1_CLK 0x1b
> > > > + MX7D_PAD_SD1_DATA0__SD1_DATA0 0x5b
> > > > + MX7D_PAD_SD1_DATA1__SD1_DATA1 0x5b
> > > > + MX7D_PAD_SD1_DATA2__SD1_DATA2 0x5b
> > > > + MX7D_PAD_SD1_DATA3__SD1_DATA3 0x5b
> > > > + >;
> > > > + };
> > >
> > > You add the entries for 100MHz and 200MHz, but I don't see them being
> > > referenced anywhere.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-08-05 7:19 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 12:37 [PATCH v2 00/20] Common patches from downstream development Philippe Schenker
2019-07-31 12:38 ` [PATCH v2 01/20] ARM: dts: imx7-colibri: make sure module supplies are always on Philippe Schenker
2019-07-31 12:38 ` [PATCH v2 02/20] ARM: dts: imx7-colibri: disable HS400 Philippe Schenker
2019-07-31 12:38 ` [PATCH v2 03/20] ARM: dts: imx7-colibri: prepare module device tree for FlexCAN Philippe Schenker
2019-07-31 12:38 ` [PATCH v2 04/20] ARM: dts: imx7-colibri: Add sleep mode to ethernet Philippe Schenker
2019-07-31 12:38 ` [PATCH v2 05/20] ARM: dts: add recovery for I2C for iMX7 Philippe Schenker
2019-07-31 12:38 ` [PATCH v2 06/20] ARM: dts: imx7-colibri: add GPIO wakeup key Philippe Schenker
2019-07-31 12:38 ` [PATCH v2 07/20] ARM: dts: imx7-colibri: fix 1.8V/UHS support Philippe Schenker
2019-07-31 12:56 ` Fabio Estevam
2019-07-31 14:52 ` Philippe Schenker
2019-08-02 8:51 ` Stefan Agner
2019-08-05 7:18 ` Philippe Schenker [this message]
2019-07-31 12:38 ` [PATCH v2 08/20] ARM: dts: imx7-colibri: Add touch controllers Philippe Schenker
2019-07-31 12:42 ` Fabio Estevam
2019-07-31 14:39 ` Philippe Schenker
2019-07-31 12:38 ` [PATCH v2 09/20] ARM: dts: imx6qdl-colibri: add phy to fec Philippe Schenker
2019-07-31 12:38 ` [PATCH v2 10/20] ARM: dts: imx6qdl-colibri: Add missing pin declaration in iomuxc Philippe Schenker
2019-07-31 12:38 ` [PATCH v2 11/20] ARM: dts: imx6qdl-apalis: Add sleep state to can interfaces Philippe Schenker
2019-07-31 12:38 ` [PATCH v2 12/20] ARM: dts: imx6: Add touchscreens used on Toradex eval boards Philippe Schenker
2019-07-31 12:38 ` [PATCH v2 13/20] ARM: dts: imx6-colibri: Add missing pinmuxing to Toradex eval board Philippe Schenker
2019-07-31 12:38 ` [PATCH v2 14/20] ARM: dts: imx6ull-colibri: Add sleep mode to fec Philippe Schenker
2019-07-31 12:38 ` [PATCH v2 15/20] ARM: dts: imx6ull-colibri: reduce v_batt current in power off Philippe Schenker
2019-07-31 12:38 ` [PATCH v2 16/20] ARM: dts: imx6ull-colibri: Add watchdog Philippe Schenker
2019-07-31 12:38 ` [PATCH v2 17/20] ARM: dts: imx6ull: improve can templates Philippe Schenker
2019-07-31 12:38 ` [PATCH v2 18/20] ARM: dts: imx6ull-colibri: Add general wakeup key used on Colibri Philippe Schenker
2019-07-31 12:38 ` [PATCH v2 19/20] ARM: dts: imx6/7-colibri: switch dr_mode to otg Philippe Schenker
2019-07-31 12:38 ` [PATCH v2 20/20] ARM: dts: imx6ull-colibri: Add touchscreen used with Eval Board Philippe Schenker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90509acd1da1aa85699952e012fa1034255f1a06.camel@toradex.com \
--to=philippe.schenker@toradex.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel.ziswiler@toradex.com \
--cc=mark.rutland@arm.com \
--cc=max.krummenacher@toradex.com \
--cc=michal.vokac@ysoft.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stefan.agner@toradex.com \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).