From: Vignesh Raghavendra <vigneshr@ti.com>
To: Nishanth Menon <nm@ti.com>, Suman Anna <s-anna@ti.com>
Cc: devicetree@vger.kernel.org, grygorii.strashko@ti.com,
lokeshvutla@ti.com, nsekhar@ti.com, linux-kernel@vger.kernel.org,
Tero Kristo <t-kristo@ti.com>, Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 6/7] arm64: dts: ti: k3-*: Use generic adc for node names
Date: Thu, 3 Sep 2020 10:55:11 +0530 [thread overview]
Message-ID: <9fb2f8f4-5eeb-6190-9cbf-b28084c58a8f@ti.com> (raw)
In-Reply-To: <20200902181820.nlvl3pfzeh4agzzi@akan>
Hi Nishanth,
On 9/2/20 11:48 PM, Nishanth Menon wrote:
> On 11:51-20200902, Suman Anna wrote:
>> On 9/1/20 5:30 PM, Nishanth Menon wrote:
>>> Use adc@ naming for nodes following standard conventions of device
>>> tree (section 2.2.2 Generic Names recommendation in [1]).
>>>
>>> [1] https://github.com/devicetree-org/devicetree-specification/tree/v0.3
>>>
>>> Suggested-by: Suman Anna <s-anna@ti.com>
>>> Signed-off-by: Nishanth Menon <nm@ti.com>
>>> ---
>>> arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi | 4 ++--
>>> arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi | 4 ++--
>>> 2 files changed, 4 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi
>>> index 51ca4b4d4c21..6dfec68ac865 100644
>>> --- a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi
>>> +++ b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi
>>> @@ -80,7 +80,7 @@
>>> #size-cells = <0>;
>>> };
>>>
>>> - tscadc0: tscadc@40200000 {
>>> + tscadc0: adc@40200000 {
>>
>> OK with these changes, since these seem to be only have the adc child nodes.
>> This node is essentially a parent node for touchscreen and adc child nodes. The
>> driver is currently looking for "tsc" on touchscreen child nodes, but none of
>> the K3 SoCs have them atm.
>>
>
>
> Vignesh: are you ok with this, care to comment?
>
On K3 SoCs, ADC IP is reuse from AM335x but just lacks resistive
touchscreen interfaces. So, existing AM335x ADC driver is being reused
for K3 devices as well. Unfortunately, ADC driver cannot be used as
standalone and is dependent on MFD parent to be present...
Above node represents the MFD parent and ADC itself is the child node
(see arch/arm64/boot/dts/ti/k3-am654-base-board.dts). So, I recommend
that we keep this node's name as tscadc in order to avoid having same
name for parent and child node which will be quite confusing.
Regards
Vignesh
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-03 5:26 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 22:30 [PATCH 0/7] arm64: dts: ti: k3-*: Squash up node_name_chars_strict warnings Nishanth Menon
2020-09-01 22:30 ` [PATCH 1/7] arm64: dts: ti: k3-am65*: Use generic gpio for node names Nishanth Menon
2020-09-02 4:13 ` Suman Anna
2020-09-01 22:30 ` [PATCH 2/7] arm64: dts: ti: k3-am65*: Use generic clock for serdes clock name Nishanth Menon
2020-09-02 17:45 ` Suman Anna
2020-09-02 18:21 ` Nishanth Menon
2020-09-01 22:30 ` [PATCH 3/7] arm64: dts: ti: k3-*: Use generic pinctrl for node names Nishanth Menon
2020-09-02 4:14 ` Suman Anna
2020-09-01 22:30 ` [PATCH 4/7] arm64: dts: ti: k3-am65-base-board Use generic camera for node name instead of ov5640 Nishanth Menon
2020-09-02 4:14 ` Suman Anna
2020-09-01 22:30 ` [PATCH 5/7] arm64: dts: ti: k3-am65-wakeup: Use generic temperature-sensor for node name Nishanth Menon
2020-09-02 16:55 ` Suman Anna
2020-09-02 18:14 ` Nishanth Menon
2020-09-01 22:30 ` [PATCH 6/7] arm64: dts: ti: k3-*: Use generic adc for node names Nishanth Menon
2020-09-02 16:51 ` Suman Anna
2020-09-02 18:18 ` Nishanth Menon
2020-09-03 5:25 ` Vignesh Raghavendra [this message]
2020-09-03 11:23 ` Nishanth Menon
2020-09-01 22:30 ` [PATCH 7/7] arm64: dts: ti: k3-*: Fix up node_name_chars_strict errors Nishanth Menon
2020-09-02 16:54 ` Suman Anna
2020-09-02 18:16 ` Nishanth Menon
2020-09-02 3:36 ` [PATCH 0/7] arm64: dts: ti: k3-*: Squash up node_name_chars_strict warnings Lokesh Vutla
2020-09-03 13:00 ` [PATCH V2 0/8] arm64: dts: ti: k3-*: Squash up node_name_chars_strict warnings + hex usage Nishanth Menon
2020-09-07 11:54 ` Nishanth Menon
2020-09-03 13:00 ` [PATCH V2 1/8] arm64: dts: ti: k3-j721e: Use lower case hexadecimal Nishanth Menon
2020-09-03 13:23 ` Suman Anna
2020-09-03 14:01 ` Lokesh Vutla
2020-09-03 13:00 ` [PATCH V2 2/8] arm64: dts: ti: k3-am65-main: " Nishanth Menon
2020-09-03 13:24 ` Suman Anna
2020-09-03 14:02 ` Lokesh Vutla
2020-09-03 13:00 ` [PATCH V2 3/8] arm64: dts: ti: k3-am65*: Use generic gpio for node names Nishanth Menon
2020-09-03 13:00 ` [PATCH V2 4/8] arm64: dts: ti: k3-am65*: Use generic clock for syscon clock names Nishanth Menon
2020-09-03 13:21 ` Vignesh Raghavendra
2020-09-03 13:00 ` [PATCH V2 5/8] arm64: dts: ti: k3-*: Use generic pinctrl for node names Nishanth Menon
2020-09-03 13:00 ` [PATCH V2 6/8] arm64: dts: ti: k3-am65-base-board Use generic camera for node name instead of ov5640 Nishanth Menon
2020-09-03 13:00 ` [PATCH V2 7/8] arm64: dts: ti: k3-am65-wakeup: Use generic temperature-sensor for node name Nishanth Menon
2020-09-03 13:20 ` Vignesh Raghavendra
2020-09-03 13:00 ` [PATCH V2 8/8] arm64: dts: ti: k3-*: Fix up node_name_chars_strict warnings Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9fb2f8f4-5eeb-6190-9cbf-b28084c58a8f@ti.com \
--to=vigneshr@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=grygorii.strashko@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lokeshvutla@ti.com \
--cc=nm@ti.com \
--cc=nsekhar@ti.com \
--cc=robh+dt@kernel.org \
--cc=s-anna@ti.com \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).