linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCHv2] arm-cci: Do not enable CCI-400 PMU by default
@ 2015-05-12 10:12 Suzuki K. Poulose
  2015-05-18 16:06 ` Punit Agrawal
  0 siblings, 1 reply; 2+ messages in thread
From: Suzuki K. Poulose @ 2015-05-12 10:12 UTC (permalink / raw)
  To: linux-arm-kernel

From: "Suzuki K. Poulose" <suzuki.poulose@arm.com>

Do not enable CCI-400 PMU by default and fix the dependency on PERF_EVENTS
than HW_PERF_EVENTS.

Reported-by: Russell King <rmk+kernel@arm.linux.org.uk>
Cc: Will Deacon <will.deacon@arm.com>
Cc: arm at kernel.org
Cc: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Suzuki K. Poulose <suzuki.poulose@arm.com>
---
Changes since V1:
 - Make CCI400_PMU depend on CPU_V7 for ARM (Suggested by: Russell)
---
 drivers/bus/Kconfig |   12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig
index a1d4af6..a6b37d4 100644
--- a/drivers/bus/Kconfig
+++ b/drivers/bus/Kconfig
@@ -13,15 +13,13 @@ config ARM_CCI400_COMMON
 
 config ARM_CCI400_PMU
 	bool "ARM CCI400 PMU support"
-	default y
-	depends on ARM || ARM64
-	depends on HW_PERF_EVENTS
+	depends on (ARM && CPU_V7) || ARM64
+	depends on PERF_EVENTS
 	select ARM_CCI400_COMMON
 	help
-	  Support for PMU events monitoring on the ARM CCI cache coherent
-	  interconnect.
-
-	  If unsure, say Y
+	  Support for PMU events monitoring on the ARM CCI-400 (cache coherent
+	  interconnect). CCI-400 supports counting events related to the
+	  connected slave/master interfaces.
 
 config ARM_CCI400_PORT_CTRL
 	bool
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCHv2] arm-cci: Do not enable CCI-400 PMU by default
  2015-05-12 10:12 [PATCHv2] arm-cci: Do not enable CCI-400 PMU by default Suzuki K. Poulose
@ 2015-05-18 16:06 ` Punit Agrawal
  0 siblings, 0 replies; 2+ messages in thread
From: Punit Agrawal @ 2015-05-18 16:06 UTC (permalink / raw)
  To: linux-arm-kernel

"Suzuki K. Poulose" <suzuki.poulose@arm.com> writes:

> From: "Suzuki K. Poulose" <suzuki.poulose@arm.com>
>
> Do not enable CCI-400 PMU by default and fix the dependency on PERF_EVENTS
> than HW_PERF_EVENTS.
>
> Reported-by: Russell King <rmk+kernel@arm.linux.org.uk>
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: arm at kernel.org
> Cc: Russell King <rmk+kernel@arm.linux.org.uk>
> Signed-off-by: Suzuki K. Poulose <suzuki.poulose@arm.com>

This seems fine. Assuming Russell has no further comments -

Acked-by: Punit Agrawal <punit.agrawal@arm.com>

> ---
> Changes since V1:
>  - Make CCI400_PMU depend on CPU_V7 for ARM (Suggested by: Russell)
> ---
>  drivers/bus/Kconfig |   12 +++++-------
>  1 file changed, 5 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig
> index a1d4af6..a6b37d4 100644
> --- a/drivers/bus/Kconfig
> +++ b/drivers/bus/Kconfig
> @@ -13,15 +13,13 @@ config ARM_CCI400_COMMON
>  
>  config ARM_CCI400_PMU
>  	bool "ARM CCI400 PMU support"
> -	default y
> -	depends on ARM || ARM64
> -	depends on HW_PERF_EVENTS
> +	depends on (ARM && CPU_V7) || ARM64
> +	depends on PERF_EVENTS
>  	select ARM_CCI400_COMMON
>  	help
> -	  Support for PMU events monitoring on the ARM CCI cache coherent
> -	  interconnect.
> -
> -	  If unsure, say Y
> +	  Support for PMU events monitoring on the ARM CCI-400 (cache coherent
> +	  interconnect). CCI-400 supports counting events related to the
> +	  connected slave/master interfaces.
>  
>  config ARM_CCI400_PORT_CTRL
>  	bool

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-05-18 16:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-12 10:12 [PATCHv2] arm-cci: Do not enable CCI-400 PMU by default Suzuki K. Poulose
2015-05-18 16:06 ` Punit Agrawal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).