* [PATCH V2 0/5] dt-binding: clk: prepare for imx8qm clock support
@ 2019-01-23 8:16 Aisheng Dong
2019-01-23 8:16 ` [PATCH V2 1/5] dt-bindings: fsl: scu: add fallback compatible string for clock Aisheng Dong
` (5 more replies)
0 siblings, 6 replies; 8+ messages in thread
From: Aisheng Dong @ 2019-01-23 8:16 UTC (permalink / raw)
To: linux-clk
Cc: Aisheng Dong, devicetree, sboyd, mturquette, robh+dt,
dl-linux-imx, kernel, Fabio Estevam, shawnguo, linux-arm-kernel
After a bit more investigation on IMX8QM, it seemed SCU clock can be used
in a similar way as IMX8QXP. So update the binding and driver to be a bit
generic for easily extension of IMX8QM support later.
Dong Aisheng (5):
dt-bindings: fsl: scu: add fallback compatible string for clock
dt-bindings: fsl: scu: add imx8qm scu clock support
dt-bindings: clock: update CPU clock ID name
dt-bindings: imx8-clock: add a53 and a72 clock id
clk: imx: scu: add fallback compatible string support
Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt | 7 +++++--
drivers/clk/imx/clk-imx8qxp.c | 1 +
include/dt-bindings/clock/imx8-clock.h | 8 +++++---
3 files changed, 11 insertions(+), 5 deletions(-)
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH V2 1/5] dt-bindings: fsl: scu: add fallback compatible string for clock
2019-01-23 8:16 [PATCH V2 0/5] dt-binding: clk: prepare for imx8qm clock support Aisheng Dong
@ 2019-01-23 8:16 ` Aisheng Dong
2019-01-23 8:16 ` [PATCH V2 2/5] dt-bindings: fsl: scu: add imx8qm scu clock support Aisheng Dong
` (4 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Aisheng Dong @ 2019-01-23 8:16 UTC (permalink / raw)
To: linux-clk
Cc: Aisheng Dong, devicetree, sboyd, mturquette, robh+dt,
dl-linux-imx, kernel, Fabio Estevam, shawnguo, linux-arm-kernel
SCU clock can be used in a similar way by IMX8QXP and IMX8QM SoCs.
Let's add a "fsl,scu-clk" fallback compatible string to allow other
SoCs to reuse the common part.
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <kernel@pengutronix.de>
Cc: Fabio Estevam <fabio.estevam@nxp.com>
Cc: Michael Turquette <mturquette@baylibre.com>
Acked-by: Stephen Boyd <sboyd@kernel.org>
Reviewed-by: Rob Herring <robh@kernel.org>
Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
---
Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
index fd2bed2..6b4e24a 100644
--- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
+++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
@@ -74,7 +74,9 @@ Clock bindings based on SCU Message Protocol
This binding uses the common clock binding[1].
Required properties:
-- compatible: Should be "fsl,imx8qxp-clock".
+- compatible: Should be one of:
+ "fsl,imx8qxp-clock"
+ followed by "fsl,scu-clk"
- #clock-cells: Should be 1. Contains the Clock ID value.
- clocks: List of clock specifiers, must contain an entry for
each required entry in clock-names
@@ -141,7 +143,7 @@ firmware {
&lsio_mu1 1 3>;
clk: clk {
- compatible = "fsl,imx8qxp-clk";
+ compatible = "fsl,imx8qxp-clk", "fsl,scu-clk";
#clock-cells = <1>;
};
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH V2 2/5] dt-bindings: fsl: scu: add imx8qm scu clock support
2019-01-23 8:16 [PATCH V2 0/5] dt-binding: clk: prepare for imx8qm clock support Aisheng Dong
2019-01-23 8:16 ` [PATCH V2 1/5] dt-bindings: fsl: scu: add fallback compatible string for clock Aisheng Dong
@ 2019-01-23 8:16 ` Aisheng Dong
2019-01-23 8:16 ` [PATCH V2 3/5] dt-bindings: clock: update CPU clock ID name Aisheng Dong
` (3 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Aisheng Dong @ 2019-01-23 8:16 UTC (permalink / raw)
To: linux-clk
Cc: Aisheng Dong, devicetree, sboyd, mturquette, robh+dt,
dl-linux-imx, kernel, Fabio Estevam, shawnguo, linux-arm-kernel
Add imx8qm scu clock support
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <kernel@pengutronix.de>
Cc: Fabio Estevam <fabio.estevam@nxp.com>
Cc: Michael Turquette <mturquette@baylibre.com>
Acked-by: Stephen Boyd <sboyd@kernel.org>
Reviewed-by: Rob Herring <robh@kernel.org>
Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
---
Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
index 6b4e24a..72d481c 100644
--- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
+++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
@@ -75,6 +75,7 @@ This binding uses the common clock binding[1].
Required properties:
- compatible: Should be one of:
+ "fsl,imx8qm-clock"
"fsl,imx8qxp-clock"
followed by "fsl,scu-clk"
- #clock-cells: Should be 1. Contains the Clock ID value.
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH V2 3/5] dt-bindings: clock: update CPU clock ID name
2019-01-23 8:16 [PATCH V2 0/5] dt-binding: clk: prepare for imx8qm clock support Aisheng Dong
2019-01-23 8:16 ` [PATCH V2 1/5] dt-bindings: fsl: scu: add fallback compatible string for clock Aisheng Dong
2019-01-23 8:16 ` [PATCH V2 2/5] dt-bindings: fsl: scu: add imx8qm scu clock support Aisheng Dong
@ 2019-01-23 8:16 ` Aisheng Dong
2019-01-23 11:17 ` Aisheng Dong
2019-01-23 8:16 ` [PATCH V2 4/5] dt-bindings: imx8-clock: add a53 and a72 clock id Aisheng Dong
` (2 subsequent siblings)
5 siblings, 1 reply; 8+ messages in thread
From: Aisheng Dong @ 2019-01-23 8:16 UTC (permalink / raw)
To: linux-clk
Cc: Aisheng Dong, devicetree, sboyd, mturquette, robh+dt,
dl-linux-imx, kernel, Fabio Estevam, shawnguo, linux-arm-kernel
Update the CPU clocks to CPU cluster clock.
Cc: Stephen Boyd <sboyd@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <kernel@pengutronix.de>
Cc: Fabio Estevam <fabio.estevam@nxp.com>
Cc: Michael Turquette <mturquette@baylibre.com>
Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
---
include/dt-bindings/clock/imx8-clock.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/dt-bindings/clock/imx8-clock.h b/include/dt-bindings/clock/imx8-clock.h
index 4236818..aa9b9a0 100644
--- a/include/dt-bindings/clock/imx8-clock.h
+++ b/include/dt-bindings/clock/imx8-clock.h
@@ -12,7 +12,7 @@
#define IMX_CLK_DUMMY 0
/* CPU */
-#define IMX_A35_CLK 1
+#define IMX_CPU_CLUSTER_A35_CLK 1
/* LSIO SS */
#define IMX_LSIO_MEM_CLK 2
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH V2 4/5] dt-bindings: imx8-clock: add a53 and a72 clock id
2019-01-23 8:16 [PATCH V2 0/5] dt-binding: clk: prepare for imx8qm clock support Aisheng Dong
` (2 preceding siblings ...)
2019-01-23 8:16 ` [PATCH V2 3/5] dt-bindings: clock: update CPU clock ID name Aisheng Dong
@ 2019-01-23 8:16 ` Aisheng Dong
2019-01-23 8:17 ` [PATCH V2 5/5] clk: imx: scu: add fallback compatible string support Aisheng Dong
2019-01-23 8:19 ` [PATCH V2 0/5] dt-binding: clk: prepare for imx8qm clock support Aisheng Dong
5 siblings, 0 replies; 8+ messages in thread
From: Aisheng Dong @ 2019-01-23 8:16 UTC (permalink / raw)
To: linux-clk
Cc: Aisheng Dong, devicetree, sboyd, mturquette, robh+dt,
dl-linux-imx, kernel, Fabio Estevam, shawnguo, linux-arm-kernel
Add a53 and a72 clock id, as there's still no users, we update
IMX_LSIO_MEM_CLK base to start from 6 to allow a53 and a72 clock
id to be continued with a35 clk.
Cc: Stephen Boyd <sboyd@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <kernel@pengutronix.de>
Cc: Fabio Estevam <fabio.estevam@nxp.com>
Cc: Michael Turquette <mturquette@baylibre.com>
Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
---
v1->v2:
* change cpu clock to cpu cluster clock per Rob's suggestion
---
include/dt-bindings/clock/imx8-clock.h | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/include/dt-bindings/clock/imx8-clock.h b/include/dt-bindings/clock/imx8-clock.h
index aa9b9a0..cb8aeea 100644
--- a/include/dt-bindings/clock/imx8-clock.h
+++ b/include/dt-bindings/clock/imx8-clock.h
@@ -13,10 +13,12 @@
/* CPU */
#define IMX_CPU_CLUSTER_A35_CLK 1
+#define IMX_CPU_CLUSTER_A53_CLK 2
+#define IMX_CPU_CLUSTER_A72_CLK 3
/* LSIO SS */
-#define IMX_LSIO_MEM_CLK 2
-#define IMX_LSIO_BUS_CLK 3
+#define IMX_LSIO_MEM_CLK 6
+#define IMX_LSIO_BUS_CLK 7
#define IMX_LSIO_PWM0_CLK 10
#define IMX_LSIO_PWM1_CLK 11
#define IMX_LSIO_PWM2_CLK 12
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH V2 5/5] clk: imx: scu: add fallback compatible string support
2019-01-23 8:16 [PATCH V2 0/5] dt-binding: clk: prepare for imx8qm clock support Aisheng Dong
` (3 preceding siblings ...)
2019-01-23 8:16 ` [PATCH V2 4/5] dt-bindings: imx8-clock: add a53 and a72 clock id Aisheng Dong
@ 2019-01-23 8:17 ` Aisheng Dong
2019-01-23 8:19 ` [PATCH V2 0/5] dt-binding: clk: prepare for imx8qm clock support Aisheng Dong
5 siblings, 0 replies; 8+ messages in thread
From: Aisheng Dong @ 2019-01-23 8:17 UTC (permalink / raw)
To: linux-clk
Cc: Aisheng Dong, devicetree, sboyd, mturquette, robh+dt,
dl-linux-imx, kernel, Fabio Estevam, shawnguo, linux-arm-kernel
SCU clock can be used in a similar way by IMX8QXP and IMX8QM SoCs.
Make the driver support "fsl,scu-clk" fallback compatible string
to allow other SoCs to reuse the common part.
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <kernel@pengutronix.de>
Cc: Fabio Estevam <fabio.estevam@nxp.com>
Cc: Stephen Boyd <sboyd@kernel.org>
Cc: Michael Turquette <mturquette@baylibre.com>
Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
---
drivers/clk/imx/clk-imx8qxp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/imx/clk-imx8qxp.c b/drivers/clk/imx/clk-imx8qxp.c
index 83e2ef9..5e2903e 100644
--- a/drivers/clk/imx/clk-imx8qxp.c
+++ b/drivers/clk/imx/clk-imx8qxp.c
@@ -138,6 +138,7 @@ static int imx8qxp_clk_probe(struct platform_device *pdev)
}
static const struct of_device_id imx8qxp_match[] = {
+ { .compatible = "fsl,scu-clk", },
{ .compatible = "fsl,imx8qxp-clk", },
{ /* sentinel */ }
};
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 8+ messages in thread
* RE: [PATCH V2 0/5] dt-binding: clk: prepare for imx8qm clock support
2019-01-23 8:16 [PATCH V2 0/5] dt-binding: clk: prepare for imx8qm clock support Aisheng Dong
` (4 preceding siblings ...)
2019-01-23 8:17 ` [PATCH V2 5/5] clk: imx: scu: add fallback compatible string support Aisheng Dong
@ 2019-01-23 8:19 ` Aisheng Dong
5 siblings, 0 replies; 8+ messages in thread
From: Aisheng Dong @ 2019-01-23 8:19 UTC (permalink / raw)
To: linux-clk, shawnguo, Stephen Boyd, robh+dt
Cc: devicetree, mturquette, dl-linux-imx, kernel, Fabio Estevam,
linux-arm-kernel
> From: Aisheng Dong
> Sent: Wednesday, January 23, 2019 4:17 PM
> Subject: [PATCH V2 0/5] dt-binding: clk: prepare for imx8qm clock support
>
> After a bit more investigation on IMX8QM, it seemed SCU clock can be used in
> a similar way as IMX8QXP. So update the binding and driver to be a bit generic
> for easily extension of IMX8QM support later.
>
> Dong Aisheng (5):
> dt-bindings: fsl: scu: add fallback compatible string for clock
> dt-bindings: fsl: scu: add imx8qm scu clock support
Hi Shawn,
Would you pick the first two patches for scu binding doc?
Rob & Stephen,
Please help review the left ones.
Regards
Dong Aisheng
> dt-bindings: clock: update CPU clock ID name
> dt-bindings: imx8-clock: add a53 and a72 clock id
> clk: imx: scu: add fallback compatible string support
>
> Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt | 7 +++++--
> drivers/clk/imx/clk-imx8qxp.c | 1 +
> include/dt-bindings/clock/imx8-clock.h | 8 +++++---
> 3 files changed, 11 insertions(+), 5 deletions(-)
>
> --
> 2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH V2 3/5] dt-bindings: clock: update CPU clock ID name
2019-01-23 8:16 ` [PATCH V2 3/5] dt-bindings: clock: update CPU clock ID name Aisheng Dong
@ 2019-01-23 11:17 ` Aisheng Dong
0 siblings, 0 replies; 8+ messages in thread
From: Aisheng Dong @ 2019-01-23 11:17 UTC (permalink / raw)
To: linux-clk
Cc: devicetree, sboyd, mturquette, robh+dt, dl-linux-imx, kernel,
Fabio Estevam, shawnguo, linux-arm-kernel
> -----Original Message-----
> From: Aisheng Dong
> Sent: Wednesday, January 23, 2019 4:17 PM
> To: linux-clk@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org; sboyd@kernel.org;
> mturquette@baylibre.com; shawnguo@kernel.org; Fabio Estevam
> <fabio.estevam@nxp.com>; dl-linux-imx <linux-imx@nxp.com>;
> kernel@pengutronix.de; robh+dt@kernel.org; devicetree@vger.kernel.org;
> Aisheng Dong <aisheng.dong@nxp.com>
> Subject: [PATCH V2 3/5] dt-bindings: clock: update CPU clock ID name
>
> Update the CPU clocks to CPU cluster clock.
>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: devicetree@vger.kernel.org
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Sascha Hauer <kernel@pengutronix.de>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> ---
> include/dt-bindings/clock/imx8-clock.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/dt-bindings/clock/imx8-clock.h
> b/include/dt-bindings/clock/imx8-clock.h
> index 4236818..aa9b9a0 100644
> --- a/include/dt-bindings/clock/imx8-clock.h
> +++ b/include/dt-bindings/clock/imx8-clock.h
> @@ -12,7 +12,7 @@
> #define IMX_CLK_DUMMY 0
>
> /* CPU */
> -#define IMX_A35_CLK 1
Sorry this one breaks the building as clock driver already use IMX_A35_CLK.
Will update and resend.
Regards
Dong Aisheng
> +#define IMX_CPU_CLUSTER_A35_CLK 1
>
> /* LSIO SS */
> #define IMX_LSIO_MEM_CLK 2
> --
> 2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-01-23 11:17 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-23 8:16 [PATCH V2 0/5] dt-binding: clk: prepare for imx8qm clock support Aisheng Dong
2019-01-23 8:16 ` [PATCH V2 1/5] dt-bindings: fsl: scu: add fallback compatible string for clock Aisheng Dong
2019-01-23 8:16 ` [PATCH V2 2/5] dt-bindings: fsl: scu: add imx8qm scu clock support Aisheng Dong
2019-01-23 8:16 ` [PATCH V2 3/5] dt-bindings: clock: update CPU clock ID name Aisheng Dong
2019-01-23 11:17 ` Aisheng Dong
2019-01-23 8:16 ` [PATCH V2 4/5] dt-bindings: imx8-clock: add a53 and a72 clock id Aisheng Dong
2019-01-23 8:17 ` [PATCH V2 5/5] clk: imx: scu: add fallback compatible string support Aisheng Dong
2019-01-23 8:19 ` [PATCH V2 0/5] dt-binding: clk: prepare for imx8qm clock support Aisheng Dong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).