RE: [PATCH 1/3] dt-bindings: imx: Add pinctrl binding doc for i.MX8MN

From: Aisheng Dong <aisheng.dong@nxp.com>
To: Linus Walleij <linus.walleij@linaro.org>,
	Anson Huang <anson.huang@nxp.com>,
	Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Enric Balletbo i Serra <enric.balletbo@collabora.com>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	Maxime Ripard <maxime.ripard@bootlin.com>,
	Fabio Estevam <festevam@gmail.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Will Deacon <will.deacon@arm.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Stefan Agner <stefan@agner.ch>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Dinh Nguyen <dinguyen@kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	Jagan Teki <jagan@amarulasolutions.com>,
	Sascha Hauer <kernel@pengutronix.de>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Olof Johansson <olof@lixom.net>,
	Simon Horman <horms+renesas@verge.net.au>,
	Leonard Crestez <leonard.crestez@nxp.com>,
	Shawn Guo <shawnguo@kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [PATCH 1/3] dt-bindings: imx: Add pinctrl binding doc for i.MX8MN
Date: Tue, 11 Jun 2019 10:00:36 +0000	[thread overview]
Message-ID: <AM0PR04MB421171336B9206D02FF6514080ED0@AM0PR04MB4211.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <CACRpkdY-35o378Ka+4bgeSPjmq6P8DM872sgTxq2X3dDP9XZHQ@mail.gmail.com>

> From: Linus Walleij [mailto:linus.walleij@linaro.org]
> Sent: Saturday, June 8, 2019 5:04 AM
> 
> On Thu, May 30, 2019 at 5:04 AM <Anson.Huang@nxp.com> wrote:
> 
> > From: Anson Huang <Anson.Huang@nxp.com>
> >
> > Add binding doc for i.MX8MN pinctrl driver.
> >
> > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> 
> Looks mostly OK to me, but I'd like the maintainers to review, so Dong et al
> please look at this!
> 
> > +Required properties:
> > +- compatible: "fsl,imx8mn-iomuxc"
> 
> So should this not be "nxp,imx8mn-iomuxc"
> or "nxp,freescale-imx8mn-iomuxc" or something these days? The vendor name
> is nxp is it not.
> 
> I was complaining to the DT maintainers at one point that these companies
> seem to buy each other left and right so this vendor nomenclature is dubious,
> but I guess at least it should reflect the vendor that produced the chip or
> something.
> 
> If everyone is happy with "fsl,*" I will not complain though.
> (i.e. if the maintainers ACK it.)

We preferred to keep "fsl,*" for Freescale i.MX product line according to last discussion.
And we already did this way for most i.MX devices.

So:
Acked-by: Dong Aisheng <aisheng.dong@nxp.com>

(Rob, please let us know if you have different idea)

Regards
Dong Aisheng

> 
> Yours,
> Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel