From: Aisheng Dong <aisheng.dong@nxp.com>
To: Anson Huang <anson.huang@nxp.com>,
"festevam@gmail.com" <festevam@gmail.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"stefan@agner.ch" <stefan@agner.ch>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
"will.deacon@arm.com" <will.deacon@arm.com>,
"maxime.ripard@bootlin.com" <maxime.ripard@bootlin.com>,
"olof@lixom.net" <olof@lixom.net>,
"horms+renesas@verge.net.au" <horms+renesas@verge.net.au>,
"jagan@amarulasolutions.com" <jagan@amarulasolutions.com>,
Leonard Crestez <leonard.crestez@nxp.com>,
"bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
"dinguyen@kernel.org" <dinguyen@kernel.org>,
"enric.balletbo@collabora.com" <enric.balletbo@collabora.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [PATCH 2/3] pinctrl: freescale: Add i.MX8MN pinctrl driver support
Date: Tue, 11 Jun 2019 10:45:51 +0000 [thread overview]
Message-ID: <AM0PR04MB4211964EA3993A99465D861980ED0@AM0PR04MB4211.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20190530030546.9224-2-Anson.Huang@nxp.com>
> From: Anson.Huang@nxp.com [mailto:Anson.Huang@nxp.com]
> Sent: Thursday, May 30, 2019 11:06 AM
>
> From: Anson Huang <Anson.Huang@nxp.com>
>
> Add the pinctrl driver support for i.MX8MN.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> drivers/pinctrl/freescale/Kconfig | 7 +
> drivers/pinctrl/freescale/Makefile | 1 +
> drivers/pinctrl/freescale/pinctrl-imx8mn.c | 348
> +++++++++++++++++++++++++++++
> 3 files changed, 356 insertions(+)
> create mode 100644 drivers/pinctrl/freescale/pinctrl-imx8mn.c
>
> diff --git a/drivers/pinctrl/freescale/Kconfig b/drivers/pinctrl/freescale/Kconfig
> index aeab0d9..4ff52fa 100644
> --- a/drivers/pinctrl/freescale/Kconfig
> +++ b/drivers/pinctrl/freescale/Kconfig
> @@ -123,6 +123,13 @@ config PINCTRL_IMX7ULP
> help
> Say Y here to enable the imx7ulp pinctrl driver
>
> +config PINCTRL_IMX8MN
Nitpick: this seems should be under imx8mm if in alphabetical order
> + bool "IMX8MN pinctrl driver"
> + depends on ARCH_MXC && ARM64
> + select PINCTRL_IMX
> + help
> + Say Y here to enable the imx8mn pinctrl driver
> +
> config PINCTRL_IMX8MM
> bool "IMX8MM pinctrl driver"
> depends on ARCH_MXC && ARM64
> diff --git a/drivers/pinctrl/freescale/Makefile
> b/drivers/pinctrl/freescale/Makefile
> index 02020a7..18225da 100644
> --- a/drivers/pinctrl/freescale/Makefile
> +++ b/drivers/pinctrl/freescale/Makefile
> @@ -18,6 +18,7 @@ obj-$(CONFIG_PINCTRL_IMX6SX) += pinctrl-imx6sx.o
> obj-$(CONFIG_PINCTRL_IMX6UL) += pinctrl-imx6ul.o
> obj-$(CONFIG_PINCTRL_IMX7D) += pinctrl-imx7d.o
> obj-$(CONFIG_PINCTRL_IMX7ULP) += pinctrl-imx7ulp.o
> +obj-$(CONFIG_PINCTRL_IMX8MN) += pinctrl-imx8mn.o
ditto
> obj-$(CONFIG_PINCTRL_IMX8MM) += pinctrl-imx8mm.o
> obj-$(CONFIG_PINCTRL_IMX8MQ) += pinctrl-imx8mq.o
> obj-$(CONFIG_PINCTRL_IMX8QM) += pinctrl-imx8qm.o
> diff --git a/drivers/pinctrl/freescale/pinctrl-imx8mn.c
> b/drivers/pinctrl/freescale/pinctrl-imx8mn.c
> new file mode 100644
> index 0000000..67161df
> --- /dev/null
> +++ b/drivers/pinctrl/freescale/pinctrl-imx8mn.c
> @@ -0,0 +1,348 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright 2018-2019 NXP
> + */
> +
> +#include <linux/err.h>
> +#include <linux/init.h>
> +#include <linux/of_device.h>
This could be of.h
Otherwise:
Acked-by: Dong Aisheng <aisheng.dong@nxp.com>
Regards
Dong Aisheng
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-11 10:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-30 3:05 [PATCH 1/3] dt-bindings: imx: Add pinctrl binding doc for i.MX8MN Anson.Huang
2019-05-30 3:05 ` [PATCH 2/3] pinctrl: freescale: Add i.MX8MN pinctrl driver support Anson.Huang
2019-06-11 10:45 ` Aisheng Dong [this message]
2019-05-30 3:05 ` [PATCH 3/3] arm64: defconfig: Select CONFIG_PINCTRL_IMX8MN by default Anson.Huang
2019-06-11 10:51 ` Aisheng Dong
2019-06-07 21:04 ` [PATCH 1/3] dt-bindings: imx: Add pinctrl binding doc for i.MX8MN Linus Walleij
2019-06-11 10:00 ` Aisheng Dong
2019-06-12 6:05 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR04MB4211964EA3993A99465D861980ED0@AM0PR04MB4211.eurprd04.prod.outlook.com \
--to=aisheng.dong@nxp.com \
--cc=anson.huang@nxp.com \
--cc=bjorn.andersson@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=enric.balletbo@collabora.com \
--cc=festevam@gmail.com \
--cc=horms+renesas@verge.net.au \
--cc=jagan@amarulasolutions.com \
--cc=kernel@pengutronix.de \
--cc=leonard.crestez@nxp.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@bootlin.com \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stefan@agner.ch \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).