* [PATCH V2 1/2] arm64: dts: imx8mm-evk: add phy-reset-gpios for fec1
@ 2019-10-21 10:19 Peng Fan
2019-10-21 10:19 ` [PATCH V2 2/2] arm64: dts: imx8mn-ddr4-evk: " Peng Fan
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Peng Fan @ 2019-10-21 10:19 UTC (permalink / raw)
To: robh+dt, mark.rutland, shawnguo, s.hauer, kernel, festevam
Cc: devicetree, Peng Fan, Andy Duan, Jacky Bai, Anson Huang,
linux-kernel, dl-linux-imx, Leonard Crestez, Daniel Baluta,
linux-arm-kernel, Jun Li
From: Peng Fan <peng.fan@nxp.com>
We should not rely on bootloader to configure the phy reset.
So introduce phy-reset-gpios property to let Linux handle phy reset
itself.
Signed-off-by: Peng Fan <peng.fan@nxp.com>
Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>
---
V2:
U-Boot->bootloader
Add R-b tag
arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
index faefb7182af1..e4d66f7db09d 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
@@ -80,6 +80,7 @@
pinctrl-0 = <&pinctrl_fec1>;
phy-mode = "rgmii-id";
phy-handle = <ðphy0>;
+ phy-reset-gpios = <&gpio4 22 GPIO_ACTIVE_LOW>;
fsl,magic-packet;
status = "okay";
--
2.16.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH V2 2/2] arm64: dts: imx8mn-ddr4-evk: add phy-reset-gpios for fec1
2019-10-21 10:19 [PATCH V2 1/2] arm64: dts: imx8mm-evk: add phy-reset-gpios for fec1 Peng Fan
@ 2019-10-21 10:19 ` Peng Fan
2019-10-28 6:04 ` [PATCH V2 1/2] arm64: dts: imx8mm-evk: " Shawn Guo
2019-10-31 18:59 ` Leonard Crestez
2 siblings, 0 replies; 6+ messages in thread
From: Peng Fan @ 2019-10-21 10:19 UTC (permalink / raw)
To: robh+dt, mark.rutland, shawnguo, s.hauer, kernel, festevam
Cc: devicetree, Peng Fan, Andy Duan, Jacky Bai, Anson Huang,
linux-kernel, dl-linux-imx, Leonard Crestez, Daniel Baluta,
linux-arm-kernel, Jun Li
From: Peng Fan <peng.fan@nxp.com>
We should not rely on bootloader to configure the phy reset.
So introduce phy-reset-gpios property to let Linux handle phy reset
itself.
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
V2:
U-Boot->bootloader
arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts b/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts
index 1b90faace1d3..761ba0b5d271 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts
@@ -48,6 +48,7 @@
pinctrl-0 = <&pinctrl_fec1>;
phy-mode = "rgmii-id";
phy-handle = <ðphy0>;
+ phy-reset-gpios = <&gpio4 22 GPIO_ACTIVE_LOW>;
fsl,magic-packet;
status = "okay";
--
2.16.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH V2 1/2] arm64: dts: imx8mm-evk: add phy-reset-gpios for fec1
2019-10-21 10:19 [PATCH V2 1/2] arm64: dts: imx8mm-evk: add phy-reset-gpios for fec1 Peng Fan
2019-10-21 10:19 ` [PATCH V2 2/2] arm64: dts: imx8mn-ddr4-evk: " Peng Fan
@ 2019-10-28 6:04 ` Shawn Guo
2019-10-31 18:59 ` Leonard Crestez
2 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2019-10-28 6:04 UTC (permalink / raw)
To: Peng Fan
Cc: mark.rutland, devicetree, Andy Duan, Jacky Bai, Anson Huang,
Daniel Baluta, s.hauer, linux-kernel, robh+dt, dl-linux-imx,
kernel, Leonard Crestez, festevam, linux-arm-kernel, Jun Li
On Mon, Oct 21, 2019 at 10:19:17AM +0000, Peng Fan wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> We should not rely on bootloader to configure the phy reset.
> So introduce phy-reset-gpios property to let Linux handle phy reset
> itself.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>
Applied both, thanks.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH V2 1/2] arm64: dts: imx8mm-evk: add phy-reset-gpios for fec1
2019-10-21 10:19 [PATCH V2 1/2] arm64: dts: imx8mm-evk: add phy-reset-gpios for fec1 Peng Fan
2019-10-21 10:19 ` [PATCH V2 2/2] arm64: dts: imx8mn-ddr4-evk: " Peng Fan
2019-10-28 6:04 ` [PATCH V2 1/2] arm64: dts: imx8mm-evk: " Shawn Guo
@ 2019-10-31 18:59 ` Leonard Crestez
2019-11-01 1:20 ` Peng Fan
2019-11-04 0:51 ` Shawn Guo
2 siblings, 2 replies; 6+ messages in thread
From: Leonard Crestez @ 2019-10-31 18:59 UTC (permalink / raw)
To: Peng Fan, shawnguo
Cc: mark.rutland, devicetree, Andy Duan, Jacky Bai, Anson Huang,
Daniel Baluta, s.hauer, linux-kernel, robh+dt, dl-linux-imx,
kernel, festevam, linux-arm-kernel, Jun Li
On 21.10.2019 13:19, Peng Fan wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> We should not rely on bootloader to configure the phy reset.
> So introduce phy-reset-gpios property to let Linux handle phy reset
> itself.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>
This broke NFS boot for me in next-20191031: board now hangs on DHCP.
It can be fixed by reverting this DT patch or by setting
CONFIG_AT803X_PHY to y instead of m.
Needing a phy module is not a bug but everybody will need to either
adjust .config or build modules into an initramfs somehow.
> ---
>
> V2:
> U-Boot->bootloader
> Add R-b tag
>
> arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> index faefb7182af1..e4d66f7db09d 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> @@ -80,6 +80,7 @@
> pinctrl-0 = <&pinctrl_fec1>;
> phy-mode = "rgmii-id";
> phy-handle = <ðphy0>;
> + phy-reset-gpios = <&gpio4 22 GPIO_ACTIVE_LOW>;
> fsl,magic-packet;
> status = "okay";
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH V2 1/2] arm64: dts: imx8mm-evk: add phy-reset-gpios for fec1
2019-10-31 18:59 ` Leonard Crestez
@ 2019-11-01 1:20 ` Peng Fan
2019-11-04 0:51 ` Shawn Guo
1 sibling, 0 replies; 6+ messages in thread
From: Peng Fan @ 2019-11-01 1:20 UTC (permalink / raw)
To: Leonard Crestez, shawnguo
Cc: mark.rutland, devicetree, Andy Duan, Jacky Bai, Anson Huang,
Daniel Baluta, s.hauer, linux-kernel, robh+dt, dl-linux-imx,
kernel, festevam, linux-arm-kernel, Jun Li
> Subject: Re: [PATCH V2 1/2] arm64: dts: imx8mm-evk: add phy-reset-gpios for
> fec1
>
> On 21.10.2019 13:19, Peng Fan wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > We should not rely on bootloader to configure the phy reset.
> > So introduce phy-reset-gpios property to let Linux handle phy reset
> > itself.
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>
>
> This broke NFS boot for me in next-20191031: board now hangs on DHCP.
>
Sorry for this. I not use sdcard when I did the test.
> It can be fixed by reverting this DT patch or by setting CONFIG_AT803X_PHY
> to y instead of m.
I prefer setting CONFIG_AT803X_PHY.
Thanks,
Peng.
>
> Needing a phy module is not a bug but everybody will need to either
> adjust .config or build modules into an initramfs somehow.
>
> > ---
> >
> > V2:
> > U-Boot->bootloader
> > Add R-b tag
> >
> > arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> > b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> > index faefb7182af1..e4d66f7db09d 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> > @@ -80,6 +80,7 @@
> > pinctrl-0 = <&pinctrl_fec1>;
> > phy-mode = "rgmii-id";
> > phy-handle = <ðphy0>;
> > + phy-reset-gpios = <&gpio4 22 GPIO_ACTIVE_LOW>;
> > fsl,magic-packet;
> > status = "okay";
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH V2 1/2] arm64: dts: imx8mm-evk: add phy-reset-gpios for fec1
2019-10-31 18:59 ` Leonard Crestez
2019-11-01 1:20 ` Peng Fan
@ 2019-11-04 0:51 ` Shawn Guo
1 sibling, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2019-11-04 0:51 UTC (permalink / raw)
To: Leonard Crestez
Cc: mark.rutland, devicetree, Peng Fan, Andy Duan, Jacky Bai,
Anson Huang, Daniel Baluta, s.hauer, linux-kernel, robh+dt,
dl-linux-imx, kernel, festevam, linux-arm-kernel, Jun Li
On Thu, Oct 31, 2019 at 06:59:51PM +0000, Leonard Crestez wrote:
> On 21.10.2019 13:19, Peng Fan wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > We should not rely on bootloader to configure the phy reset.
> > So introduce phy-reset-gpios property to let Linux handle phy reset
> > itself.
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>
>
> This broke NFS boot for me in next-20191031: board now hangs on DHCP.
I dropped both patches for now.
Shawn
>
> It can be fixed by reverting this DT patch or by setting
> CONFIG_AT803X_PHY to y instead of m.
>
> Needing a phy module is not a bug but everybody will need to either
> adjust .config or build modules into an initramfs somehow.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-11-04 0:51 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-21 10:19 [PATCH V2 1/2] arm64: dts: imx8mm-evk: add phy-reset-gpios for fec1 Peng Fan
2019-10-21 10:19 ` [PATCH V2 2/2] arm64: dts: imx8mn-ddr4-evk: " Peng Fan
2019-10-28 6:04 ` [PATCH V2 1/2] arm64: dts: imx8mm-evk: " Shawn Guo
2019-10-31 18:59 ` Leonard Crestez
2019-11-01 1:20 ` Peng Fan
2019-11-04 0:51 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).