From: Leo Li <leoyang.li@nxp.com>
To: Olof Johansson <olof@lixom.net>
Cc: "shawnguo@kernel.org" <shawnguo@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Z.Q. Hou" <zhiqiang.hou@nxp.com>
Subject: RE: [PATCH v4 1/2] arm64: dts: lx2160a: update PCIe nodes to match rev2 silicon
Date: Mon, 12 Sep 2022 20:25:39 +0000 [thread overview]
Message-ID: <AM0PR04MB6289B28243FCBA64CAD110B98F449@AM0PR04MB6289.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <CAOesGMhz8PYNG_bgMX-6gka77k1hJOZUv6xqJRqATaJ6mFbk6A@mail.gmail.com>
> -----Original Message-----
> From: Olof Johansson <olof@lixom.net>
> Sent: Monday, September 12, 2022 2:05 AM
> To: Leo Li <leoyang.li@nxp.com>
> Cc: shawnguo@kernel.org; devicetree@vger.kernel.org;
> robh+dt@kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> kernel@vger.kernel.org; Z.Q. Hou <zhiqiang.hou@nxp.com>
> Subject: Re: [PATCH v4 1/2] arm64: dts: lx2160a: update PCIe nodes to match
> rev2 silicon
>
> Hi,
>
> On Wed, Aug 17, 2022 at 1:26 PM Li Yang <leoyang.li@nxp.com> wrote:
> >
> > The original dts was created based on the non-production rev1 silicon
> > which was only used for evaluation. Update the PCIe nodes to align
> > with the different controller used in production rev2 silicon.
>
> How can I confirm what version of silicon I have on a system?
>
> My non-evaluation commercially purchased system (HoneyComb LX2K) has:
>
> # cat /sys/bus/soc/devices/soc0/revision
> 1.0
This is different from the information I got. If there is still active Rev1.0 system in use, I would agree that we probably need to create a new device tree for the rev2 silicon. Thanks for the information.
>
> And I will be really grumpy if this system stops working. It's what I use to do
> all my maintainer work, even if that's been fairly dormant this year.
>
> It's overall setting off red flags to update an in-place devicetree to a "new
> revision" of silicon instead of adding a new DT for said revision. 2160A has
> been on the market for several years, so it just seems odd to all of the
> sudden retroactively make things non-backwards-compatible.
>
>
>
> -Olof
>
>
>
>
> -Olof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-09-12 20:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-17 20:25 [PATCH v4 0/2] lx216x DTS updates Li Yang
2022-08-17 20:25 ` [PATCH v4 1/2] arm64: dts: lx2160a: update PCIe nodes to match rev2 silicon Li Yang
2022-09-12 7:05 ` Olof Johansson
2022-09-12 18:54 ` Olof Johansson
2022-09-12 20:33 ` Russell King (Oracle)
2022-09-13 2:34 ` Olof Johansson
2022-09-12 20:25 ` Leo Li [this message]
2022-09-13 2:03 ` Shawn Guo
2022-09-12 21:49 ` Leo Li
2022-08-17 20:25 ` [PATCH v4 2/2] arm64: dts: lx2160a: add pcie EP mode nodes Li Yang
2022-08-22 3:35 ` [PATCH v4 0/2] lx216x DTS updates Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR04MB6289B28243FCBA64CAD110B98F449@AM0PR04MB6289.eurprd04.prod.outlook.com \
--to=leoyang.li@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=zhiqiang.hou@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).