From: Aisheng Dong <aisheng.dong@nxp.com>
To: Clark Wang <xiaoning.wang@nxp.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>
Cc: "kernel@pengutronix.de" <kernel@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
dl-linux-imx <linux-imx@nxp.com>,
"sumit.semwal@linaro.org" <sumit.semwal@linaro.org>,
"christian.koenig@amd.com" <christian.koenig@amd.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 01/11] i2c: imx-lpi2c: directly retrun ISR when detect a NACK
Date: Fri, 19 Mar 2021 04:25:44 +0000 [thread overview]
Message-ID: <AM6PR04MB49664AED0BD2246B79C7120980689@AM6PR04MB4966.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20210317065359.3109394-2-xiaoning.wang@nxp.com>
> From: Clark Wang <xiaoning.wang@nxp.com>
> Sent: Wednesday, March 17, 2021 2:54 PM
>
> A NACK flag in ISR means i2c bus error. In such codition, there is no need to do
> read/write operation. It's better to return ISR directly and then stop i2c
> transfer.
>
> Signed-off-by: Gao Pan <pandy.gao@nxp.com>
> Signed-off-by: Clark Wang <xiaoning.wang@nxp.com>
Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com>
Regards
Aisheng
> ---
> drivers/i2c/busses/i2c-imx-lpi2c.c | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-imx-lpi2c.c
> b/drivers/i2c/busses/i2c-imx-lpi2c.c
> index 9db6ccded5e9..bbf44ac95021 100644
> --- a/drivers/i2c/busses/i2c-imx-lpi2c.c
> +++ b/drivers/i2c/busses/i2c-imx-lpi2c.c
> @@ -507,15 +507,17 @@ static irqreturn_t lpi2c_imx_isr(int irq, void *dev_id)
> lpi2c_imx_intctrl(lpi2c_imx, 0);
> temp = readl(lpi2c_imx->base + LPI2C_MSR);
>
> + if (temp & MSR_NDF) {
> + complete(&lpi2c_imx->complete);
> + goto ret;
> + }
> +
> if (temp & MSR_RDF)
> lpi2c_imx_read_rxfifo(lpi2c_imx);
> -
> - if (temp & MSR_TDF)
> + else if (temp & MSR_TDF)
> lpi2c_imx_write_txfifo(lpi2c_imx);
>
> - if (temp & MSR_NDF)
> - complete(&lpi2c_imx->complete);
> -
> +ret:
> return IRQ_HANDLED;
> }
>
> --
> 2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-03-19 4:27 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 6:53 [PATCH 00/11] i2c: imx-lpi2c: New features and bug fixes Clark Wang
2021-03-17 6:53 ` [PATCH 01/11] i2c: imx-lpi2c: directly retrun ISR when detect a NACK Clark Wang
2021-03-19 4:25 ` Aisheng Dong [this message]
2021-03-17 6:53 ` [PATCH 02/11] i2c: imx-lpi2c: add runtime pm support Clark Wang
2021-03-19 4:40 ` Aisheng Dong
2021-03-19 5:33 ` Clark Wang
2021-03-19 6:16 ` Clark Wang
2021-03-19 8:00 ` Clark Wang
2021-03-19 10:26 ` Aisheng Dong
2021-03-17 6:53 ` [PATCH 03/11] i2c: imx-lpi2c: add ipg clk for lpi2c driver Clark Wang
2021-03-19 4:46 ` Aisheng Dong
2021-03-19 6:23 ` Clark Wang
2021-03-19 9:18 ` Aisheng Dong
2021-03-17 6:53 ` [PATCH 04/11] i2c: imx-lpi2c: manage irq resource request/release in runtime pm Clark Wang
2021-03-19 4:53 ` Aisheng Dong
2021-03-19 7:03 ` Clark Wang
2021-03-19 10:12 ` Aisheng Dong
2021-03-17 6:53 ` [PATCH 05/11] i2c: imx-lpi2c: add debug message when i2c peripheral clk doesn't work Clark Wang
2021-03-19 4:56 ` Aisheng Dong
2021-03-19 7:07 ` Clark Wang
2021-03-17 6:53 ` [PATCH 06/11] i2c: imx-lpi2c: improve i2c driver probe priority Clark Wang
2021-03-19 5:05 ` Aisheng Dong
2021-03-19 5:38 ` Wolfram Sang
2021-03-19 7:39 ` [EXT] " Clark Wang
2021-03-17 6:53 ` [PATCH 07/11] i2c: imx-lpi2c: increase PM timeout to avoid operate clk frequently Clark Wang
2021-03-19 5:10 ` Aisheng Dong
2021-03-17 6:53 ` [PATCH 08/11] i2c: imx-lpi2c: add bus recovery feature Clark Wang
2021-03-19 5:11 ` Aisheng Dong
2021-03-17 6:53 ` [PATCH 09/11] i2c: imx-lpi2c: fix i2c timing issue Clark Wang
2021-03-19 5:15 ` Aisheng Dong
2021-03-19 7:21 ` Clark Wang
2021-03-17 6:53 ` [PATCH 10/11] i2c: imx-lpi2c: fix type char overflow issue when calculating the clock cycle Clark Wang
2021-03-19 5:16 ` Aisheng Dong
2021-03-17 6:53 ` [PATCH 11/11] i2c: imx-lpi2c: add edma mode support Clark Wang
2021-03-19 5:28 ` Aisheng Dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM6PR04MB49664AED0BD2246B79C7120980689@AM6PR04MB4966.eurprd04.prod.outlook.com \
--to=aisheng.dong@nxp.com \
--cc=christian.koenig@amd.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=sumit.semwal@linaro.org \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).