From: Ming Qian <ming.qian@nxp.com>
To: Nicolas Dufresne <nicolas@ndufresne.ca>,
Fabio Estevam <festevam@gmail.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
"Mirela Rabulea (OSS)" <mirela.rabulea@oss.nxp.com>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Sascha Hauer <kernel@pengutronix.de>,
dl-linux-imx <linux-imx@nxp.com>,
linux-media <linux-media@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: RE: [EXT] Re: [PATCH v2] media: imx-jpeg: Leave a blank space before the configuration data
Date: Mon, 30 May 2022 02:50:20 +0000 [thread overview]
Message-ID: <AM6PR04MB6341D7DAF3A7E2B14524FFF3E7DD9@AM6PR04MB6341.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <02cbaf49474cbba446b6bdae77d5da950cce3e00.camel@ndufresne.ca>
> From: Nicolas Dufresne <nicolas@ndufresne.ca>
> Sent: 2022年5月28日 3:26
> To: Ming Qian <ming.qian@nxp.com>; Fabio Estevam <festevam@gmail.com>
> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>; Mirela Rabulea (OSS)
> <mirela.rabulea@oss.nxp.com>; Hans Verkuil <hverkuil-cisco@xs4all.nl>;
> Shawn Guo <shawnguo@kernel.org>; Sascha Hauer <s.hauer@pengutronix.de>;
> Sascha Hauer <kernel@pengutronix.de>; dl-linux-imx <linux-imx@nxp.com>;
> linux-media <linux-media@vger.kernel.org>; linux-kernel
> <linux-kernel@vger.kernel.org>; open list:OPEN FIRMWARE AND FLATTENED
> DEVICE TREE BINDINGS <devicetree@vger.kernel.org>; moderated
> list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
> <linux-arm-kernel@lists.infradead.org>
> Subject: Re: [EXT] Re: [PATCH v2] media: imx-jpeg: Leave a blank space before
> the configuration data
>
> Caution: EXT Email
>
> Le vendredi 27 mai 2022 à 11:33 +0000, Ming Qian a écrit :
> > > From: Fabio Estevam <festevam@gmail.com>
> > > Sent: 2022年5月27日 19:12
> > > To: Ming Qian <ming.qian@nxp.com>
> > > Cc: Mauro Carvalho Chehab <mchehab@kernel.org>; Mirela Rabulea (OSS)
> > > <mirela.rabulea@oss.nxp.com>; Hans Verkuil
> > > <hverkuil-cisco@xs4all.nl>; Shawn Guo <shawnguo@kernel.org>; Sascha
> > > Hauer <s.hauer@pengutronix.de>; Sascha Hauer
> > > <kernel@pengutronix.de>; dl-linux-imx <linux-imx@nxp.com>;
> > > linux-media <linux-media@vger.kernel.org>; linux-kernel
> > > <linux-kernel@vger.kernel.org>; open list:OPEN FIRMWARE AND
> > > FLATTENED DEVICE TREE BINDINGS <devicetree@vger.kernel.org>;
> > > moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
> > > <linux-arm-kernel@lists.infradead.org>
> > > Subject: [EXT] Re: [PATCH v2] media: imx-jpeg: Leave a blank space
> > > before the configuration data
> > >
> > > Caution: EXT Email
> > >
> > > Hi Ming,
> > >
> > > On Fri, May 27, 2022 at 7:25 AM Ming Qian <ming.qian@nxp.com> wrote:
> > > >
> > > > There is a hardware bug that it will load the first 128 bytes of
> > > > configuration data twice, it will led to some configure error.
> > > > so shift the configuration data 128 bytes, and make the first 128
> > > > bytes all zero, then hardware will load the 128 zero twice, and
> > > > ignore them as garbage.
> > > > then the configuration data can be loaded correctly
> > > >
> > > > Signed-off-by: Ming Qian <ming.qian@nxp.com>
> > > > Reviewed-by: Mirela Rabulea <mirela.rabulea@nxp.com>
> > > > Reviewed-by: Tommaso Merciai
> > > > <tommaso.merciai@amarulasolutions.com>
> > >
> > > Fixes tag?
> >
> > Hi Fabio,
> > It's a hardware issue, so I'm not sure is it a driver issue that I fix it.
> > Or I just check which patch includes the code I changed, and add
> > the fix tag?
>
> You can use Fixes tag even though there was no software bug. The point of the
> tag is to help locate how far we can backport this patch in order to let stable
> kernel users benefit.
>
> regards,
> Nicolas
>
Hi Nicolas,
Thanks for your information, I'll add a fix tag in v3.
Ming.
> >
> > Ming
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-05-30 2:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-27 10:24 [PATCH v2] media: imx-jpeg: Leave a blank space before the configuration data Ming Qian
2022-05-27 10:28 ` Tommaso Merciai
2022-05-27 11:11 ` Fabio Estevam
2022-05-27 11:33 ` [EXT] " Ming Qian
2022-05-27 19:26 ` Nicolas Dufresne
2022-05-30 2:50 ` Ming Qian [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM6PR04MB6341D7DAF3A7E2B14524FFF3E7DD9@AM6PR04MB6341.eurprd04.prod.outlook.com \
--to=ming.qian@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mirela.rabulea@oss.nxp.com \
--cc=nicolas@ndufresne.ca \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).