From: Daniel Kiss <Daniel.Kiss@arm.com>
To: James Clark <James.Clark@arm.com>
Cc: "mathieu.poirier@linaro.org" <mathieu.poirier@linaro.org>,
Suzuki Poulose <Suzuki.Poulose@arm.com>,
"mike.leach@linaro.org" <mike.leach@linaro.org>,
"leo.yan@linaro.org" <leo.yan@linaro.org>,
"coresight@lists.linaro.org" <coresight@lists.linaro.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
"denik@google.com" <denik@google.com>
Subject: Re: [PATCH 0/4] coresight: Add ETR-PERF polling.
Date: Wed, 28 Apr 2021 11:52:44 +0000 [thread overview]
Message-ID: <C11AC98E-1AD6-4CCC-B283-51EBA6523ED4@arm.com> (raw)
In-Reply-To: <df3bcfcb-eacf-7807-6c26-e4b94bce80d3@arm.com>
> On 27 Apr 2021, at 18:24, James Clark <James.Clark@arm.com> wrote:
>
>
>
> On 21/04/2021 15:04, Daniel Kiss wrote:
>> This series adds a feature to ETR-PERF that sync the ETR buffer to perf
>> periodically. This is really handy when the system wide trace is used
>> because in this case the perf won't sync during the trace. In a per-thread
>> setup the traced program might not go to the kernel frequvently enought
>> to collect trace. Polling helps in both usecases. Can be used with strobing.
>> Tuning polling period is challanging, I'm working on an additional patch
>> that adds some metrics to help tune the polling period.
>
> Hi Daniel,
>
> Is the expectation that leaving the polling period at 0 should have no affect
> on the amount of data collected vs not using this patch?
>
> I've been running the octane 2 benchmark on Chrome on Juno and get these results:
>
> No patch: I consistently get 130MB of trace across dozens of runs.
> Patch, polling = 0: Run 1 - 6.1MB
> Run 2 - 4.7MB
> Patch, polling = 100: 1600MB
Polling = 0 should not change the behaviour.
We noticed this too, which is a bug.
I’m going to drop the "coresight: tmc-etr: Track perf handler.” patch, because it causes it.
Seems the csdev->refcnt and drvdata->perf_handle are out of sync
Thanks,
Daniel
> Thanks
> James
>
>>
>> Daniel Kiss (4):
>> coresight: tmc-etr: Advance buffer pointer in sync buffer.
>> coresight: tmc-etr: Track perf handler.
>> coresight: etm-perf: Export etm_event_cpu_path.
>> coresight: Add ETR-PERF polling.
>>
>> .../testing/sysfs-bus-coresight-devices-tmc | 8 +
>> drivers/hwtracing/coresight/Makefile | 2 +-
>> .../hwtracing/coresight/coresight-etm-perf.c | 10 +-
>> .../hwtracing/coresight/coresight-etm-perf.h | 1 +
>> .../coresight/coresight-etr-perf-polling.c | 316 ++++++++++++++++++
>> .../coresight/coresight-etr-perf-polling.h | 42 +++
>> .../hwtracing/coresight/coresight-tmc-core.c | 2 +
>> .../hwtracing/coresight/coresight-tmc-etr.c | 22 +-
>> drivers/hwtracing/coresight/coresight-tmc.h | 2 +
>> 9 files changed, 401 insertions(+), 4 deletions(-)
>> create mode 100644 drivers/hwtracing/coresight/coresight-etr-perf-polling.c
>> create mode 100644 drivers/hwtracing/coresight/coresight-etr-perf-polling.h
>>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-04-28 11:55 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 12:04 [PATCH 0/4] coresight: Add ETR-PERF polling Daniel Kiss
2021-04-21 12:04 ` [PATCH 1/4] coresight: tmc-etr: Advance buffer pointer in sync buffer Daniel Kiss
2021-04-23 8:23 ` Leo Yan
2021-04-26 10:40 ` Suzuki K Poulose
2021-04-27 3:45 ` Leo Yan
2021-04-27 10:00 ` Suzuki K Poulose
2021-04-28 2:34 ` Leo Yan
2021-04-21 12:04 ` [PATCH 2/4] coresight: tmc-etr: Track perf handler Daniel Kiss
2021-04-23 9:20 ` Leo Yan
2021-04-26 0:25 ` Leo Yan
2021-04-21 12:04 ` [PATCH 3/4] coresight: etm-perf: Export etm_event_cpu_path Daniel Kiss
2021-04-21 12:04 ` [PATCH 4/4] coresight: Add ETR-PERF polling Daniel Kiss
2021-04-26 1:18 ` Leo Yan
2021-05-05 7:21 ` Denis Nikitin
2021-04-26 17:54 ` [PATCH 0/4] " Mathieu Poirier
2021-04-27 10:43 ` Al Grant
2021-04-27 14:41 ` Mike Leach
2021-04-27 15:47 ` Mathieu Poirier
2021-04-27 16:04 ` Leo Yan
2021-05-05 6:46 ` Denis Nikitin
2021-05-05 15:29 ` Mathieu Poirier
2021-05-14 9:02 ` Denis Nikitin
2021-05-14 16:16 ` Mike Leach
2021-05-18 14:00 ` Leo Yan
2021-05-18 14:14 ` Leo Yan
2021-05-18 15:41 ` Mathieu Poirier
2021-05-26 6:47 ` Denis Nikitin
2021-05-23 8:45 ` Leo Yan
2021-05-27 7:50 ` Denis Nikitin
2021-05-27 15:07 ` Leo Yan
2021-05-27 16:22 ` Denis Nikitin
2021-05-28 16:37 ` Leo Yan
2021-04-27 16:24 ` James Clark
2021-04-28 11:30 ` James Clark
2021-04-28 11:52 ` Daniel Kiss [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C11AC98E-1AD6-4CCC-B283-51EBA6523ED4@arm.com \
--to=daniel.kiss@arm.com \
--cc=James.Clark@arm.com \
--cc=Suzuki.Poulose@arm.com \
--cc=coresight@lists.linaro.org \
--cc=denik@google.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).