[PATCH 0/4] media: Drop empty platform remove functions

[PATCH 0/4] media: Drop empty platform remove functions

[Uwe Kleine-König]

Hello,

this series removes all platform remove functions that only return zero
below drivers/media. There is no reason to have these, as the only
caller is platform core code doing:

        if (drv->remove) {
                int ret = drv->remove(dev);

                if (ret)
                        dev_warn(...)
        }

(in platform_remove()) and so having no remove function is both
equivalent and simpler.

Uwe Kleine-König (4):
  media: ti/davinci: vpbe_osd: Drop empty platform remove function
  media: ti/davinci: vpbe_venc: Drop empty platform remove function
  media: rc/ir-rx51: Drop empty platform remove function
  media: chips-media/imx-vdoa: Drop empty platform remove function

 drivers/media/platform/chips-media/imx-vdoa.c | 6 ------
 drivers/media/platform/ti/davinci/vpbe_osd.c  | 6 ------
 drivers/media/platform/ti/davinci/vpbe_venc.c | 6 ------
 drivers/media/rc/ir-rx51.c                    | 6 ------
 4 files changed, 24 deletions(-)


base-commit: 830b3c68c1fb1e9176028d02ef86f3cf76aa2476
-- 
2.38.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 4/4] media: chips-media/imx-vdoa: Drop empty platform remove function

[Uwe Kleine-König]

A remove callback just returning 0 is equivalent to no remove callback
at all. So drop the useless function.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 drivers/media/platform/chips-media/imx-vdoa.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/media/platform/chips-media/imx-vdoa.c b/drivers/media/platform/chips-media/imx-vdoa.c
index c70871bae193..c3561fcecb98 100644
--- a/drivers/media/platform/chips-media/imx-vdoa.c
+++ b/drivers/media/platform/chips-media/imx-vdoa.c
@@ -324,11 +324,6 @@ static int vdoa_probe(struct platform_device *pdev)
 	return 0;
 }
 
-static int vdoa_remove(struct platform_device *pdev)
-{
-	return 0;
-}
-
 static const struct of_device_id vdoa_dt_ids[] = {
 	{ .compatible = "fsl,imx6q-vdoa" },
 	{}
@@ -337,7 +332,6 @@ MODULE_DEVICE_TABLE(of, vdoa_dt_ids);
 
 static struct platform_driver vdoa_driver = {
 	.probe		= vdoa_probe,
-	.remove		= vdoa_remove,
 	.driver		= {
 		.name	= VDOA_NAME,
 		.of_match_table = vdoa_dt_ids,
-- 
2.38.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 0/4] media: Drop empty platform remove functions

[Uwe Kleine-König]

[-- Attachment #1.1: Type: text/plain, Size: 777 bytes --]

Hello,

On Tue, Dec 13, 2022 at 04:35:49PM +0100, Uwe Kleine-König wrote:
> this series removes all platform remove functions that only return zero
> below drivers/media. There is no reason to have these, as the only
> caller is platform core code doing:
> 
>         if (drv->remove) {
>                 int ret = drv->remove(dev);
> 
>                 if (ret)
>                         dev_warn(...)
>         }
> 
> (in platform_remove()) and so having no remove function is both
> equivalent and simpler.

I didn't get any feedback in reply to this series yet. Gentle ping!

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 484 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 0/4] media: Drop empty platform remove functions

[Sean Young]

On Thu, Jan 12, 2023 at 10:59:55PM +0100, Uwe Kleine-König wrote:
> Hello,
> 
> On Tue, Dec 13, 2022 at 04:35:49PM +0100, Uwe Kleine-König wrote:
> > this series removes all platform remove functions that only return zero
> > below drivers/media. There is no reason to have these, as the only
> > caller is platform core code doing:
> > 
> >         if (drv->remove) {
> >                 int ret = drv->remove(dev);
> > 
> >                 if (ret)
> >                         dev_warn(...)
> >         }
> > 
> > (in platform_remove()) and so having no remove function is both
> > equivalent and simpler.
> 
> I didn't get any feedback in reply to this series yet. Gentle ping!

I've sent the the ir-rx51.c patch to Mauro on the 30th of december to
pull. He will probably merge it at some point but who knows when.


Sean

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 0/4] media: Drop empty platform remove functions

[Lad, Prabhakar]

Hi Uwe,

On Tue, Dec 13, 2022 at 3:36 PM Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
>
> Hello,
>
> this series removes all platform remove functions that only return zero
> below drivers/media. There is no reason to have these, as the only
> caller is platform core code doing:
>
>         if (drv->remove) {
>                 int ret = drv->remove(dev);
>
>                 if (ret)
>                         dev_warn(...)
>         }
>
> (in platform_remove()) and so having no remove function is both
> equivalent and simpler.
>
> Uwe Kleine-König (4):
>   media: ti/davinci: vpbe_osd: Drop empty platform remove function
>   media: ti/davinci: vpbe_venc: Drop empty platform remove function
Ive reviewed the above two patches. I believe Hans will pick this up
soon for v6.3.

Cheers,
Prabhakar


>   media: rc/ir-rx51: Drop empty platform remove function
>   media: chips-media/imx-vdoa: Drop empty platform remove function
>
>  drivers/media/platform/chips-media/imx-vdoa.c | 6 ------
>  drivers/media/platform/ti/davinci/vpbe_osd.c  | 6 ------
>  drivers/media/platform/ti/davinci/vpbe_venc.c | 6 ------
>  drivers/media/rc/ir-rx51.c                    | 6 ------
>  4 files changed, 24 deletions(-)
>
>
> base-commit: 830b3c68c1fb1e9176028d02ef86f3cf76aa2476
> --
> 2.38.1
>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 0/4] media: Drop empty platform remove functions

[Lad, Prabhakar]

Hi Uwe,

On Fri, Jan 13, 2023 at 8:39 AM Lad, Prabhakar
<prabhakar.csengg@gmail.com> wrote:
>
> Hi Uwe,
>
> On Tue, Dec 13, 2022 at 3:36 PM Uwe Kleine-König
> <u.kleine-koenig@pengutronix.de> wrote:
> >
> > Hello,
> >
> > this series removes all platform remove functions that only return zero
> > below drivers/media. There is no reason to have these, as the only
> > caller is platform core code doing:
> >
> >         if (drv->remove) {
> >                 int ret = drv->remove(dev);
> >
> >                 if (ret)
> >                         dev_warn(...)
> >         }
> >
> > (in platform_remove()) and so having no remove function is both
> > equivalent and simpler.
> >
> > Uwe Kleine-König (4):
> >   media: ti/davinci: vpbe_osd: Drop empty platform remove function
> >   media: ti/davinci: vpbe_venc: Drop empty platform remove function
> Ive reviewed the above two patches. I believe Hans will pick this up
> soon for v6.3.
>
I totally forgot davinci drivers are being dropped now [0].

[0] https://lore.kernel.org/lkml/20221019152947.3857217-15-arnd@kernel.org/

Cheers,
Prabhakar

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel