[PATCH] media: ov5695: Add suport for registering sensor-related

[PATCH] media: ov5695: Add suport for registering sensor-related

[Dongchun Zhu]

Hello,

This series modifies the interface of async register V4L2 sub-device invoked in probe function for OV5695 CMOS sensor.
The Omnivision OV5695 image sensor would be used in camera features on CrOS application.
5.0 Mega Pixel MIPI Camera Mdoule also supports auto-focus control (AFC) with embedded AF VCM Driver.

Here we use v4l2_async_register_subdev_sensor_common() instead of v4l2_async_register_subdev()
to register a sensor sub-device to the asynchronous sub-device framework and parse set up
common sensor-related devices, such as actuator.

This function is just like v4l2_async_register_subdev() with the exception that calling it will also parse
firmware interfaces for remote references using v4l2_async_notifier_parse_fwnode_sensor_common()
and registers the async sub-devices.

After applying this change, we can see the VCM move when changing the scene.

Dongchun Zhu (1):
  media: i2c: ov5695: Modify the function of async register subdev

 drivers/media/i2c/ov5695.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.9.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH] media: i2c: ov5695: Modify the function of async register subdev related devices

[Dongchun Zhu]

This patch adds support for registering a sensor sub-device to the async sub-device framework and parse set up common
sensor related devices such as actuator/VCM.

Signed-off-by: Dongchun Zhu <dongchun.zhu@mediatek.com>
---
 drivers/media/i2c/ov5695.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/i2c/ov5695.c b/drivers/media/i2c/ov5695.c
index e65a943..b6ee62c 100644
--- a/drivers/media/i2c/ov5695.c
+++ b/drivers/media/i2c/ov5695.c
@@ -1328,7 +1328,7 @@ static int ov5695_probe(struct i2c_client *client,
 		goto err_power_off;
 #endif
 
-	ret = v4l2_async_register_subdev(sd);
+	ret = v4l2_async_register_subdev_sensor_common(sd);
 	if (ret) {
 		dev_err(dev, "v4l2 async register subdev failed\n");
 		goto err_clean_entity;
-- 
2.9.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] media: ov5695: Add suport for registering sensor-related

[Andy Shevchenko]

On Fri, Sep 27, 2019 at 03:18:23PM +0800, Dongchun Zhu wrote:
> Hello,
> 
> This series modifies the interface of async register V4L2 sub-device invoked in probe function for OV5695 CMOS sensor.
> The Omnivision OV5695 image sensor would be used in camera features on CrOS application.
> 5.0 Mega Pixel MIPI Camera Mdoule also supports auto-focus control (AFC) with embedded AF VCM Driver.
> 
> Here we use v4l2_async_register_subdev_sensor_common() instead of v4l2_async_register_subdev()
> to register a sensor sub-device to the asynchronous sub-device framework and parse set up
> common sensor-related devices, such as actuator.
> 
> This function is just like v4l2_async_register_subdev() with the exception that calling it will also parse
> firmware interfaces for remote references using v4l2_async_notifier_parse_fwnode_sensor_common()
> and registers the async sub-devices.
> 
> After applying this change, we can see the VCM move when changing the scene.

When you derive Cc list, set some threshold to the get_maintainer.pl, like

	scripts/get_maintainer.pl --git --git-min-percent=67

-- 
With Best Regards,
Andy Shevchenko



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] media: i2c: ov5695: Modify the function of async register subdev related devices

[Tomasz Figa]

On Fri, Sep 27, 2019 at 4:18 PM Dongchun Zhu <dongchun.zhu@mediatek.com> wrote:
>
> This patch adds support for registering a sensor sub-device to the async sub-device framework and parse set up common
> sensor related devices such as actuator/VCM.

nit: The description should be wrapped around the 80th column.

Sakari, do we need to resent or you could just rewrap when applying?

>
> Signed-off-by: Dongchun Zhu <dongchun.zhu@mediatek.com>
> ---
>  drivers/media/i2c/ov5695.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/ov5695.c b/drivers/media/i2c/ov5695.c
> index e65a943..b6ee62c 100644
> --- a/drivers/media/i2c/ov5695.c
> +++ b/drivers/media/i2c/ov5695.c
> @@ -1328,7 +1328,7 @@ static int ov5695_probe(struct i2c_client *client,
>                 goto err_power_off;
>  #endif
>
> -       ret = v4l2_async_register_subdev(sd);
> +       ret = v4l2_async_register_subdev_sensor_common(sd);
>         if (ret) {
>                 dev_err(dev, "v4l2 async register subdev failed\n");
>                 goto err_clean_entity;
> --
> 2.9.2
>

Otherwise:

Reviewed-by: Tomasz Figa <tfiga@chromium.org>

Best regards,
Tomasz

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel