From: Joel Stanley <joel@jms.id.au>
To: Andrew Jeffery <andrew@aj.id.au>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree <devicetree@vger.kernel.org>,
Ryan Chen <ryan_chen@aspeedtech.com>,
linux-aspeed@lists.ozlabs.org,
Linus Walleij <linus.walleij@linaro.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-gpio@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
OpenBMC Maillist <openbmc@lists.ozlabs.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/8] dt-bindings: pinctrl: aspeed: Split bindings document in two
Date: Thu, 27 Jun 2019 04:07:03 +0000 [thread overview]
Message-ID: <CACPK8Xd3Cf8zRSTLVbcTQTu+4aEp1qhmkaFAF4AcfJMkky3gYQ@mail.gmail.com> (raw)
In-Reply-To: <226afe63-cc86-4920-abc1-025bdda32063@www.fastmail.com>
On Thu, 27 Jun 2019 at 04:02, Andrew Jeffery <andrew@aj.id.au> wrote:
>
>
>
> On Thu, 27 Jun 2019, at 13:02, Joel Stanley wrote:
> > On Wed, 26 Jun 2019 at 07:15, Andrew Jeffery <andrew@aj.id.au> wrote:
> > >
> > > Have one for each of the AST2400 and AST2500. The only thing that was
> > > common was the fact that both support ASPEED BMC SoCs.
> > >
> > > Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
> > > ---
> > > .../pinctrl/aspeed,ast2400-pinctrl.txt | 80 +++++++++++++++++++
> > > ...-aspeed.txt => aspeed,ast2500-pinctrl.txt} | 63 ++-------------
> > > 2 files changed, 85 insertions(+), 58 deletions(-)
> > > create mode 100644 Documentation/devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.txt
> > > rename Documentation/devicetree/bindings/pinctrl/{pinctrl-aspeed.txt => aspeed,ast2500-pinctrl.txt} (66%)
> > >
> > > diff --git a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.txt
> > > new file mode 100644
> > > index 000000000000..67e0325ccf2e
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.txt
> > > @@ -0,0 +1,80 @@
> > > +=============================
> > > +Aspeed AST2400 Pin Controller
> > > +=============================
> > > +
> > > +Required properties for the AST2400:
> > > +- compatible : Should be one of the following:
> > > + "aspeed,ast2400-pinctrl"
> > > + "aspeed,g4-pinctrl"
> > > +
> > > +The pin controller node should be the child of a syscon node with the required
> > > +property:
> > > +
> > > +- compatible : Should be one of the following:
> > > + "aspeed,ast2400-scu", "syscon", "simple-mfd"
> > > + "aspeed,g4-scu", "syscon", "simple-mfd"
> >
> > I think we can use this as an opportunity to drop the unused g4-scu
> > compatible from the bindings. Similarly for the g5.
>
> I Wonder if we should eradicate that pattern for all the aspeed compatibles?
Yes. We've settled on ast2x00,aspeed-<foo> for most of them. If you're
aware of others we should remove them from the bindings.
I think we've stopped any new users of the gx style from getting merged.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-27 5:19 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-26 7:14 [PATCH 0/8] pinctrl: aspeed: Preparation for AST2600 Andrew Jeffery
2019-06-26 7:14 ` [PATCH 1/8] dt-bindings: pinctrl: aspeed: Split bindings document in two Andrew Jeffery
2019-06-27 3:32 ` Joel Stanley
2019-06-27 4:02 ` Andrew Jeffery
2019-06-27 4:07 ` Joel Stanley [this message]
2019-06-27 11:26 ` Linus Walleij
2019-06-28 1:01 ` Andrew Jeffery
2019-06-26 7:14 ` [PATCH 2/8] dt-bindings: pinctrl: aspeed: Convert AST2400 bindings to json-schema Andrew Jeffery
2019-06-26 13:47 ` Rob Herring
2019-06-27 0:44 ` Andrew Jeffery
2019-06-27 14:09 ` Rob Herring
2019-06-28 0:47 ` Andrew Jeffery
2019-06-27 3:55 ` Andrew Jeffery
2019-06-27 14:32 ` Rob Herring
2019-06-28 0:56 ` Andrew Jeffery
2019-06-26 7:14 ` [PATCH 3/8] dt-bindings: pinctrl: aspeed: Convert AST2500 " Andrew Jeffery
2019-06-26 7:14 ` [PATCH 4/8] MAINTAINERS: Add entry for ASPEED pinctrl drivers Andrew Jeffery
2019-06-26 7:14 ` [PATCH 5/8] pinctrl: aspeed: Correct comment that is no longer true Andrew Jeffery
2019-06-27 3:30 ` Joel Stanley
2019-06-27 3:57 ` Andrew Jeffery
2019-06-26 7:14 ` [PATCH 6/8] pinctrl: aspeed: Clarify comment about strapping W1C Andrew Jeffery
2019-06-27 3:33 ` Joel Stanley
2019-06-26 7:14 ` [PATCH 7/8] pinctrl: aspeed: Split out pinmux from general pinctrl Andrew Jeffery
2019-06-26 7:14 ` [PATCH 8/8] pinctrl: aspeed: Add implementation-related documentation Andrew Jeffery
2019-06-26 7:54 ` [PATCH 0/8] pinctrl: aspeed: Preparation for AST2600 Linus Walleij
2019-06-27 1:08 ` Andrew Jeffery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACPK8Xd3Cf8zRSTLVbcTQTu+4aEp1qhmkaFAF4AcfJMkky3gYQ@mail.gmail.com \
--to=joel@jms.id.au \
--cc=andrew@aj.id.au \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=ryan_chen@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).