linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Joel Stanley <joel@jms.id.au>
To: Andrew Jeffery <andrew@aj.id.au>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree <devicetree@vger.kernel.org>,
	Ryan Chen <ryan_chen@aspeedtech.com>,
	linux-aspeed@lists.ozlabs.org,
	Linus Walleij <linus.walleij@linaro.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-gpio@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	OpenBMC Maillist <openbmc@lists.ozlabs.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 6/8] pinctrl: aspeed: Clarify comment about strapping W1C
Date: Thu, 27 Jun 2019 03:33:26 +0000	[thread overview]
Message-ID: <CACPK8Xf2xvQAm8sad-xTt_yNO0-ed+PG8mVDujS8EsXzZw4J0A@mail.gmail.com> (raw)
In-Reply-To: <20190626071430.28556-7-andrew@aj.id.au>

On Wed, 26 Jun 2019 at 07:16, Andrew Jeffery <andrew@aj.id.au> wrote:
>
> Writes of 1 to SCU7C clear set bits in SCU70, the hardware strapping
> register. The information was correct if you squinted while reading, but
> hopefully switching the order of the registers as listed conveys it
> better.
>
> Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

Acked-by: Joel Stanley <joel@jms.id.au>

> ---
>  drivers/pinctrl/aspeed/pinctrl-aspeed.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/aspeed/pinctrl-aspeed.c b/drivers/pinctrl/aspeed/pinctrl-aspeed.c
> index 4c775b8ffdc4..b510bb475851 100644
> --- a/drivers/pinctrl/aspeed/pinctrl-aspeed.c
> +++ b/drivers/pinctrl/aspeed/pinctrl-aspeed.c
> @@ -209,7 +209,7 @@ static int aspeed_sig_expr_set(const struct aspeed_sig_expr *expr,
>                 if (desc->ip == ASPEED_IP_SCU && desc->reg == HW_STRAP2)
>                         continue;
>
> -               /* On AST2500, Set bits in SCU7C are cleared from SCU70 */
> +               /* On AST2500, Set bits in SCU70 are cleared from SCU7C */
>                 if (desc->ip == ASPEED_IP_SCU && desc->reg == HW_STRAP1) {
>                         unsigned int rev_id;
>
> --
> 2.20.1
>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-06-27  6:45 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-26  7:14 [PATCH 0/8] pinctrl: aspeed: Preparation for AST2600 Andrew Jeffery
2019-06-26  7:14 ` [PATCH 1/8] dt-bindings: pinctrl: aspeed: Split bindings document in two Andrew Jeffery
2019-06-27  3:32   ` Joel Stanley
2019-06-27  4:02     ` Andrew Jeffery
2019-06-27  4:07       ` Joel Stanley
2019-06-27 11:26     ` Linus Walleij
2019-06-28  1:01       ` Andrew Jeffery
2019-06-26  7:14 ` [PATCH 2/8] dt-bindings: pinctrl: aspeed: Convert AST2400 bindings to json-schema Andrew Jeffery
2019-06-26 13:47   ` Rob Herring
2019-06-27  0:44     ` Andrew Jeffery
2019-06-27 14:09       ` Rob Herring
2019-06-28  0:47         ` Andrew Jeffery
2019-06-27  3:55     ` Andrew Jeffery
2019-06-27 14:32       ` Rob Herring
2019-06-28  0:56         ` Andrew Jeffery
2019-06-26  7:14 ` [PATCH 3/8] dt-bindings: pinctrl: aspeed: Convert AST2500 " Andrew Jeffery
2019-06-26  7:14 ` [PATCH 4/8] MAINTAINERS: Add entry for ASPEED pinctrl drivers Andrew Jeffery
2019-06-26  7:14 ` [PATCH 5/8] pinctrl: aspeed: Correct comment that is no longer true Andrew Jeffery
2019-06-27  3:30   ` Joel Stanley
2019-06-27  3:57     ` Andrew Jeffery
2019-06-26  7:14 ` [PATCH 6/8] pinctrl: aspeed: Clarify comment about strapping W1C Andrew Jeffery
2019-06-27  3:33   ` Joel Stanley [this message]
2019-06-26  7:14 ` [PATCH 7/8] pinctrl: aspeed: Split out pinmux from general pinctrl Andrew Jeffery
2019-06-26  7:14 ` [PATCH 8/8] pinctrl: aspeed: Add implementation-related documentation Andrew Jeffery
2019-06-26  7:54 ` [PATCH 0/8] pinctrl: aspeed: Preparation for AST2600 Linus Walleij
2019-06-27  1:08   ` Andrew Jeffery

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACPK8Xf2xvQAm8sad-xTt_yNO0-ed+PG8mVDujS8EsXzZw4J0A@mail.gmail.com \
    --to=joel@jms.id.au \
    --cc=andrew@aj.id.au \
    --cc=devicetree@vger.kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=openbmc@lists.ozlabs.org \
    --cc=robh+dt@kernel.org \
    --cc=ryan_chen@aspeedtech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).