* [PATCH v1 1/1] pinctrl: st: Switch to use fwnode instead of of_node
@ 2022-10-10 7:56 Andy Shevchenko
2022-10-10 17:59 ` Dmitry Torokhov
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Andy Shevchenko @ 2022-10-10 7:56 UTC (permalink / raw)
To: Andy Shevchenko, Linus Walleij, linux-arm-kernel, linux-gpio,
linux-kernel
Cc: Patrice Chotard, Dmitry Torokhov
The OF node in the GPIO library is deprecated and soon
will be removed.
GPIO library now accepts fwnode as a firmware node, so
switch the driver to use it.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/pinctrl/pinctrl-st.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
index cf7f9cbe6044..987878c83349 100644
--- a/drivers/pinctrl/pinctrl-st.c
+++ b/drivers/pinctrl/pinctrl-st.c
@@ -1175,7 +1175,7 @@ static int st_pctl_dt_calculate_pin(struct st_pinctrl *info,
for (i = 0; i < info->nbanks; i++) {
chip = &info->banks[i].gpio_chip;
- if (chip->of_node == np) {
+ if (chip->fwnode == of_fwnode_handle(np)) {
if (offset < chip->ngpio)
retval = chip->base + offset;
break;
@@ -1518,7 +1518,7 @@ static int st_gpiolib_register_bank(struct st_pinctrl *info,
bank->gpio_chip = st_gpio_template;
bank->gpio_chip.base = bank_num * ST_GPIO_PINS_PER_BANK;
bank->gpio_chip.ngpio = ST_GPIO_PINS_PER_BANK;
- bank->gpio_chip.of_node = np;
+ bank->gpio_chip.fwnode = of_fwnode_handle(np);
bank->gpio_chip.parent = dev;
spin_lock_init(&bank->lock);
--
2.35.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v1 1/1] pinctrl: st: Switch to use fwnode instead of of_node
2022-10-10 7:56 [PATCH v1 1/1] pinctrl: st: Switch to use fwnode instead of of_node Andy Shevchenko
@ 2022-10-10 17:59 ` Dmitry Torokhov
2022-10-11 6:23 ` Patrice CHOTARD
2022-10-17 10:11 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Dmitry Torokhov @ 2022-10-10 17:59 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Linus Walleij, linux-arm-kernel, linux-gpio, linux-kernel,
Patrice Chotard
On Mon, Oct 10, 2022 at 10:56:15AM +0300, Andy Shevchenko wrote:
> The OF node in the GPIO library is deprecated and soon
> will be removed.
>
> GPIO library now accepts fwnode as a firmware node, so
> switch the driver to use it.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
> drivers/pinctrl/pinctrl-st.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
> index cf7f9cbe6044..987878c83349 100644
> --- a/drivers/pinctrl/pinctrl-st.c
> +++ b/drivers/pinctrl/pinctrl-st.c
> @@ -1175,7 +1175,7 @@ static int st_pctl_dt_calculate_pin(struct st_pinctrl *info,
>
> for (i = 0; i < info->nbanks; i++) {
> chip = &info->banks[i].gpio_chip;
> - if (chip->of_node == np) {
> + if (chip->fwnode == of_fwnode_handle(np)) {
> if (offset < chip->ngpio)
> retval = chip->base + offset;
> break;
> @@ -1518,7 +1518,7 @@ static int st_gpiolib_register_bank(struct st_pinctrl *info,
> bank->gpio_chip = st_gpio_template;
> bank->gpio_chip.base = bank_num * ST_GPIO_PINS_PER_BANK;
> bank->gpio_chip.ngpio = ST_GPIO_PINS_PER_BANK;
> - bank->gpio_chip.of_node = np;
> + bank->gpio_chip.fwnode = of_fwnode_handle(np);
> bank->gpio_chip.parent = dev;
> spin_lock_init(&bank->lock);
>
> --
> 2.35.1
>
Thanks.
--
Dmitry
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v1 1/1] pinctrl: st: Switch to use fwnode instead of of_node
2022-10-10 7:56 [PATCH v1 1/1] pinctrl: st: Switch to use fwnode instead of of_node Andy Shevchenko
2022-10-10 17:59 ` Dmitry Torokhov
@ 2022-10-11 6:23 ` Patrice CHOTARD
2022-10-17 10:11 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Patrice CHOTARD @ 2022-10-11 6:23 UTC (permalink / raw)
To: Andy Shevchenko, Linus Walleij, linux-arm-kernel, linux-gpio,
linux-kernel
Cc: Dmitry Torokhov
On 10/10/22 09:56, Andy Shevchenko wrote:
> The OF node in the GPIO library is deprecated and soon
> will be removed.
>
> GPIO library now accepts fwnode as a firmware node, so
> switch the driver to use it.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/pinctrl/pinctrl-st.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
> index cf7f9cbe6044..987878c83349 100644
> --- a/drivers/pinctrl/pinctrl-st.c
> +++ b/drivers/pinctrl/pinctrl-st.c
> @@ -1175,7 +1175,7 @@ static int st_pctl_dt_calculate_pin(struct st_pinctrl *info,
>
> for (i = 0; i < info->nbanks; i++) {
> chip = &info->banks[i].gpio_chip;
> - if (chip->of_node == np) {
> + if (chip->fwnode == of_fwnode_handle(np)) {
> if (offset < chip->ngpio)
> retval = chip->base + offset;
> break;
> @@ -1518,7 +1518,7 @@ static int st_gpiolib_register_bank(struct st_pinctrl *info,
> bank->gpio_chip = st_gpio_template;
> bank->gpio_chip.base = bank_num * ST_GPIO_PINS_PER_BANK;
> bank->gpio_chip.ngpio = ST_GPIO_PINS_PER_BANK;
> - bank->gpio_chip.of_node = np;
> + bank->gpio_chip.fwnode = of_fwnode_handle(np);
> bank->gpio_chip.parent = dev;
> spin_lock_init(&bank->lock);
>
Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>
Thanks
Patrice
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v1 1/1] pinctrl: st: Switch to use fwnode instead of of_node
2022-10-10 7:56 [PATCH v1 1/1] pinctrl: st: Switch to use fwnode instead of of_node Andy Shevchenko
2022-10-10 17:59 ` Dmitry Torokhov
2022-10-11 6:23 ` Patrice CHOTARD
@ 2022-10-17 10:11 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2022-10-17 10:11 UTC (permalink / raw)
To: Andy Shevchenko
Cc: linux-arm-kernel, linux-gpio, linux-kernel, Patrice Chotard,
Dmitry Torokhov
On Mon, Oct 10, 2022 at 9:56 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> The OF node in the GPIO library is deprecated and soon
> will be removed.
>
> GPIO library now accepts fwnode as a firmware node, so
> switch the driver to use it.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Patch applied!
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-10-17 10:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-10 7:56 [PATCH v1 1/1] pinctrl: st: Switch to use fwnode instead of of_node Andy Shevchenko
2022-10-10 17:59 ` Dmitry Torokhov
2022-10-11 6:23 ` Patrice CHOTARD
2022-10-17 10:11 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).