linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] dt-bindings: ARM: add bindings for the D-Link DWL-8610AP
@ 2022-10-13 22:35 Linus Walleij
  2022-10-13 22:35 ` [PATCH 2/2] ARM: dts: bcm53016: Add devicetree for " Linus Walleij
  2022-10-14 14:07 ` [PATCH 1/2] dt-bindings: ARM: add bindings for the " Rob Herring
  0 siblings, 2 replies; 6+ messages in thread
From: Linus Walleij @ 2022-10-13 22:35 UTC (permalink / raw)
  To: Florian Fainelli, Hauke Mehrtens, Rafał Miłecki
  Cc: bcm-kernel-feedback-list, linux-arm-kernel, Linus Walleij, devicetree

The D-Link DWL-8610AP is a pure access point with ethernet in
and wireless (both 2.4GHz and 5GHz) out.

Cc: devicetree@vger.kernel.org
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.yaml b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.yaml
index 958df32b4899..2657f9b82ecd 100644
--- a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.yaml
+++ b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.yaml
@@ -97,6 +97,7 @@ properties:
       - description: BCM53016 based boards
         items:
           - enum:
+              - dlink,dwl-8610ap
               - meraki,mr32
           - const: brcm,bcm53016
           - const: brcm,bcm4708
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/2] ARM: dts: bcm53016: Add devicetree for D-Link DWL-8610AP
  2022-10-13 22:35 [PATCH 1/2] dt-bindings: ARM: add bindings for the D-Link DWL-8610AP Linus Walleij
@ 2022-10-13 22:35 ` Linus Walleij
  2022-10-15 15:25   ` Linus Walleij
  2022-10-16 20:27   ` Rafał Miłecki
  2022-10-14 14:07 ` [PATCH 1/2] dt-bindings: ARM: add bindings for the " Rob Herring
  1 sibling, 2 replies; 6+ messages in thread
From: Linus Walleij @ 2022-10-13 22:35 UTC (permalink / raw)
  To: Florian Fainelli, Hauke Mehrtens, Rafał Miłecki
  Cc: bcm-kernel-feedback-list, linux-arm-kernel, Linus Walleij

This adds a device tree for the BCM53016-based D-Link DWL-8610AP
access point wireless router.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 arch/arm/boot/dts/Makefile                    |   1 +
 .../boot/dts/bcm53016-dlink-dwl-8610ap.dts    | 136 ++++++++++++++++++
 2 files changed, 137 insertions(+)
 create mode 100644 arch/arm/boot/dts/bcm53016-dlink-dwl-8610ap.dts

diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 05d8aef6e5d2..1ace19792e96 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -138,6 +138,7 @@ dtb-$(CONFIG_ARCH_BCM_5301X) += \
 	bcm47094-netgear-r8500.dtb \
 	bcm47094-phicomm-k3.dtb \
 	bcm53015-meraki-mr26.dtb \
+	bcm53016-dlink-dwl-8610ap.dtb \
 	bcm53016-meraki-mr32.dtb \
 	bcm94708.dtb \
 	bcm94709.dtb \
diff --git a/arch/arm/boot/dts/bcm53016-dlink-dwl-8610ap.dts b/arch/arm/boot/dts/bcm53016-dlink-dwl-8610ap.dts
new file mode 100644
index 000000000000..fdf43a13338c
--- /dev/null
+++ b/arch/arm/boot/dts/bcm53016-dlink-dwl-8610ap.dts
@@ -0,0 +1,136 @@
+// SPDX-License-Identifier: GPL-2.0
+/dts-v1/;
+
+#include "bcm4709.dtsi"
+#include "bcm5301x-nand-cs0-bch8.dtsi"
+#include <dt-bindings/leds/common.h>
+#include <dt-bindings/input/input.h>
+
+/ {
+	model = "D-Link DWL-8610AP Wireless Access Point";
+	compatible = "dlink,dwl-8610ap", "brcm,bcm53016", "brcm,bcm4708";
+
+	memory@0 {
+		device_type = "memory";
+		/* 512 MB RAM in 2 x Macronix D9PSH chips */
+		reg = <0x00000000 0x08000000>,
+		      <0x88000000 0x08000000>;
+	};
+
+	leds {
+		compatible = "gpio-leds";
+
+		power {
+			function = LED_FUNCTION_POWER;
+			color = <LED_COLOR_ID_GREEN>;
+			gpios = <&chipcommon 0 GPIO_ACTIVE_LOW>;
+			default-state = "on";
+		};
+
+		diag {
+			/* Actually "diag" unclear what this means */
+			function = LED_FUNCTION_INDICATOR;
+			color = <LED_COLOR_ID_RED>;
+			gpios = <&chipcommon 1 GPIO_ACTIVE_LOW>;
+			default-state = "on";
+			linux,default-trigger = "heartbeat";
+		};
+
+		wlan-2g {
+			function = LED_FUNCTION_WLAN;
+			color = <LED_COLOR_ID_GREEN>;
+			gpios = <&chipcommon 5 GPIO_ACTIVE_LOW>;
+		};
+
+		wlan-5g {
+			function = LED_FUNCTION_WLAN;
+			color = <LED_COLOR_ID_GREEN>;
+			gpios = <&chipcommon 8 GPIO_ACTIVE_LOW>;
+		};
+	};
+
+	gpio_keys {
+		compatible = "gpio-keys";
+
+		button-reset {
+			debounce-interval = <100>;
+			wakeup-source;
+			linux,code = <KEY_RESTART>;
+			label = "reset";
+			/* This GPIO is actually stored in NVRAM, but it's not gonna change */
+			gpios = <&chipcommon 4 GPIO_ACTIVE_LOW>;
+		};
+	};
+
+	/*
+	 * Flash memory at 0x1e000000-0x1fffffff
+	 * Macronix 32 64KB blocks; total size 2MB, same that can be
+	 * found attached to the spi_nor SPI controller.
+	 */
+	nvram@1e080000 {
+		compatible = "brcm,nvram";
+		reg = <0x1e080000 0x00020000>;
+
+		et0macaddr: et0macaddr {
+		};
+
+		et1macaddr: et1macaddr {
+		};
+	};
+};
+
+&gmac0 {
+	nvmem-cells = <&et0macaddr>;
+	nvmem-cell-names = "mac-address";
+};
+
+&gmac1 {
+	nvmem-cells = <&et1macaddr>;
+	nvmem-cell-names = "mac-address";
+};
+
+&spi_nor {
+	/* Serial SPI NOR Flash MX 25L1606E */
+	status = "okay";
+};
+
+&nandcs {
+	nand-ecc-algo = "hw";
+
+	/* Spansion S34ML01G100TFI00 128 MB NAND Flash memory */
+	partitions {
+		compatible = "fixed-partitions";
+		#address-cells = <1>;
+		#size-cells = <1>;
+
+		linux@0 {
+			label = "linux";
+			reg = <0x00000000 0x02800000>;
+			read-only;
+		};
+
+		rootfs@2800000 {
+			label = "rootfs";
+			reg = <0x02800000 0x00000000>;
+			read-only;
+		};
+
+		linux2@2800000 {
+			label = "linux2";
+			reg = <0x02800000 0x02800000>;
+			read-only;
+		};
+
+		rootfs2@2a80000 {
+			label = "rootfs2";
+			reg = <0x02a80000 0x02580000>;
+			read-only;
+		};
+
+		jffs2@500000 {
+			label = "jffs2";
+			reg = <0x05000000 0x03000000>;
+			read-only;
+		};
+	};
+};
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] dt-bindings: ARM: add bindings for the D-Link DWL-8610AP
  2022-10-13 22:35 [PATCH 1/2] dt-bindings: ARM: add bindings for the D-Link DWL-8610AP Linus Walleij
  2022-10-13 22:35 ` [PATCH 2/2] ARM: dts: bcm53016: Add devicetree for " Linus Walleij
@ 2022-10-14 14:07 ` Rob Herring
  1 sibling, 0 replies; 6+ messages in thread
From: Rob Herring @ 2022-10-14 14:07 UTC (permalink / raw)
  To: Linus Walleij
  Cc: Hauke Mehrtens, bcm-kernel-feedback-list, devicetree,
	Florian Fainelli, linux-arm-kernel, Rafał Miłecki

On Fri, 14 Oct 2022 00:35:37 +0200, Linus Walleij wrote:
> The D-Link DWL-8610AP is a pure access point with ethernet in
> and wireless (both 2.4GHz and 5GHz) out.
> 
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
>  Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 

Acked-by: Rob Herring <robh@kernel.org>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2] ARM: dts: bcm53016: Add devicetree for D-Link DWL-8610AP
  2022-10-13 22:35 ` [PATCH 2/2] ARM: dts: bcm53016: Add devicetree for " Linus Walleij
@ 2022-10-15 15:25   ` Linus Walleij
  2022-10-17 10:33     ` Linus Walleij
  2022-10-16 20:27   ` Rafał Miłecki
  1 sibling, 1 reply; 6+ messages in thread
From: Linus Walleij @ 2022-10-15 15:25 UTC (permalink / raw)
  To: Florian Fainelli, Hauke Mehrtens, Rafał Miłecki
  Cc: bcm-kernel-feedback-list, linux-arm-kernel

On Fri, Oct 14, 2022 at 12:38 AM Linus Walleij <linus.walleij@linaro.org> wrote:

> This adds a device tree for the BCM53016-based D-Link DWL-8610AP
> access point wireless router.
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

I will be sending a v2 of this because the partitions are clearly TRX
and the TRX parser finds the first two partitions.

ubiattach is really quirky with this, if anyone has hints on how to
mount D-Link ubifs images based on 2.6 please help.

Yours,
Linus Walleij

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2] ARM: dts: bcm53016: Add devicetree for D-Link DWL-8610AP
  2022-10-13 22:35 ` [PATCH 2/2] ARM: dts: bcm53016: Add devicetree for " Linus Walleij
  2022-10-15 15:25   ` Linus Walleij
@ 2022-10-16 20:27   ` Rafał Miłecki
  1 sibling, 0 replies; 6+ messages in thread
From: Rafał Miłecki @ 2022-10-16 20:27 UTC (permalink / raw)
  To: Linus Walleij, Florian Fainelli, Hauke Mehrtens
  Cc: bcm-kernel-feedback-list, linux-arm-kernel

On 14.10.2022 00:35, Linus Walleij wrote:
> diff --git a/arch/arm/boot/dts/bcm53016-dlink-dwl-8610ap.dts b/arch/arm/boot/dts/bcm53016-dlink-dwl-8610ap.dts
> new file mode 100644
> index 000000000000..fdf43a13338c
> --- /dev/null
> +++ b/arch/arm/boot/dts/bcm53016-dlink-dwl-8610ap.dts
> @@ -0,0 +1,136 @@
> +// SPDX-License-Identifier: GPL-2.0

Could you use
GPL-2.0-or-later OR MIT
just to match 99% of BCM5301X DTS files, please?

You can check:
9c281b5e12996 ("ARM: dts: BCM5301X: Relicense Asus RT-AC87U file to the GPL 2.0+ / MIT")
fd0ab539d185a ("ARM: dts: BCM5301X: Relicense Buffalo files to the GPL 2.0+ / MIT")
2b3db67ce4bc4 ("ARM: dts: BCM5301X: Relicense most DTS files to the GPL 2.0+ / MIT")


> +/dts-v1/;
> +
> +#include "bcm4709.dtsi"
> +#include "bcm5301x-nand-cs0-bch8.dtsi"
> +#include <dt-bindings/leds/common.h>
> +#include <dt-bindings/input/input.h>
> +
> +/ {
> +	model = "D-Link DWL-8610AP Wireless Access Point";

I'm not sure: do we want or need that "Wireless Access Point" part?


> +	compatible = "dlink,dwl-8610ap", "brcm,bcm53016", "brcm,bcm4708";
> +
> +	memory@0 {
> +		device_type = "memory";
> +		/* 512 MB RAM in 2 x Macronix D9PSH chips */
> +		reg = <0x00000000 0x08000000>,
> +		      <0x88000000 0x08000000>;
> +	};


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2] ARM: dts: bcm53016: Add devicetree for D-Link DWL-8610AP
  2022-10-15 15:25   ` Linus Walleij
@ 2022-10-17 10:33     ` Linus Walleij
  0 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2022-10-17 10:33 UTC (permalink / raw)
  To: Florian Fainelli, Hauke Mehrtens, Rafał Miłecki
  Cc: bcm-kernel-feedback-list, linux-arm-kernel

On Sat, Oct 15, 2022 at 5:25 PM Linus Walleij <linus.walleij@linaro.org> wrote:

> ubiattach is really quirky with this, if anyone has hints on how to
> mount D-Link ubifs images based on 2.6 please help.

I figured this one out: the TRX partition parser was incomplete.
After fixing (patch sent to MTD) all partitions are detected with proper
size and ubiattach works.

Yours,
Linus Walleij

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2022-10-17 10:34 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-13 22:35 [PATCH 1/2] dt-bindings: ARM: add bindings for the D-Link DWL-8610AP Linus Walleij
2022-10-13 22:35 ` [PATCH 2/2] ARM: dts: bcm53016: Add devicetree for " Linus Walleij
2022-10-15 15:25   ` Linus Walleij
2022-10-17 10:33     ` Linus Walleij
2022-10-16 20:27   ` Rafał Miłecki
2022-10-14 14:07 ` [PATCH 1/2] dt-bindings: ARM: add bindings for the " Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).