* [PATCH V3 0/2] pinctrl: bcm2835: Improve generic behavior
@ 2019-02-03 13:02 Stefan Wahren
2019-02-03 13:02 ` [PATCH V3 1/2] pinctrl: bcm2835: declare pin config as generic Stefan Wahren
2019-02-03 13:02 ` [PATCH V3 2/2] pinctrl: bcm2835: Direct GPIO config changes to generic pinctrl Stefan Wahren
0 siblings, 2 replies; 5+ messages in thread
From: Stefan Wahren @ 2019-02-03 13:02 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski, Eric Anholt
Cc: Stefan Wahren, linux-gpio, Lukas Wunner, Peter Robinson,
linux-arm-kernel
This series is the non-controversial part of "pinctrl: bcm2835: improve
libgpiod output". It has been split up in order to apply for the next
kernel release.
Changes in V3:
- drop patches #3 and #4 from former series
Stefan Wahren (2):
pinctrl: bcm2835: declare pin config as generic
pinctrl: bcm2835: Direct GPIO config changes to generic pinctrl
drivers/pinctrl/bcm/pinctrl-bcm2835.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH V3 1/2] pinctrl: bcm2835: declare pin config as generic
2019-02-03 13:02 [PATCH V3 0/2] pinctrl: bcm2835: Improve generic behavior Stefan Wahren
@ 2019-02-03 13:02 ` Stefan Wahren
2019-02-08 12:12 ` Linus Walleij
2019-02-03 13:02 ` [PATCH V3 2/2] pinctrl: bcm2835: Direct GPIO config changes to generic pinctrl Stefan Wahren
1 sibling, 1 reply; 5+ messages in thread
From: Stefan Wahren @ 2019-02-03 13:02 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski, Eric Anholt
Cc: Stefan Wahren, linux-gpio, Lukas Wunner, Peter Robinson,
linux-arm-kernel
Since commit 0de704955ee44 ("pinctrl: bcm2835: Add support for
generic pinctrl binding") this driver is capable to use the generic
interface. So declare this accordingly.
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
drivers/pinctrl/bcm/pinctrl-bcm2835.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/bcm/pinctrl-bcm2835.c b/drivers/pinctrl/bcm/pinctrl-bcm2835.c
index f180aa4..19eb4fd 100644
--- a/drivers/pinctrl/bcm/pinctrl-bcm2835.c
+++ b/drivers/pinctrl/bcm/pinctrl-bcm2835.c
@@ -969,6 +969,7 @@ static int bcm2835_pinconf_set(struct pinctrl_dev *pctldev,
}
static const struct pinconf_ops bcm2835_pinconf_ops = {
+ .is_generic = true,
.pin_config_get = bcm2835_pinconf_get,
.pin_config_set = bcm2835_pinconf_set,
};
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH V3 2/2] pinctrl: bcm2835: Direct GPIO config changes to generic pinctrl
2019-02-03 13:02 [PATCH V3 0/2] pinctrl: bcm2835: Improve generic behavior Stefan Wahren
2019-02-03 13:02 ` [PATCH V3 1/2] pinctrl: bcm2835: declare pin config as generic Stefan Wahren
@ 2019-02-03 13:02 ` Stefan Wahren
2019-02-08 12:13 ` Linus Walleij
1 sibling, 1 reply; 5+ messages in thread
From: Stefan Wahren @ 2019-02-03 13:02 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski, Eric Anholt
Cc: Stefan Wahren, linux-gpio, Lukas Wunner, Peter Robinson,
linux-arm-kernel
In order to support GPIO config changes direct these to the generic pinctrl.
This also requires an adjust of the return code for unsupported parameter
otherwise gpiod_configure_flags wont work as expected.
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
drivers/pinctrl/bcm/pinctrl-bcm2835.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/pinctrl/bcm/pinctrl-bcm2835.c b/drivers/pinctrl/bcm/pinctrl-bcm2835.c
index 19eb4fd..183d1ff 100644
--- a/drivers/pinctrl/bcm/pinctrl-bcm2835.c
+++ b/drivers/pinctrl/bcm/pinctrl-bcm2835.c
@@ -341,6 +341,7 @@ static const struct gpio_chip bcm2835_gpio_chip = {
.get_direction = bcm2835_gpio_get_direction,
.get = bcm2835_gpio_get,
.set = bcm2835_gpio_set,
+ .set_config = gpiochip_generic_config,
.base = -1,
.ngpio = BCM2835_NUM_GPIOS,
.can_sleep = false,
@@ -960,7 +961,7 @@ static int bcm2835_pinconf_set(struct pinctrl_dev *pctldev,
break;
default:
- return -EINVAL;
+ return -ENOTSUPP;
} /* switch param type */
} /* for each config */
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH V3 1/2] pinctrl: bcm2835: declare pin config as generic
2019-02-03 13:02 ` [PATCH V3 1/2] pinctrl: bcm2835: declare pin config as generic Stefan Wahren
@ 2019-02-08 12:12 ` Linus Walleij
0 siblings, 0 replies; 5+ messages in thread
From: Linus Walleij @ 2019-02-08 12:12 UTC (permalink / raw)
To: Stefan Wahren
Cc: open list:GPIO SUBSYSTEM, Eric Anholt, Bartosz Golaszewski,
Lukas Wunner, Peter Robinson, Linux ARM
On Sun, Feb 3, 2019 at 2:03 PM Stefan Wahren <stefan.wahren@i2se.com> wrote:
> Since commit 0de704955ee44 ("pinctrl: bcm2835: Add support for
> generic pinctrl binding") this driver is capable to use the generic
> interface. So declare this accordingly.
>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Patch applied.
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH V3 2/2] pinctrl: bcm2835: Direct GPIO config changes to generic pinctrl
2019-02-03 13:02 ` [PATCH V3 2/2] pinctrl: bcm2835: Direct GPIO config changes to generic pinctrl Stefan Wahren
@ 2019-02-08 12:13 ` Linus Walleij
0 siblings, 0 replies; 5+ messages in thread
From: Linus Walleij @ 2019-02-08 12:13 UTC (permalink / raw)
To: Stefan Wahren
Cc: open list:GPIO SUBSYSTEM, Eric Anholt, Bartosz Golaszewski,
Lukas Wunner, Peter Robinson, Linux ARM
On Sun, Feb 3, 2019 at 2:03 PM Stefan Wahren <stefan.wahren@i2se.com> wrote:
> In order to support GPIO config changes direct these to the generic pinctrl.
> This also requires an adjust of the return code for unsupported parameter
> otherwise gpiod_configure_flags wont work as expected.
>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Patch applied.
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-02-08 12:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-03 13:02 [PATCH V3 0/2] pinctrl: bcm2835: Improve generic behavior Stefan Wahren
2019-02-03 13:02 ` [PATCH V3 1/2] pinctrl: bcm2835: declare pin config as generic Stefan Wahren
2019-02-08 12:12 ` Linus Walleij
2019-02-03 13:02 ` [PATCH V3 2/2] pinctrl: bcm2835: Direct GPIO config changes to generic pinctrl Stefan Wahren
2019-02-08 12:13 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).