[RFC PATCH 1/1] pinctrl: imx: Reduce printk message level for empty nodes

[RFC PATCH 1/1] pinctrl: imx: Reduce printk message level for empty nodes

[Alexander Stein]

iomuxc_snvs from imx6ull supports 2 boot mode and 10 tamper pins.
Probably most users won't use them, causing this error message during boot:
  no groups defined in /soc/bus@2200000/iomuxc-snvs@2290000
This is actually not an error in this case, so reduce the level
accordingly.

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
This issue was raised during release test: Why is there an error if
nothing is wrong?
Memory only devices are enabled by default, which I agree, but this
causes the mentioned error message unconditionally, unless some muxing is
configured. I would argue that even a warning is not correct either,
nothing is wrong here.

 drivers/pinctrl/freescale/pinctrl-imx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/freescale/pinctrl-imx.c b/drivers/pinctrl/freescale/pinctrl-imx.c
index fa3cc0b80ede..3a7d2de10b13 100644
--- a/drivers/pinctrl/freescale/pinctrl-imx.c
+++ b/drivers/pinctrl/freescale/pinctrl-imx.c
@@ -661,7 +661,7 @@ static int imx_pinctrl_parse_functions(struct device_node *np,
 	func->name = np->name;
 	func->num_group_names = of_get_child_count(np);
 	if (func->num_group_names == 0) {
-		dev_err(ipctl->dev, "no groups defined in %pOF\n", np);
+		dev_info(ipctl->dev, "no groups defined in %pOF\n", np);
 		return -EINVAL;
 	}
 
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [RFC PATCH 1/1] pinctrl: imx: Reduce printk message level for empty nodes

[Linus Walleij]

On Thu, Feb 24, 2022 at 10:42 AM Alexander Stein
<alexander.stein@ew.tq-group.com> wrote:

> iomuxc_snvs from imx6ull supports 2 boot mode and 10 tamper pins.
> Probably most users won't use them, causing this error message during boot:
>   no groups defined in /soc/bus@2200000/iomuxc-snvs@2290000
> This is actually not an error in this case, so reduce the level
> accordingly.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> This issue was raised during release test: Why is there an error if
> nothing is wrong?
> Memory only devices are enabled by default, which I agree, but this
> causes the mentioned error message unconditionally, unless some muxing is
> configured. I would argue that even a warning is not correct either,
> nothing is wrong here.

Patch applied.

Yours,
Linus Walleij

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel