* [PATCH] clocksource: versatile: Allow CONFIG_CLKSRC_VERSATILE to be disabled
@ 2020-04-17 21:20 Rob Herring
2020-04-17 23:37 ` Linus Walleij
2020-04-27 9:34 ` Daniel Lezcano
0 siblings, 2 replies; 3+ messages in thread
From: Rob Herring @ 2020-04-17 21:20 UTC (permalink / raw)
To: Daniel Lezcano
Cc: Thomas Gleixner, linux-kernel, linux-arm-kernel, Linus Walleij
The timer-versatile driver provides a sched_clock for certain Arm Ltd.
reference platforms. Specifically, it is used on Versatile and 32-bit
VExpress. It is not needed for those platforms with an arch timer (all
the 64-bit ones) yet CONFIG_MFD_VEXPRESS_SYSREG does still need to be
enabled. In that case, the timer-versatile can only be disabled when
COMPILE_TEST is enabled which is not desirable. Let's use the sub-arch
kconfig symbols instead.
Realview platforms don't have the sysregs that this driver uses so
correct the help text.
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Rob Herring <robh@kernel.org>
---
This is part of a larger effort to modularize Versatile Express support,
but this change doesn't have any dependency, so it can be applied
independently.
Rob
drivers/clocksource/Kconfig | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index f2142e6bbea3..679b35fc07a8 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -562,12 +562,11 @@ config CLKSRC_VERSATILE
bool "ARM Versatile (Express) reference platforms clock source" if COMPILE_TEST
depends on GENERIC_SCHED_CLOCK && !ARCH_USES_GETTIMEOFFSET
select TIMER_OF
- default y if MFD_VEXPRESS_SYSREG
+ default y if (ARCH_VEXPRESS || ARCH_VERSATILE) && ARM
help
This option enables clock source based on free running
counter available in the "System Registers" block of
- ARM Versatile, RealView and Versatile Express reference
- platforms.
+ ARM Versatile and Versatile Express reference platforms.
config CLKSRC_MIPS_GIC
bool
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] clocksource: versatile: Allow CONFIG_CLKSRC_VERSATILE to be disabled
2020-04-17 21:20 [PATCH] clocksource: versatile: Allow CONFIG_CLKSRC_VERSATILE to be disabled Rob Herring
@ 2020-04-17 23:37 ` Linus Walleij
2020-04-27 9:34 ` Daniel Lezcano
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2020-04-17 23:37 UTC (permalink / raw)
To: Rob Herring; +Cc: Thomas Gleixner, Daniel Lezcano, linux-kernel, Linux ARM
On Fri, Apr 17, 2020 at 11:20 PM Rob Herring <robh@kernel.org> wrote:
> The timer-versatile driver provides a sched_clock for certain Arm Ltd.
> reference platforms. Specifically, it is used on Versatile and 32-bit
> VExpress. It is not needed for those platforms with an arch timer (all
> the 64-bit ones) yet CONFIG_MFD_VEXPRESS_SYSREG does still need to be
> enabled. In that case, the timer-versatile can only be disabled when
> COMPILE_TEST is enabled which is not desirable. Let's use the sub-arch
> kconfig symbols instead.
>
> Realview platforms don't have the sysregs that this driver uses so
> correct the help text.
>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Rob Herring <robh@kernel.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Thanks!
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] clocksource: versatile: Allow CONFIG_CLKSRC_VERSATILE to be disabled
2020-04-17 21:20 [PATCH] clocksource: versatile: Allow CONFIG_CLKSRC_VERSATILE to be disabled Rob Herring
2020-04-17 23:37 ` Linus Walleij
@ 2020-04-27 9:34 ` Daniel Lezcano
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Lezcano @ 2020-04-27 9:34 UTC (permalink / raw)
To: Rob Herring
Cc: Thomas Gleixner, linux-kernel, linux-arm-kernel, Linus Walleij
On 17/04/2020 23:20, Rob Herring wrote:
> The timer-versatile driver provides a sched_clock for certain Arm Ltd.
> reference platforms. Specifically, it is used on Versatile and 32-bit
> VExpress. It is not needed for those platforms with an arch timer (all
> the 64-bit ones) yet CONFIG_MFD_VEXPRESS_SYSREG does still need to be
> enabled. In that case, the timer-versatile can only be disabled when
> COMPILE_TEST is enabled which is not desirable. Let's use the sub-arch
> kconfig symbols instead.
>
> Realview platforms don't have the sysregs that this driver uses so
> correct the help text.
>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> This is part of a larger effort to modularize Versatile Express support,
> but this change doesn't have any dependency, so it can be applied
> independently.
Applied, thanks
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-27 9:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-17 21:20 [PATCH] clocksource: versatile: Allow CONFIG_CLKSRC_VERSATILE to be disabled Rob Herring
2020-04-17 23:37 ` Linus Walleij
2020-04-27 9:34 ` Daniel Lezcano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).