* [PATCH] pinctrl: zynq: use module_platform_driver to simplify the code
@ 2022-02-24 4:36 Srinivas Neeli
2022-03-15 0:47 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Srinivas Neeli @ 2022-02-24 4:36 UTC (permalink / raw)
To: linus.walleij, michal.simek, linux-gpio, linux-arm-kernel,
linux-kernel, shubhrajyoti.datta
Cc: git, sgoud, Srinivas Neeli
module_platform_driver() makes the code simpler by eliminating
boilerplate code.
Signed-off-by: Srinivas Neeli <srinivas.neeli@xilinx.com>
---
drivers/pinctrl/pinctrl-zynq.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-zynq.c b/drivers/pinctrl/pinctrl-zynq.c
index a96af8a76a7a..0e8de27d0de8 100644
--- a/drivers/pinctrl/pinctrl-zynq.c
+++ b/drivers/pinctrl/pinctrl-zynq.c
@@ -8,6 +8,7 @@
*/
#include <linux/io.h>
#include <linux/mfd/syscon.h>
+#include <linux/module.h>
#include <linux/init.h>
#include <linux/of.h>
#include <linux/platform_device.h>
@@ -1210,8 +1211,4 @@ static struct platform_driver zynq_pinctrl_driver = {
.probe = zynq_pinctrl_probe,
};
-static int __init zynq_pinctrl_init(void)
-{
- return platform_driver_register(&zynq_pinctrl_driver);
-}
-arch_initcall(zynq_pinctrl_init);
+module_platform_driver(zynq_pinctrl_driver);
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pinctrl: zynq: use module_platform_driver to simplify the code
2022-02-24 4:36 [PATCH] pinctrl: zynq: use module_platform_driver to simplify the code Srinivas Neeli
@ 2022-03-15 0:47 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2022-03-15 0:47 UTC (permalink / raw)
To: Srinivas Neeli
Cc: michal.simek, linux-gpio, linux-arm-kernel, linux-kernel,
shubhrajyoti.datta, git, sgoud
On Thu, Feb 24, 2022 at 5:36 AM Srinivas Neeli
<srinivas.neeli@xilinx.com> wrote:
> module_platform_driver() makes the code simpler by eliminating
> boilerplate code.
>
> Signed-off-by: Srinivas Neeli <srinivas.neeli@xilinx.com>
Nice, patch applied!
> -static int __init zynq_pinctrl_init(void)
> -{
> - return platform_driver_register(&zynq_pinctrl_driver);
> -}
> -arch_initcall(zynq_pinctrl_init);
> +module_platform_driver(zynq_pinctrl_driver);
This will incidentally also move the initcall from arch_initcall
to driver_initcall but I assume that works so, OK.
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-15 0:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-24 4:36 [PATCH] pinctrl: zynq: use module_platform_driver to simplify the code Srinivas Neeli
2022-03-15 0:47 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).