From: zajec5@gmail.com (Rafał Miłecki)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 4/6] net: ethernet: bgmac: convert to feature flags
Date: Tue, 20 Sep 2016 07:19:19 +0200 [thread overview]
Message-ID: <CACna6rymVcKV1h_PEvRuCQrtOd4rsqV34bMWzVOof15fdc8KEA@mail.gmail.com> (raw)
In-Reply-To: <CACna6rw1j3myPEkbn+YR71W7CF7Of_yahn9eDT7t3hKWGmWUmg@mail.gmail.com>
On 17 August 2016 at 13:34, Rafa? Mi?ecki <zajec5@gmail.com> wrote:
> On 8 July 2016 at 01:08, Jon Mason <jon.mason@broadcom.com> wrote:
>> mode = (bgmac_read(bgmac, BGMAC_DEV_STATUS) & BGMAC_DS_MM_MASK) >>
>> BGMAC_DS_MM_SHIFT;
>> - if (ci->id != BCMA_CHIP_ID_BCM47162 || mode != 0)
>> + if (bgmac->feature_flags & BGMAC_FEAT_CLKCTLST || mode != 0)
>> bgmac_set(bgmac, BCMA_CLKCTLST, BCMA_CLKCTLST_FORCEHT);
>> - if (ci->id == BCMA_CHIP_ID_BCM47162 && mode == 2)
>> + if (bgmac->feature_flags & BGMAC_FEAT_CLKCTLST && mode == 2)
>> bcma_chipco_chipctl_maskset(&bgmac->core->bus->drv_cc, 1, ~0,
>> BGMAC_CHIPCTL_1_RXC_DLL_BYPASS);
>
> Jon, it looks to me you translated two following conditions:
> ci->id != BCMA_CHIP_ID_BCM47162
> and
> ci->id == BCMA_CHIP_ID_BCM47162
> into the same flag check:
> bgmac->feature_flags & BGMAC_FEAT_CLKCTLST
>
> I don't think it's intentional, is it? Do you have a moment to fix this?
Ping
--
Rafa?
next prev parent reply other threads:[~2016-09-20 5:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-07 23:08 [PATCH v2 0/6] net: ethernet: bgmac: Add platform device support Jon Mason
2016-07-07 23:08 ` [PATCH v2 1/6] net: ethernet: bgmac: change bgmac_* prints to dev_* prints Jon Mason
2016-07-08 18:10 ` Florian Fainelli
2016-07-07 23:08 ` [PATCH v2 2/6] net: ethernet: bgmac: add dma_dev pointer Jon Mason
2016-07-08 18:11 ` Florian Fainelli
2016-07-07 23:08 ` [PATCH v2 3/6] net: ethernet: bgmac: move BCMA MDIO Phy code into a separate file Jon Mason
2016-07-08 18:11 ` Florian Fainelli
2016-07-07 23:08 ` [PATCH v2 4/6] net: ethernet: bgmac: convert to feature flags Jon Mason
2016-07-08 18:11 ` Florian Fainelli
2016-08-17 11:34 ` Rafał Miłecki
2016-09-20 5:19 ` Rafał Miłecki [this message]
2016-09-20 13:59 ` Jon Mason
2016-07-07 23:08 ` [PATCH v2 5/6] net: ethernet: bgmac: Add platform device support Jon Mason
2016-07-08 18:11 ` Florian Fainelli
2016-07-07 23:08 ` [PATCH v2 6/6] dt-bindings: net: bgmac: add bindings documentation for bgmac Jon Mason
2016-07-08 18:12 ` Florian Fainelli
2016-07-11 16:48 ` Florian Fainelli
2016-07-13 13:39 ` Rob Herring
2016-07-08 15:52 ` [PATCH v2 0/6] net: ethernet: bgmac: Add platform device support Jon Mason
2016-07-08 22:47 ` David Miller
2016-07-08 18:09 ` Florian Fainelli
2016-07-09 22:11 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACna6rymVcKV1h_PEvRuCQrtOd4rsqV34bMWzVOof15fdc8KEA@mail.gmail.com \
--to=zajec5@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).