* [PATCH v2] soc: fsl: dpio: instead smp_processor_id with raw_smp_processor_id
@ 2021-10-19 2:32 Meng.Li
2021-10-20 1:35 ` Li Yang
0 siblings, 1 reply; 2+ messages in thread
From: Meng.Li @ 2021-10-19 2:32 UTC (permalink / raw)
To: Roy.Pledge, leoyang.li, ruxandra.radulescu, horia.geanta
Cc: linux-kernel, linuxppc-dev, linux-arm-kernel, meng.li
From: Meng Li <Meng.Li@windriver.com>
When enable debug kernel configs,there will be calltrace as below:
BUG: using smp_processor_id() in preemptible [00000000] code: swapper/0/1
caller is debug_smp_processor_id+0x20/0x30
CPU: 6 PID: 1 Comm: swapper/0 Not tainted 5.10.63-yocto-standard #1
Hardware name: NXP Layerscape LX2160ARDB (DT)
Call trace:
dump_backtrace+0x0/0x1a0
show_stack+0x24/0x30
dump_stack+0xf0/0x13c
check_preemption_disabled+0x100/0x110
debug_smp_processor_id+0x20/0x30
dpaa2_io_query_fq_count+0xdc/0x154
dpaa2_eth_stop+0x144/0x314
__dev_close_many+0xdc/0x160
__dev_change_flags+0xe8/0x220
dev_change_flags+0x30/0x70
ic_close_devs+0x50/0x78
ip_auto_config+0xed0/0xf10
do_one_initcall+0xac/0x460
kernel_init_freeable+0x30c/0x378
kernel_init+0x20/0x128
ret_from_fork+0x10/0x38
Based on comment in the context, it doesn't matter whether
preemption is disable or not. So, instead smp_processor_id()
with raw_smp_processor_id() to avoid above call trace.
v2:
Remove the preempt_disable/enable() protection, instead smp_processor_id
with raw_smp_processor_id.
Fixes: c89105c9b390 ("staging: fsl-mc: Move DPIO from staging to drivers/soc/fsl")
Cc: stable@vger.kernel.org
Signed-off-by: Meng Li <Meng.Li@windriver.com>
---
drivers/soc/fsl/dpio/dpio-service.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/fsl/dpio/dpio-service.c b/drivers/soc/fsl/dpio/dpio-service.c
index 19f47ea9dab0..3050a534d42c 100644
--- a/drivers/soc/fsl/dpio/dpio-service.c
+++ b/drivers/soc/fsl/dpio/dpio-service.c
@@ -59,7 +59,7 @@ static inline struct dpaa2_io *service_select_by_cpu(struct dpaa2_io *d,
* potentially being migrated away.
*/
if (cpu < 0)
- cpu = smp_processor_id();
+ cpu = raw_smp_processor_id();
/* If a specific cpu was requested, pick it up immediately */
return dpio_by_cpu[cpu];
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] soc: fsl: dpio: instead smp_processor_id with raw_smp_processor_id
2021-10-19 2:32 [PATCH v2] soc: fsl: dpio: instead smp_processor_id with raw_smp_processor_id Meng.Li
@ 2021-10-20 1:35 ` Li Yang
0 siblings, 0 replies; 2+ messages in thread
From: Li Yang @ 2021-10-20 1:35 UTC (permalink / raw)
To: Meng.Li
Cc: Roy Pledge, Ioana Ciocoi Radulescu, Horia Geanta, linuxppc-dev,
lkml, moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
On Mon, Oct 18, 2021 at 9:46 PM <Meng.Li@windriver.com> wrote:
>
> From: Meng Li <Meng.Li@windriver.com>
>
> When enable debug kernel configs,there will be calltrace as below:
>
> BUG: using smp_processor_id() in preemptible [00000000] code: swapper/0/1
> caller is debug_smp_processor_id+0x20/0x30
> CPU: 6 PID: 1 Comm: swapper/0 Not tainted 5.10.63-yocto-standard #1
> Hardware name: NXP Layerscape LX2160ARDB (DT)
> Call trace:
> dump_backtrace+0x0/0x1a0
> show_stack+0x24/0x30
> dump_stack+0xf0/0x13c
> check_preemption_disabled+0x100/0x110
> debug_smp_processor_id+0x20/0x30
> dpaa2_io_query_fq_count+0xdc/0x154
> dpaa2_eth_stop+0x144/0x314
> __dev_close_many+0xdc/0x160
> __dev_change_flags+0xe8/0x220
> dev_change_flags+0x30/0x70
> ic_close_devs+0x50/0x78
> ip_auto_config+0xed0/0xf10
> do_one_initcall+0xac/0x460
> kernel_init_freeable+0x30c/0x378
> kernel_init+0x20/0x128
> ret_from_fork+0x10/0x38
>
> Based on comment in the context, it doesn't matter whether
> preemption is disable or not. So, instead smp_processor_id()
s/instead/replace/g
> with raw_smp_processor_id() to avoid above call trace.
>
> v2:
> Remove the preempt_disable/enable() protection, instead smp_processor_id
> with raw_smp_processor_id.
The revision history information should go after the "---" below.
>
> Fixes: c89105c9b390 ("staging: fsl-mc: Move DPIO from staging to drivers/soc/fsl")
> Cc: stable@vger.kernel.org
> Signed-off-by: Meng Li <Meng.Li@windriver.com>
I helped to fix the issues I mentioned. Applied for fix. Thanks.
> ---
> drivers/soc/fsl/dpio/dpio-service.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/fsl/dpio/dpio-service.c b/drivers/soc/fsl/dpio/dpio-service.c
> index 19f47ea9dab0..3050a534d42c 100644
> --- a/drivers/soc/fsl/dpio/dpio-service.c
> +++ b/drivers/soc/fsl/dpio/dpio-service.c
> @@ -59,7 +59,7 @@ static inline struct dpaa2_io *service_select_by_cpu(struct dpaa2_io *d,
> * potentially being migrated away.
> */
> if (cpu < 0)
> - cpu = smp_processor_id();
> + cpu = raw_smp_processor_id();
>
> /* If a specific cpu was requested, pick it up immediately */
> return dpio_by_cpu[cpu];
> --
> 2.17.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-20 1:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-19 2:32 [PATCH v2] soc: fsl: dpio: instead smp_processor_id with raw_smp_processor_id Meng.Li
2021-10-20 1:35 ` Li Yang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).