* Re: [PATCH v3 06/10] arm64: dts: qcom: sc7280: Update reserved memory map
[not found] ` <1629344185-27368-7-git-send-email-sibis@codeaurora.org>
@ 2021-08-19 4:37 ` Vinod Koul
[not found] ` <39da02506af192de14d346cdf80d0e4c@codeaurora.org>
0 siblings, 1 reply; 7+ messages in thread
From: Vinod Koul @ 2021-08-19 4:37 UTC (permalink / raw)
To: Sibi Sankar
Cc: bjorn.andersson, robh+dt, will, saiprakash.ranjan, swboyd, mka,
ohad, agross, mathieu.poirier, robin.murphy, joro, p.zabel,
linux-arm-msm, linux-remoteproc, devicetree, linux-kernel,
linux-arm-kernel, evgreen, dianders
Hi Sibi,
On 19-08-21, 09:06, Sibi Sankar wrote:
> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> index 5e4f4f3b738a..894106efadfe 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> @@ -48,6 +48,16 @@
> #size-cells = <2>;
> ranges;
>
> + hyp_mem: memory@80000000 {
> + reg = <0x0 0x80000000 0x0 0x600000>;
> + no-map;
This should conflict with the memory defined in this file:
memory@80000000 {
device_type = "memory";
/* We expect the bootloader to fill in the size */
reg = <0 0x80000000 0 0>;
};
I think this should be updated?
--
~Vinod
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3 06/10] arm64: dts: qcom: sc7280: Update reserved memory map
[not found] ` <39da02506af192de14d346cdf80d0e4c@codeaurora.org>
@ 2021-08-20 17:06 ` Bjorn Andersson
0 siblings, 0 replies; 7+ messages in thread
From: Bjorn Andersson @ 2021-08-20 17:06 UTC (permalink / raw)
To: Sibi Sankar
Cc: Vinod Koul, robh+dt, will, saiprakash.ranjan, swboyd, mka, ohad,
agross, mathieu.poirier, robin.murphy, joro, p.zabel,
linux-arm-msm, linux-remoteproc, devicetree, linux-kernel,
linux-arm-kernel, evgreen, dianders
On Fri 20 Aug 07:09 PDT 2021, Sibi Sankar wrote:
> On 2021-08-19 10:07, Vinod Koul wrote:
> > Hi Sibi,
> >
> > On 19-08-21, 09:06, Sibi Sankar wrote:
> >
> > > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > > b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > > index 5e4f4f3b738a..894106efadfe 100644
> > > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > > @@ -48,6 +48,16 @@
> > > #size-cells = <2>;
> > > ranges;
> > >
> > > + hyp_mem: memory@80000000 {
> > > + reg = <0x0 0x80000000 0x0 0x600000>;
> > > + no-map;
> >
> > This should conflict with the memory defined in this file:
> >
> > memory@80000000 {
> > device_type = "memory";
> > /* We expect the bootloader to fill in the size */
> > reg = <0 0x80000000 0 0>;
> > };
> >
> > I think this should be updated?
>
> Vinod,
>
> I prefer we leave ^^ node untouched. For platforms using hyp_mem, the
> regions defined in the memory map are valid and for the other
> platforms not using hyp_mem we would just delete them in the board
> files anyway.
Logically this node describes where there is RAM, the reserved-memory
then subtracts blocks of memory out of that. So I think it's perfectly
legal for a region at the base to be marked as no-map.
That said, isn't the address in the memory node just a placeholder?
Regards,
Bjorn
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3 10/10] arm64: dts: qcom: sc7280: Update Q6V5 MSS node
[not found] ` <1629344185-27368-11-git-send-email-sibis@codeaurora.org>
@ 2021-08-23 20:12 ` Stephen Boyd
0 siblings, 0 replies; 7+ messages in thread
From: Stephen Boyd @ 2021-08-23 20:12 UTC (permalink / raw)
To: Sibi Sankar, bjorn.andersson, mka, robh+dt, saiprakash.ranjan, will
Cc: ohad, agross, mathieu.poirier, robin.murphy, joro, p.zabel,
linux-arm-msm, linux-remoteproc, devicetree, linux-kernel,
linux-arm-kernel, evgreen, dianders
Quoting Sibi Sankar (2021-08-18 20:36:25)
> Update MSS node to support MSA based modem boot on SC7280 SoCs.
>
> Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
> ---
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
>
> v3:
> * Place remoteproc_mpss node in alphabetical order above pinctrl
> section. [Stephen]
>
> arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 7 +++++++
> arch/arm64/boot/dts/qcom/sc7280.dtsi | 19 ++++++++++++++++---
> 2 files changed, 23 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
> index 103d89c1e1c7..f1c8641b0c26 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
> @@ -263,6 +263,13 @@
> status = "okay";
> };
>
> +&remoteproc_mpss {
> + status = "okay";
> + compatible = "qcom,sc7280-mss-pil";
> + iommus = <&apps_smmu 0x124 0x0>, <&apps_smmu 0x488 0x7>;
> + memory-region = <&mba_mem &mpss_mem>;
Nitpick:
memory-region = <&mba_mem>, <&mpss_mem>;
would be better as it indicates that &mpss_mem isn't being parsed when
&mba_mem is being parsed, i.e. they're independent phandles.
> +};
> +
> &sdhc_1 {
> status = "okay";
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3 08/10] arm64: dts: qcom: sc7280: Add nodes to boot modem
[not found] ` <1629344185-27368-9-git-send-email-sibis@codeaurora.org>
@ 2021-08-23 20:12 ` Stephen Boyd
0 siblings, 0 replies; 7+ messages in thread
From: Stephen Boyd @ 2021-08-23 20:12 UTC (permalink / raw)
To: Sibi Sankar, bjorn.andersson, mka, robh+dt, saiprakash.ranjan, will
Cc: ohad, agross, mathieu.poirier, robin.murphy, joro, p.zabel,
linux-arm-msm, linux-remoteproc, devicetree, linux-kernel,
linux-arm-kernel, evgreen, dianders
Quoting Sibi Sankar (2021-08-18 20:36:23)
> Add miscellaneous nodes to boot the modem and support post-mortem debug
> on SC7280 SoCs.
>
> Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
> ---
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3 03/10] dt-bindings: remoteproc: qcom: Update Q6V5 Modem PIL binding
[not found] ` <1629344185-27368-4-git-send-email-sibis@codeaurora.org>
@ 2021-08-23 20:14 ` Stephen Boyd
0 siblings, 0 replies; 7+ messages in thread
From: Stephen Boyd @ 2021-08-23 20:14 UTC (permalink / raw)
To: Sibi Sankar, bjorn.andersson, mka, robh+dt, saiprakash.ranjan, will
Cc: ohad, agross, mathieu.poirier, robin.murphy, joro, p.zabel,
linux-arm-msm, linux-remoteproc, devicetree, linux-kernel,
linux-arm-kernel, evgreen, dianders
Quoting Sibi Sankar (2021-08-18 20:36:18)
> Add a new modem compatible string for QTI SC7280 SoCs and introduce the
> "qcom,ext-regs" and "qcom,qaccept-regs" properties needed by the modem
> sub-system running on SC7280 SoCs.
>
> Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
> Acked-by: Rob Herring <robh@kernel.org>
> ---
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3 02/10] remoteproc: qcom: pas: Add SC7280 Modem support
[not found] ` <1629344185-27368-3-git-send-email-sibis@codeaurora.org>
@ 2021-08-23 20:14 ` Stephen Boyd
0 siblings, 0 replies; 7+ messages in thread
From: Stephen Boyd @ 2021-08-23 20:14 UTC (permalink / raw)
To: Sibi Sankar, bjorn.andersson, mka, robh+dt, saiprakash.ranjan, will
Cc: ohad, agross, mathieu.poirier, robin.murphy, joro, p.zabel,
linux-arm-msm, linux-remoteproc, devicetree, linux-kernel,
linux-arm-kernel, evgreen, dianders
Quoting Sibi Sankar (2021-08-18 20:36:17)
> Add support for booting the Modem DSP found on QTI SC7280 SoCs.
>
> Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
> ---
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3 01/10] dt-bindings: remoteproc: qcom: pas: Add SC7280 MPSS support
[not found] ` <1629344185-27368-2-git-send-email-sibis@codeaurora.org>
@ 2021-08-23 20:14 ` Stephen Boyd
0 siblings, 0 replies; 7+ messages in thread
From: Stephen Boyd @ 2021-08-23 20:14 UTC (permalink / raw)
To: Sibi Sankar, bjorn.andersson, mka, robh+dt, saiprakash.ranjan, will
Cc: ohad, agross, mathieu.poirier, robin.murphy, joro, p.zabel,
linux-arm-msm, linux-remoteproc, devicetree, linux-kernel,
linux-arm-kernel, evgreen, dianders
Quoting Sibi Sankar (2021-08-18 20:36:16)
> Add MPSS PAS support for SC7280 SoCs.
>
> Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
> Acked-by: Rob Herring <robh@kernel.org>
> ---
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-08-23 20:17 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1629344185-27368-1-git-send-email-sibis@codeaurora.org>
[not found] ` <1629344185-27368-7-git-send-email-sibis@codeaurora.org>
2021-08-19 4:37 ` [PATCH v3 06/10] arm64: dts: qcom: sc7280: Update reserved memory map Vinod Koul
[not found] ` <39da02506af192de14d346cdf80d0e4c@codeaurora.org>
2021-08-20 17:06 ` Bjorn Andersson
[not found] ` <1629344185-27368-11-git-send-email-sibis@codeaurora.org>
2021-08-23 20:12 ` [PATCH v3 10/10] arm64: dts: qcom: sc7280: Update Q6V5 MSS node Stephen Boyd
[not found] ` <1629344185-27368-9-git-send-email-sibis@codeaurora.org>
2021-08-23 20:12 ` [PATCH v3 08/10] arm64: dts: qcom: sc7280: Add nodes to boot modem Stephen Boyd
[not found] ` <1629344185-27368-4-git-send-email-sibis@codeaurora.org>
2021-08-23 20:14 ` [PATCH v3 03/10] dt-bindings: remoteproc: qcom: Update Q6V5 Modem PIL binding Stephen Boyd
[not found] ` <1629344185-27368-3-git-send-email-sibis@codeaurora.org>
2021-08-23 20:14 ` [PATCH v3 02/10] remoteproc: qcom: pas: Add SC7280 Modem support Stephen Boyd
[not found] ` <1629344185-27368-2-git-send-email-sibis@codeaurora.org>
2021-08-23 20:14 ` [PATCH v3 01/10] dt-bindings: remoteproc: qcom: pas: Add SC7280 MPSS support Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).