From: Daniel Baluta <daniel.baluta@gmail.com>
To: Anson Huang <Anson.Huang@nxp.com>
Cc: Aisheng Dong <aisheng.dong@nxp.com>,
Abel Vesa <abel.vesa@nxp.com>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Daniel Baluta <daniel.baluta@nxp.com>,
dl-linux-imx <Linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] soc: imx-scu: Add SoC UID(unique identifier) support
Date: Wed, 26 Jun 2019 15:41:54 +0300 [thread overview]
Message-ID: <CAEnQRZBsT=KY3-Gk8p1byJOqx1_y_EX-KqiBs6WnroWkT5oe_Q@mail.gmail.com> (raw)
In-Reply-To: <20190626070706.24930-1-Anson.Huang@nxp.com>
On Wed, Jun 26, 2019 at 10:06 AM <Anson.Huang@nxp.com> wrote:
>
> From: Anson Huang <Anson.Huang@nxp.com>
>
> Add i.MX SCU SoC's UID(unique identifier) support, user
> can read it from sysfs:
>
> root@imx8qxpmek:~# cat /sys/devices/soc0/soc_uid
> 7B64280B57AC1898
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> drivers/soc/imx/soc-imx-scu.c | 35 +++++++++++++++++++++++++++++++++++
> 1 file changed, 35 insertions(+)
>
> diff --git a/drivers/soc/imx/soc-imx-scu.c b/drivers/soc/imx/soc-imx-scu.c
> index 676f612..8d322a1 100644
> --- a/drivers/soc/imx/soc-imx-scu.c
> +++ b/drivers/soc/imx/soc-imx-scu.c
> @@ -27,6 +27,36 @@ struct imx_sc_msg_misc_get_soc_id {
> } data;
> } __packed;
>
> +struct imx_sc_msg_misc_get_soc_uid {
> + struct imx_sc_rpc_msg hdr;
> + u32 uid_low;
> + u32 uid_high;
> +} __packed;
> +
> +static ssize_t soc_uid_show(struct device *dev,
> + struct device_attribute *attr, char *buf)
> +{
> + struct imx_sc_msg_misc_get_soc_uid msg;
> + struct imx_sc_rpc_msg *hdr = &msg.hdr;
> + u64 soc_uid;
> +
> + hdr->ver = IMX_SC_RPC_VERSION;
> + hdr->svc = IMX_SC_RPC_SVC_MISC;
> + hdr->func = IMX_SC_MISC_FUNC_UNIQUE_ID;
> + hdr->size = 1;
> +
> + /* the return value of SCU FW is in correct, skip return value check */
Why do you mean by "in correct"?
> + imx_scu_call_rpc(soc_ipc_handle, &msg, true);
> +
> + soc_uid = msg.uid_high;
> + soc_uid <<= 32;
> + soc_uid |= msg.uid_low;
> +
> + return sprintf(buf, "%016llX\n", soc_uid);
snprintf?
> +}
> +
> +static DEVICE_ATTR_RO(soc_uid);
> +
> static int imx_scu_soc_id(void)
> {
> struct imx_sc_msg_misc_get_soc_id msg;
> @@ -102,6 +132,11 @@ static int imx_scu_soc_probe(struct platform_device *pdev)
> goto free_revision;
> }
>
> + ret = device_create_file(soc_device_to_device(soc_dev),
> + &dev_attr_soc_uid);
> + if (ret)
> + goto free_revision;
> +
> return 0;
>
> free_revision:
> --
> 2.7.4
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-26 12:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-26 7:07 [PATCH] soc: imx-scu: Add SoC UID(unique identifier) support Anson.Huang
2019-06-26 12:41 ` Daniel Baluta [this message]
2019-06-27 0:48 ` Anson Huang
2019-06-27 6:43 ` Daniel Baluta
2019-06-27 7:01 ` Anson Huang
2019-07-02 6:42 ` Marco Felsch
2019-07-02 7:23 ` Anson Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEnQRZBsT=KY3-Gk8p1byJOqx1_y_EX-KqiBs6WnroWkT5oe_Q@mail.gmail.com' \
--to=daniel.baluta@gmail.com \
--cc=Anson.Huang@nxp.com \
--cc=Linux-imx@nxp.com \
--cc=abel.vesa@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=daniel.baluta@nxp.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).