linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] arm64: dts: meson-g12a: Remove 'enable-active-low'
@ 2022-08-27 17:50 Fabio Estevam
  2022-08-27 17:50 ` [PATCH 2/2] arm64: dts: meson-sm1-sei610: " Fabio Estevam
  2022-08-27 20:34 ` [PATCH 1/2] arm64: dts: meson-g12a: " Martin Blumenstingl
  0 siblings, 2 replies; 4+ messages in thread
From: Fabio Estevam @ 2022-08-27 17:50 UTC (permalink / raw)
  To: martin.blumenstingl; +Cc: linux-arm-kernel, khilman, Fabio Estevam

The 'enable-active-low' property is not a valid one. 

Only 'enable-active-high' is valid, and when this property is absent
the gpio regulator will act as active low by default.

Remove the invalid 'enable-active-low' property.

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts b/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
index b4e86196e346..b2bb94981838 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
@@ -111,7 +111,6 @@ vcc_5v: regulator-vcc_5v {
 		vin-supply = <&dc_in>;
 
 		gpio = <&gpio GPIOH_8 GPIO_OPEN_DRAIN>;
-		enable-active-low;
 	};
 
 	vddao_1v8: regulator-vddao_1v8 {
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/2] arm64: dts: meson-sm1-sei610: Remove 'enable-active-low'
  2022-08-27 17:50 [PATCH 1/2] arm64: dts: meson-g12a: Remove 'enable-active-low' Fabio Estevam
@ 2022-08-27 17:50 ` Fabio Estevam
  2022-08-27 20:35   ` Martin Blumenstingl
  2022-08-27 20:34 ` [PATCH 1/2] arm64: dts: meson-g12a: " Martin Blumenstingl
  1 sibling, 1 reply; 4+ messages in thread
From: Fabio Estevam @ 2022-08-27 17:50 UTC (permalink / raw)
  To: martin.blumenstingl; +Cc: linux-arm-kernel, khilman, Fabio Estevam

The 'enable-active-low' property is not a valid one. 

Only 'enable-active-high' is valid, and when this property is absent
the gpio regulator will act as active low by default.

Remove the invalid 'enable-active-low' property.

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts b/arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts
index 603337ca5608..9068a334ea57 100644
--- a/arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts
@@ -171,7 +171,6 @@ vddao_3v3_t: regulator-vddao_3v3_t {
 		regulator-max-microvolt = <3300000>;
 		vin-supply = <&vddao_3v3>;
 		gpio = <&gpio GPIOH_8 GPIO_OPEN_DRAIN>;
-		enable-active-low;
 		regulator-always-on;
 	};
 
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] arm64: dts: meson-g12a: Remove 'enable-active-low'
  2022-08-27 17:50 [PATCH 1/2] arm64: dts: meson-g12a: Remove 'enable-active-low' Fabio Estevam
  2022-08-27 17:50 ` [PATCH 2/2] arm64: dts: meson-sm1-sei610: " Fabio Estevam
@ 2022-08-27 20:34 ` Martin Blumenstingl
  1 sibling, 0 replies; 4+ messages in thread
From: Martin Blumenstingl @ 2022-08-27 20:34 UTC (permalink / raw)
  To: Fabio Estevam; +Cc: linux-arm-kernel, khilman

Hi Fabio,

thanks for your patch!

On Sat, Aug 27, 2022 at 7:50 PM Fabio Estevam <festevam@denx.de> wrote:
>
> The 'enable-active-low' property is not a valid one.
>
> Only 'enable-active-high' is valid, and when this property is absent
> the gpio regulator will act as active low by default.
>
> Remove the invalid 'enable-active-low' property.
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

Unfortunately the linux-amlogic mailing list is not in the recipient
list so I don't think that the patch can be applied like this.
Could you please re-sending it with the linux-amlogic list included
(same for patch 2/2)?


Thank you!
Martin

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/2] arm64: dts: meson-sm1-sei610: Remove 'enable-active-low'
  2022-08-27 17:50 ` [PATCH 2/2] arm64: dts: meson-sm1-sei610: " Fabio Estevam
@ 2022-08-27 20:35   ` Martin Blumenstingl
  0 siblings, 0 replies; 4+ messages in thread
From: Martin Blumenstingl @ 2022-08-27 20:35 UTC (permalink / raw)
  To: Fabio Estevam; +Cc: linux-arm-kernel, khilman

On Sat, Aug 27, 2022 at 7:50 PM Fabio Estevam <festevam@denx.de> wrote:
>
> The 'enable-active-low' property is not a valid one.
>
> Only 'enable-active-high' is valid, and when this property is absent
> the gpio regulator will act as active low by default.
>
> Remove the invalid 'enable-active-low' property.
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-08-27 20:36 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-27 17:50 [PATCH 1/2] arm64: dts: meson-g12a: Remove 'enable-active-low' Fabio Estevam
2022-08-27 17:50 ` [PATCH 2/2] arm64: dts: meson-sm1-sei610: " Fabio Estevam
2022-08-27 20:35   ` Martin Blumenstingl
2022-08-27 20:34 ` [PATCH 1/2] arm64: dts: meson-g12a: " Martin Blumenstingl

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).