linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/1] ARM: imx_v6_v7_defconfig: Enable SMSC Ethernet PHY
@ 2023-03-19 23:47 Chris Healy
  2023-03-20  3:07 ` Fabio Estevam
  0 siblings, 1 reply; 3+ messages in thread
From: Chris Healy @ 2023-03-19 23:47 UTC (permalink / raw)
  To: linux, shawnguo, s.hauer, kernel, festevam, linux-imx, arnd,
	linux-arm-kernel, linux-kernel, andrew
  Cc: Chris Healy

From: Chris Healy <healych@amazon.com>

The imx53 base imx53qsb uses an SMSC Ethernet PHY.  Enable it's driver.

Signed-off-by: Chris Healy <healych@amazon.com>
---
 arch/arm/configs/imx_v6_v7_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
index 6dc6fed12af8..a12d45e99782 100644
--- a/arch/arm/configs/imx_v6_v7_defconfig
+++ b/arch/arm/configs/imx_v6_v7_defconfig
@@ -135,6 +135,7 @@ CONFIG_SMSC911X=y
 # CONFIG_NET_VENDOR_STMICRO is not set
 CONFIG_MICREL_PHY=y
 CONFIG_AT803X_PHY=y
+CONFIG_SMSC_PHY=y
 CONFIG_CAN_FLEXCAN=y
 CONFIG_USB_PEGASUS=m
 CONFIG_USB_RTL8150=m
-- 
2.39.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] ARM: imx_v6_v7_defconfig: Enable SMSC Ethernet PHY
  2023-03-19 23:47 [PATCH 1/1] ARM: imx_v6_v7_defconfig: Enable SMSC Ethernet PHY Chris Healy
@ 2023-03-20  3:07 ` Fabio Estevam
  2023-03-20 14:00   ` Chris Healy
  0 siblings, 1 reply; 3+ messages in thread
From: Fabio Estevam @ 2023-03-20  3:07 UTC (permalink / raw)
  To: Chris Healy
  Cc: linux, shawnguo, s.hauer, kernel, linux-imx, arnd,
	linux-arm-kernel, linux-kernel, andrew, Chris Healy

Hi Chris,

On Sun, Mar 19, 2023 at 8:47 PM Chris Healy <cphealy@gmail.com> wrote:
>
> From: Chris Healy <healych@amazon.com>
>
> The imx53 base imx53qsb uses an SMSC Ethernet PHY.  Enable it's driver.
>
> Signed-off-by: Chris Healy <healych@amazon.com>
> ---
>  arch/arm/configs/imx_v6_v7_defconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
> index 6dc6fed12af8..a12d45e99782 100644
> --- a/arch/arm/configs/imx_v6_v7_defconfig
> +++ b/arch/arm/configs/imx_v6_v7_defconfig
> @@ -135,6 +135,7 @@ CONFIG_SMSC911X=y
>  # CONFIG_NET_VENDOR_STMICRO is not set
>  CONFIG_MICREL_PHY=y
>  CONFIG_AT803X_PHY=y
> +CONFIG_SMSC_PHY=y

Running 'make imx_v6_v7_defconfig' causes CONFIG_SMSC_PHY=y to be
selected by default
because USB_NET_SMSC95XX is already enabled.

It seems that we don't need to explicitly select CONFIG_SMSC_PHY=y as
done in this patch.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] ARM: imx_v6_v7_defconfig: Enable SMSC Ethernet PHY
  2023-03-20  3:07 ` Fabio Estevam
@ 2023-03-20 14:00   ` Chris Healy
  0 siblings, 0 replies; 3+ messages in thread
From: Chris Healy @ 2023-03-20 14:00 UTC (permalink / raw)
  To: Fabio Estevam
  Cc: linux, shawnguo, s.hauer, kernel, linux-imx, arnd,
	linux-arm-kernel, linux-kernel, andrew, Chris Healy

On Sun, Mar 19, 2023 at 8:07 PM Fabio Estevam <festevam@gmail.com> wrote:
>
> Hi Chris,
>
> On Sun, Mar 19, 2023 at 8:47 PM Chris Healy <cphealy@gmail.com> wrote:
> >
> > From: Chris Healy <healych@amazon.com>
> >
> > The imx53 base imx53qsb uses an SMSC Ethernet PHY.  Enable it's driver.
> >
> > Signed-off-by: Chris Healy <healych@amazon.com>
> > ---
> >  arch/arm/configs/imx_v6_v7_defconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
> > index 6dc6fed12af8..a12d45e99782 100644
> > --- a/arch/arm/configs/imx_v6_v7_defconfig
> > +++ b/arch/arm/configs/imx_v6_v7_defconfig
> > @@ -135,6 +135,7 @@ CONFIG_SMSC911X=y
> >  # CONFIG_NET_VENDOR_STMICRO is not set
> >  CONFIG_MICREL_PHY=y
> >  CONFIG_AT803X_PHY=y
> > +CONFIG_SMSC_PHY=y
>
> Running 'make imx_v6_v7_defconfig' causes CONFIG_SMSC_PHY=y to be
> selected by default
> because USB_NET_SMSC95XX is already enabled.
>
> It seems that we don't need to explicitly select CONFIG_SMSC_PHY=y as
> done in this patch.

I see what you are saying.  I agree this patch is no longer necessary.  Tnx.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-03-20 14:02 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-19 23:47 [PATCH 1/1] ARM: imx_v6_v7_defconfig: Enable SMSC Ethernet PHY Chris Healy
2023-03-20  3:07 ` Fabio Estevam
2023-03-20 14:00   ` Chris Healy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).